95 lines
4.1 KiB
Go
95 lines
4.1 KiB
Go
package handlers
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"io"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strings"
|
|
"testing"
|
|
|
|
"gitea.futuresens.co.uk/futuresens/hardlink/v2/config"
|
|
"gitea.futuresens.co.uk/futuresens/hardlink/v2/internal/paymentsvc"
|
|
"gitea.futuresens.co.uk/futuresens/hardlink/v2/paymentapi"
|
|
"gitea.futuresens.co.uk/futuresens/hardlink/v2/paymentstatus"
|
|
)
|
|
|
|
type paymentProviderFunc func(context.Context, paymentsvc.SaleRequest, paymentsvc.StatusHandler) (*paymentsvc.Result, error)
|
|
|
|
func (f paymentProviderFunc) Sale(ctx context.Context, req paymentsvc.SaleRequest, status paymentsvc.StatusHandler) (*paymentsvc.Result, error) {
|
|
return f(ctx, req, status)
|
|
}
|
|
func (paymentProviderFunc) ValidatePreauth(paymentsvc.SaleRequest) error {
|
|
return paymentsvc.ErrPreauthUnsupported
|
|
}
|
|
func (paymentProviderFunc) Preauth(context.Context, paymentsvc.SaleRequest, paymentsvc.StatusHandler) (*paymentsvc.Result, error) {
|
|
return nil, paymentsvc.ErrPreauthUnsupported
|
|
}
|
|
|
|
type paymentStreamMessage = paymentapi.Frame
|
|
|
|
func TestSalePaymentStreamsTerminalUnavailableAsAuthoritativeUnsuccessfulResult(t *testing.T) {
|
|
provider := paymentProviderFunc(func(_ context.Context, req paymentsvc.SaleRequest, status paymentsvc.StatusHandler) (*paymentsvc.Result, error) {
|
|
status(paymentsvc.StatusUpdate{Code: paymentstatus.Starting})
|
|
status(paymentsvc.StatusUpdate{Code: paymentstatus.TerminalUnavailable})
|
|
return &paymentsvc.Result{Terminal: paymentapi.Result{Outcome: "error", HTTPStatus: 200, Reason: "terminal_unavailable", Message: "Payment terminal is unavailable"}}, nil
|
|
})
|
|
recorder := performSalePaymentRequest(t, provider)
|
|
frames := decodePaymentStream(t, recorder.Body)
|
|
if recorder.Code != 200 || len(frames) != 3 || frames[0].Code != paymentstatus.Starting || frames[1].Code != paymentstatus.TerminalUnavailable || frames[2].Result == nil {
|
|
t.Fatalf("SalePayment() HTTP/frames=%d/%+v, want 200 and two statuses plus final", recorder.Code, frames)
|
|
}
|
|
final := frames[2].Result
|
|
if final.Outcome != "error" || final.Reason != "terminal_unavailable" || final.Retryable {
|
|
t.Errorf("SalePayment() final=%+v, want definite nonretryable terminal unavailability", final)
|
|
}
|
|
for _, forbidden := range []string{"Dojo returned HTTP 409", "offline or currently in use", "traceId", "docs.dojo.tech", "\"response\""} {
|
|
if strings.Contains(recorder.Body.String(), forbidden) {
|
|
t.Errorf("SalePayment() leaked %q", forbidden)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestSalePaymentRetainsUncertaintyForProviderErrorsAfterStreamingStarts(t *testing.T) {
|
|
provider := paymentProviderFunc(func(_ context.Context, _ paymentsvc.SaleRequest, status paymentsvc.StatusHandler) (*paymentsvc.Result, error) {
|
|
status(paymentsvc.StatusUpdate{Code: paymentstatus.Starting})
|
|
return nil, errors.New("raw secret provider error")
|
|
})
|
|
recorder := performSalePaymentRequest(t, provider)
|
|
frames := decodePaymentStream(t, recorder.Body)
|
|
if len(frames) != 2 || frames[1].Result == nil || frames[1].Result.Outcome != "unknown" || frames[1].Result.Retryable {
|
|
t.Fatalf("SalePayment() frames=%+v, want progress then nonretryable uncertainty", frames)
|
|
}
|
|
if strings.Contains(recorder.Body.String(), "secret") {
|
|
t.Error("SalePayment() exposed raw provider diagnostics")
|
|
}
|
|
}
|
|
|
|
func performSalePaymentRequest(t *testing.T, provider paymentsvc.Provider) *httptest.ResponseRecorder {
|
|
t.Helper()
|
|
app := &App{isPayment: true, paymentService: paymentsvc.NewService(provider), cfg: &config.ConfigRec{TimeoutSeconds: 1}}
|
|
request := httptest.NewRequest(http.MethodPost, paymentapi.SalePath, strings.NewReader(`{"amount":1234,"currency":"GBP","reference":"SYNTH"}`))
|
|
request.Header.Set("Content-Type", "application/json")
|
|
recorder := httptest.NewRecorder()
|
|
app.salePayment(recorder, request)
|
|
return recorder
|
|
}
|
|
func decodePaymentStream(t *testing.T, body io.Reader) []paymentapi.Frame {
|
|
t.Helper()
|
|
var frames []paymentapi.Frame
|
|
decoder := json.NewDecoder(body)
|
|
for {
|
|
var frame paymentapi.Frame
|
|
err := decoder.Decode(&frame)
|
|
if err == io.EOF {
|
|
return frames
|
|
}
|
|
if err != nil {
|
|
t.Fatalf("DecodePaymentStream() error=%v, want valid frames", err)
|
|
}
|
|
frames = append(frames, frame)
|
|
}
|
|
}
|