Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
18b22b4ea7 |
@@ -34,7 +34,7 @@ import (
|
|||||||
)
|
)
|
||||||
|
|
||||||
const (
|
const (
|
||||||
buildVersion = "v1.3.4"
|
buildVersion = "1.3.2"
|
||||||
serviceName = "hardlink"
|
serviceName = "hardlink"
|
||||||
pollingFrequency = 8 * time.Second
|
pollingFrequency = 8 * time.Second
|
||||||
)
|
)
|
||||||
|
|||||||
+17
-295
@@ -4,18 +4,15 @@ import (
|
|||||||
"bytes"
|
"bytes"
|
||||||
"context"
|
"context"
|
||||||
"encoding/json"
|
"encoding/json"
|
||||||
"errors"
|
|
||||||
"fmt"
|
"fmt"
|
||||||
"io"
|
"io"
|
||||||
"net/http"
|
"net/http"
|
||||||
"net/url"
|
"net/url"
|
||||||
"sort"
|
|
||||||
"strings"
|
"strings"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
"gitea.futuresens.co.uk/futuresens/hardlink/internal/paymentsvc"
|
"gitea.futuresens.co.uk/futuresens/hardlink/internal/paymentsvc"
|
||||||
"gitea.futuresens.co.uk/futuresens/hardlink/internal/types"
|
"gitea.futuresens.co.uk/futuresens/hardlink/internal/types"
|
||||||
"gitea.futuresens.co.uk/futuresens/hardlink/paymentstatus"
|
|
||||||
log "github.com/sirupsen/logrus"
|
log "github.com/sirupsen/logrus"
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -36,43 +33,6 @@ type Client struct {
|
|||||||
httpClient *http.Client
|
httpClient *http.Client
|
||||||
}
|
}
|
||||||
|
|
||||||
const (
|
|
||||||
dojoTerminalUnavailableStatus = "TERMINAL_UNAVAILABLE"
|
|
||||||
dojoTerminalUnavailableMessage = "Payment terminal is unavailable"
|
|
||||||
)
|
|
||||||
|
|
||||||
type httpResponseError struct {
|
|
||||||
StatusCode int
|
|
||||||
Body string
|
|
||||||
}
|
|
||||||
|
|
||||||
func (e *httpResponseError) Error() string {
|
|
||||||
return fmt.Sprintf("Dojo returned HTTP %d: %s", e.StatusCode, e.Body)
|
|
||||||
}
|
|
||||||
|
|
||||||
type terminalSessionWithUpdates struct {
|
|
||||||
terminalSessionResponse
|
|
||||||
|
|
||||||
NotificationEvents []terminalNotificationEvent `json:"notificationEvents"`
|
|
||||||
StatusEvents []terminalStatusEvent `json:"statusEvents"`
|
|
||||||
}
|
|
||||||
|
|
||||||
type terminalNotificationEvent struct {
|
|
||||||
CreatedAt time.Time `json:"createdAt"`
|
|
||||||
NotificationType string `json:"notificationType"`
|
|
||||||
}
|
|
||||||
|
|
||||||
type terminalStatusEvent struct {
|
|
||||||
CreatedAt time.Time `json:"createdAt"`
|
|
||||||
Status string `json:"status"`
|
|
||||||
}
|
|
||||||
|
|
||||||
type terminalDisplayEvent struct {
|
|
||||||
createdAt time.Time
|
|
||||||
code string
|
|
||||||
sessionStatus string
|
|
||||||
}
|
|
||||||
|
|
||||||
func NewClient(cfg Config) (*Client, error) {
|
func NewClient(cfg Config) (*Client, error) {
|
||||||
if cfg.BaseURL == "" {
|
if cfg.BaseURL == "" {
|
||||||
return nil, fmt.Errorf("dojo base_url is required")
|
return nil, fmt.Errorf("dojo base_url is required")
|
||||||
@@ -100,17 +60,11 @@ func NewClient(cfg Config) (*Client, error) {
|
|||||||
}, nil
|
}, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
func (c *Client) Sale(
|
func (c *Client) Sale(ctx context.Context, req paymentsvc.SaleRequest) (*paymentsvc.Result, error) {
|
||||||
ctx context.Context,
|
|
||||||
req paymentsvc.SaleRequest,
|
|
||||||
onStatus paymentsvc.StatusHandler,
|
|
||||||
) (*paymentsvc.Result, error) {
|
|
||||||
if req.Currency == "" {
|
if req.Currency == "" {
|
||||||
req.Currency = "GBP"
|
req.Currency = "GBP"
|
||||||
}
|
}
|
||||||
|
|
||||||
sendPaymentStatus(onStatus, paymentstatus.Starting)
|
|
||||||
|
|
||||||
intent, err := c.createPaymentIntent(ctx, req)
|
intent, err := c.createPaymentIntent(ctx, req)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
@@ -118,25 +72,10 @@ func (c *Client) Sale(
|
|||||||
|
|
||||||
session, err := c.createTerminalSession(ctx, intent.ID)
|
session, err := c.createTerminalSession(ctx, intent.ID)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
var responseErr *httpResponseError
|
|
||||||
if errors.As(err, &responseErr) && responseErr.StatusCode == http.StatusConflict {
|
|
||||||
log.WithFields(log.Fields{
|
|
||||||
"provider": "Dojo",
|
|
||||||
"operation": "createTerminalSession",
|
|
||||||
"status": responseErr.StatusCode,
|
|
||||||
"terminal_unavailable": true,
|
|
||||||
}).Warn(dojoTerminalUnavailableMessage)
|
|
||||||
|
|
||||||
sendPaymentStatus(onStatus, paymentstatus.TerminalUnavailable)
|
|
||||||
result := c.baseResult(req, nil)
|
|
||||||
result.Status = dojoTerminalUnavailableStatus
|
|
||||||
result.ErrorMessage = dojoTerminalUnavailableMessage
|
|
||||||
return result, nil
|
|
||||||
}
|
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
|
|
||||||
session, err = c.waitForTerminalSession(ctx, session.ID, onStatus)
|
session, err = c.waitForTerminalSession(ctx, session.ID)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
@@ -211,17 +150,10 @@ func (c *Client) createTerminalSession(ctx context.Context, paymentIntentID stri
|
|||||||
return &response, nil
|
return &response, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
func (c *Client) waitForTerminalSession(
|
func (c *Client) waitForTerminalSession(ctx context.Context, terminalSessionID string) (*terminalSessionResponse, error) {
|
||||||
ctx context.Context,
|
|
||||||
terminalSessionID string,
|
|
||||||
onStatus paymentsvc.StatusHandler,
|
|
||||||
) (*terminalSessionResponse, error) {
|
|
||||||
ticker := time.NewTicker(time.Second)
|
ticker := time.NewTicker(time.Second)
|
||||||
defer ticker.Stop()
|
defer ticker.Stop()
|
||||||
|
|
||||||
notificationCount := 0
|
|
||||||
statusCount := 0
|
|
||||||
lastSessionStatus := ""
|
|
||||||
signatureRejected := false
|
signatureRejected := false
|
||||||
|
|
||||||
for {
|
for {
|
||||||
@@ -232,40 +164,12 @@ func (c *Client) waitForTerminalSession(
|
|||||||
|
|
||||||
log.Println("session status:", session.Status)
|
log.Println("session status:", session.Status)
|
||||||
|
|
||||||
emitNewTerminalSessionEvents(
|
switch strings.ToLower(session.Status) {
|
||||||
session,
|
case types.ResultInitiateRequested, types.ResultInitiated, types.ResultAuthorized, types.ResultCancelRequested:
|
||||||
¬ificationCount,
|
|
||||||
&statusCount,
|
|
||||||
&lastSessionStatus,
|
|
||||||
onStatus,
|
|
||||||
)
|
|
||||||
|
|
||||||
currentStatus := strings.ToLower(session.Status)
|
|
||||||
if currentStatus != lastSessionStatus {
|
|
||||||
lastSessionStatus = currentStatus
|
|
||||||
sendPaymentStatus(
|
|
||||||
onStatus,
|
|
||||||
mapDojoSessionStatus(session.Status),
|
|
||||||
)
|
|
||||||
}
|
|
||||||
|
|
||||||
switch currentStatus {
|
|
||||||
case types.ResultInitiateRequested,
|
|
||||||
types.ResultInitiated,
|
|
||||||
types.ResultAuthorized,
|
|
||||||
types.ResultCancelRequested:
|
|
||||||
|
|
||||||
case types.ResultSignatureRequired:
|
case types.ResultSignatureRequired:
|
||||||
if !signatureRejected {
|
if !signatureRejected {
|
||||||
sendPaymentStatus(
|
rejectedSession, err := c.rejectSignature(ctx, terminalSessionID)
|
||||||
onStatus,
|
|
||||||
paymentstatus.SignatureRejecting,
|
|
||||||
)
|
|
||||||
|
|
||||||
rejectedSession, err := c.rejectSignature(
|
|
||||||
ctx,
|
|
||||||
terminalSessionID,
|
|
||||||
)
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
@@ -273,206 +177,30 @@ func (c *Client) waitForTerminalSession(
|
|||||||
signatureRejected = true
|
signatureRejected = true
|
||||||
|
|
||||||
if rejectedSession != nil {
|
if rejectedSession != nil {
|
||||||
rejectedStatus := strings.ToLower(
|
switch strings.ToLower(rejectedSession.Status) {
|
||||||
rejectedSession.Status,
|
case types.ResultCaptured, types.ResultCancelled, types.ResultCanceled, types.ResultDeclined,
|
||||||
)
|
types.ResultExpired, types.ResultSignatureAccepted, types.ResultSignatureRejected:
|
||||||
|
|
||||||
if rejectedStatus != lastSessionStatus {
|
|
||||||
lastSessionStatus = rejectedStatus
|
|
||||||
sendPaymentStatus(
|
|
||||||
onStatus,
|
|
||||||
mapDojoSessionStatus(
|
|
||||||
rejectedSession.Status,
|
|
||||||
),
|
|
||||||
)
|
|
||||||
}
|
|
||||||
|
|
||||||
switch rejectedStatus {
|
|
||||||
case types.ResultCaptured,
|
|
||||||
types.ResultCancelled,
|
|
||||||
types.ResultCanceled,
|
|
||||||
types.ResultDeclined,
|
|
||||||
types.ResultExpired,
|
|
||||||
types.ResultSignatureAccepted,
|
|
||||||
types.ResultSignatureRejected:
|
|
||||||
return rejectedSession, nil
|
return rejectedSession, nil
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
case types.ResultCaptured,
|
case types.ResultCaptured, types.ResultCancelled, types.ResultCanceled, types.ResultDeclined,
|
||||||
types.ResultCancelled,
|
types.ResultExpired, types.ResultSignatureAccepted, types.ResultSignatureRejected:
|
||||||
types.ResultCanceled,
|
return session, nil
|
||||||
types.ResultDeclined,
|
|
||||||
types.ResultExpired,
|
|
||||||
types.ResultSignatureAccepted,
|
|
||||||
types.ResultSignatureRejected:
|
|
||||||
return &session.terminalSessionResponse, nil
|
|
||||||
|
|
||||||
default:
|
default:
|
||||||
return nil, fmt.Errorf(
|
return nil, fmt.Errorf("unexpected Dojo terminal session status %q", session.Status)
|
||||||
"unexpected Dojo terminal session status %q",
|
|
||||||
session.Status,
|
|
||||||
)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
select {
|
select {
|
||||||
case <-ctx.Done():
|
case <-ctx.Done():
|
||||||
return nil, ctx.Err()
|
return nil, ctx.Err()
|
||||||
|
|
||||||
case <-ticker.C:
|
case <-ticker.C:
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func emitNewTerminalSessionEvents(
|
|
||||||
session *terminalSessionWithUpdates,
|
|
||||||
notificationCount *int,
|
|
||||||
statusCount *int,
|
|
||||||
lastSessionStatus *string,
|
|
||||||
onStatus paymentsvc.StatusHandler,
|
|
||||||
) {
|
|
||||||
if *notificationCount > len(session.NotificationEvents) {
|
|
||||||
*notificationCount = len(session.NotificationEvents)
|
|
||||||
}
|
|
||||||
if *statusCount > len(session.StatusEvents) {
|
|
||||||
*statusCount = len(session.StatusEvents)
|
|
||||||
}
|
|
||||||
|
|
||||||
newEventCount := len(session.NotificationEvents) - *notificationCount +
|
|
||||||
len(session.StatusEvents) - *statusCount
|
|
||||||
events := make([]terminalDisplayEvent, 0, newEventCount)
|
|
||||||
|
|
||||||
// Add status events first so a notification wins when timestamps are equal.
|
|
||||||
for *statusCount < len(session.StatusEvents) {
|
|
||||||
event := session.StatusEvents[*statusCount]
|
|
||||||
*statusCount = *statusCount + 1
|
|
||||||
|
|
||||||
events = append(events, terminalDisplayEvent{
|
|
||||||
createdAt: event.CreatedAt,
|
|
||||||
code: mapDojoSessionStatus(event.Status),
|
|
||||||
sessionStatus: event.Status,
|
|
||||||
})
|
|
||||||
}
|
|
||||||
|
|
||||||
for *notificationCount < len(session.NotificationEvents) {
|
|
||||||
event := session.NotificationEvents[*notificationCount]
|
|
||||||
*notificationCount = *notificationCount + 1
|
|
||||||
|
|
||||||
events = append(events, terminalDisplayEvent{
|
|
||||||
createdAt: event.CreatedAt,
|
|
||||||
code: mapDojoNotification(event.NotificationType),
|
|
||||||
})
|
|
||||||
}
|
|
||||||
|
|
||||||
sort.SliceStable(events, func(i, j int) bool {
|
|
||||||
return events[i].createdAt.Before(events[j].createdAt)
|
|
||||||
})
|
|
||||||
|
|
||||||
for _, event := range events {
|
|
||||||
if event.sessionStatus != "" {
|
|
||||||
*lastSessionStatus = strings.ToLower(event.sessionStatus)
|
|
||||||
}
|
|
||||||
|
|
||||||
sendPaymentStatus(onStatus, event.code)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
func sendPaymentStatus(
|
|
||||||
handler paymentsvc.StatusHandler,
|
|
||||||
code string,
|
|
||||||
) {
|
|
||||||
if handler == nil || code == "" {
|
|
||||||
return
|
|
||||||
}
|
|
||||||
|
|
||||||
handler(paymentsvc.StatusUpdate{
|
|
||||||
Code: code,
|
|
||||||
})
|
|
||||||
}
|
|
||||||
|
|
||||||
func mapDojoNotification(notification string) string {
|
|
||||||
switch notification {
|
|
||||||
case "PresentCard":
|
|
||||||
return paymentstatus.PresentCard
|
|
||||||
|
|
||||||
case "InsertCard":
|
|
||||||
return paymentstatus.InsertCard
|
|
||||||
|
|
||||||
case "SwipeCard":
|
|
||||||
return paymentstatus.SwipeCard
|
|
||||||
|
|
||||||
case "EnterPin":
|
|
||||||
return paymentstatus.EnterPIN
|
|
||||||
|
|
||||||
case "RemoveCard":
|
|
||||||
return paymentstatus.RemoveCard
|
|
||||||
|
|
||||||
case "PleaseWait":
|
|
||||||
return paymentstatus.PleaseWait
|
|
||||||
|
|
||||||
default:
|
|
||||||
return dojoFallbackStatusCode(
|
|
||||||
paymentstatus.DojoNotificationPrefix,
|
|
||||||
notification,
|
|
||||||
)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
func mapDojoSessionStatus(status string) string {
|
|
||||||
switch strings.ToLower(status) {
|
|
||||||
case types.ResultInitiateRequested:
|
|
||||||
return paymentstatus.Starting
|
|
||||||
|
|
||||||
case types.ResultInitiated:
|
|
||||||
return paymentstatus.Started
|
|
||||||
|
|
||||||
case types.ResultAuthorized:
|
|
||||||
return paymentstatus.Authorized
|
|
||||||
|
|
||||||
case types.ResultCancelRequested:
|
|
||||||
return paymentstatus.Cancelling
|
|
||||||
|
|
||||||
case types.ResultSignatureRequired:
|
|
||||||
return paymentstatus.SignatureRequired
|
|
||||||
|
|
||||||
case types.ResultCaptured, types.ResultSignatureAccepted:
|
|
||||||
return paymentstatus.Approved
|
|
||||||
|
|
||||||
case types.ResultCancelled, types.ResultCanceled:
|
|
||||||
return paymentstatus.Cancelled
|
|
||||||
|
|
||||||
case types.ResultDeclined:
|
|
||||||
return paymentstatus.Declined
|
|
||||||
|
|
||||||
case types.ResultExpired:
|
|
||||||
return paymentstatus.Expired
|
|
||||||
|
|
||||||
case types.ResultSignatureRejected:
|
|
||||||
return paymentstatus.SignatureRejected
|
|
||||||
|
|
||||||
default:
|
|
||||||
return dojoFallbackStatusCode(
|
|
||||||
paymentstatus.DojoStatusPrefix,
|
|
||||||
status,
|
|
||||||
)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
func dojoFallbackStatusCode(prefix, value string) string {
|
|
||||||
value = strings.TrimSpace(value)
|
|
||||||
if value == "" {
|
|
||||||
return ""
|
|
||||||
}
|
|
||||||
|
|
||||||
replacer := strings.NewReplacer(
|
|
||||||
" ", "_",
|
|
||||||
"-", "_",
|
|
||||||
)
|
|
||||||
|
|
||||||
return prefix + strings.ToUpper(replacer.Replace(value))
|
|
||||||
}
|
|
||||||
|
|
||||||
func (c *Client) rejectSignature(ctx context.Context, terminalSessionID string) (*terminalSessionResponse, error) {
|
func (c *Client) rejectSignature(ctx context.Context, terminalSessionID string) (*terminalSessionResponse, error) {
|
||||||
payload := signatureVerificationRequest{
|
payload := signatureVerificationRequest{
|
||||||
Accepted: false,
|
Accepted: false,
|
||||||
@@ -488,11 +216,8 @@ func (c *Client) rejectSignature(ctx context.Context, terminalSessionID string)
|
|||||||
return &response, nil
|
return &response, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
func (c *Client) getTerminalSession(
|
func (c *Client) getTerminalSession(ctx context.Context, terminalSessionID string) (*terminalSessionResponse, error) {
|
||||||
ctx context.Context,
|
var response terminalSessionResponse
|
||||||
terminalSessionID string,
|
|
||||||
) (*terminalSessionWithUpdates, error) {
|
|
||||||
var response terminalSessionWithUpdates
|
|
||||||
path := "/terminal-sessions/" + url.PathEscape(terminalSessionID)
|
path := "/terminal-sessions/" + url.PathEscape(terminalSessionID)
|
||||||
if err := c.doJSON(ctx, http.MethodGet, path, nil, true, &response); err != nil {
|
if err := c.doJSON(ctx, http.MethodGet, path, nil, true, &response); err != nil {
|
||||||
return nil, fmt.Errorf("get Dojo terminal session: %w", err)
|
return nil, fmt.Errorf("get Dojo terminal session: %w", err)
|
||||||
@@ -599,13 +324,10 @@ func (c *Client) doJSON(ctx context.Context, method, path string, payload any, t
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
return fmt.Errorf("read response: %w", err)
|
return fmt.Errorf("read response: %w", err)
|
||||||
}
|
}
|
||||||
// log.Println("Dojo payment result raw:", string(responseBody))
|
|
||||||
if resp.StatusCode < http.StatusOK ||
|
if resp.StatusCode < http.StatusOK ||
|
||||||
resp.StatusCode >= http.StatusMultipleChoices {
|
resp.StatusCode >= http.StatusMultipleChoices {
|
||||||
return &httpResponseError{
|
return fmt.Errorf("Dojo returned HTTP %d: %s", resp.StatusCode, strings.TrimSpace(string(responseBody)))
|
||||||
StatusCode: resp.StatusCode,
|
|
||||||
Body: strings.TrimSpace(string(responseBody)),
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
if target == nil || len(responseBody) == 0 {
|
if target == nil || len(responseBody) == 0 {
|
||||||
|
|||||||
@@ -1,199 +0,0 @@
|
|||||||
package dojo
|
|
||||||
|
|
||||||
import (
|
|
||||||
"context"
|
|
||||||
"errors"
|
|
||||||
"fmt"
|
|
||||||
"net/http"
|
|
||||||
"net/http/httptest"
|
|
||||||
"reflect"
|
|
||||||
"strings"
|
|
||||||
"sync/atomic"
|
|
||||||
"testing"
|
|
||||||
|
|
||||||
"gitea.futuresens.co.uk/futuresens/hardlink/internal/paymentsvc"
|
|
||||||
"gitea.futuresens.co.uk/futuresens/hardlink/paymentstatus"
|
|
||||||
)
|
|
||||||
|
|
||||||
const terminalUnavailableBody = `{"detail":"the terminal is either offline or currently in use","errors":{},"status":409,"title":"terminal unavailable","traceId":"trace-secret","type":"https://docs.dojo.tech/problems/terminal-unavailable"}`
|
|
||||||
|
|
||||||
func TestDoJSONReturnsStructuredHTTPResponseError(t *testing.T) {
|
|
||||||
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
|
|
||||||
w.WriteHeader(http.StatusConflict)
|
|
||||||
_, _ = w.Write([]byte(" " + terminalUnavailableBody + " "))
|
|
||||||
}))
|
|
||||||
defer server.Close()
|
|
||||||
|
|
||||||
client := newDojoTestClient(t, server)
|
|
||||||
err := client.doJSON(context.Background(), http.MethodPost, "/payment-intents", nil, false, nil)
|
|
||||||
|
|
||||||
var responseErr *httpResponseError
|
|
||||||
if !errors.As(err, &responseErr) {
|
|
||||||
t.Fatalf("error = %T %v, want *httpResponseError", err, err)
|
|
||||||
}
|
|
||||||
if responseErr.StatusCode != http.StatusConflict {
|
|
||||||
t.Fatalf("StatusCode = %d, want %d", responseErr.StatusCode, http.StatusConflict)
|
|
||||||
}
|
|
||||||
if responseErr.Body != terminalUnavailableBody {
|
|
||||||
t.Fatalf("Body = %q, want retained trimmed response", responseErr.Body)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
func TestSaleMapsCreateTerminalSessionConflictToTerminalUnavailable(t *testing.T) {
|
|
||||||
var paymentIntentRequests atomic.Int32
|
|
||||||
var terminalSessionRequests atomic.Int32
|
|
||||||
var unexpectedRequests atomic.Int32
|
|
||||||
|
|
||||||
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
||||||
switch {
|
|
||||||
case r.Method == http.MethodPost && r.URL.Path == "/payment-intents":
|
|
||||||
paymentIntentRequests.Add(1)
|
|
||||||
w.Header().Set("Content-Type", "application/json")
|
|
||||||
_, _ = fmt.Fprintln(w, `{"id":"intent-123"}`)
|
|
||||||
case r.Method == http.MethodPost && r.URL.Path == "/terminal-sessions":
|
|
||||||
terminalSessionRequests.Add(1)
|
|
||||||
w.Header().Set("Content-Type", "application/problem+json")
|
|
||||||
w.WriteHeader(http.StatusConflict)
|
|
||||||
_, _ = fmt.Fprintln(w, terminalUnavailableBody)
|
|
||||||
default:
|
|
||||||
unexpectedRequests.Add(1)
|
|
||||||
http.Error(w, "unexpected request", http.StatusInternalServerError)
|
|
||||||
}
|
|
||||||
}))
|
|
||||||
defer server.Close()
|
|
||||||
|
|
||||||
client := newDojoTestClient(t, server)
|
|
||||||
request := paymentsvc.SaleRequest{
|
|
||||||
RequestID: "REQ-123",
|
|
||||||
Reference: "BOOKING-123",
|
|
||||||
Amount: 10852,
|
|
||||||
Currency: "GBP",
|
|
||||||
}
|
|
||||||
var statuses []string
|
|
||||||
result, err := client.Sale(context.Background(), request, func(update paymentsvc.StatusUpdate) {
|
|
||||||
statuses = append(statuses, update.Code)
|
|
||||||
})
|
|
||||||
|
|
||||||
if err != nil {
|
|
||||||
t.Fatal(err)
|
|
||||||
}
|
|
||||||
if result == nil {
|
|
||||||
t.Fatal("Sale returned nil result")
|
|
||||||
}
|
|
||||||
if result.Success || result.Status == "APPROVED" {
|
|
||||||
t.Fatalf("result was accidentally successful: %+v", result)
|
|
||||||
}
|
|
||||||
if result.Status != dojoTerminalUnavailableStatus || result.ErrorMessage != dojoTerminalUnavailableMessage {
|
|
||||||
t.Fatalf("terminal-unavailable result = %+v", result)
|
|
||||||
}
|
|
||||||
if result.RequestID != request.RequestID ||
|
|
||||||
result.Operation != "SALE" ||
|
|
||||||
result.Amount != request.Amount ||
|
|
||||||
result.Currency != request.Currency ||
|
|
||||||
result.DeviceUsed != "terminal-1" ||
|
|
||||||
result.DeviceType != "Dojo Terminal" {
|
|
||||||
t.Fatalf("base result fields were not retained: %+v", result)
|
|
||||||
}
|
|
||||||
if result.TransactionID != "" || result.CustomerReceipt != "" || result.MerchantReceipt != "" {
|
|
||||||
t.Fatalf("terminal-unavailable result invented transaction data: %+v", result)
|
|
||||||
}
|
|
||||||
if !reflect.DeepEqual(statuses, []string{paymentstatus.Starting, paymentstatus.TerminalUnavailable}) {
|
|
||||||
t.Fatalf("statuses = %#v", statuses)
|
|
||||||
}
|
|
||||||
if paymentIntentRequests.Load() != 1 || terminalSessionRequests.Load() != 1 || unexpectedRequests.Load() != 0 {
|
|
||||||
t.Fatalf(
|
|
||||||
"requests: intent=%d terminal=%d unexpected=%d",
|
|
||||||
paymentIntentRequests.Load(),
|
|
||||||
terminalSessionRequests.Load(),
|
|
||||||
unexpectedRequests.Load(),
|
|
||||||
)
|
|
||||||
}
|
|
||||||
|
|
||||||
resultText := fmt.Sprintf("%+v", result)
|
|
||||||
for _, forbidden := range []string{"offline or currently in use", "trace-secret", "docs.dojo.tech", terminalUnavailableBody} {
|
|
||||||
if strings.Contains(resultText, forbidden) {
|
|
||||||
t.Fatalf("result exposed %q: %s", forbidden, resultText)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
func TestSaleDoesNotClassifyPaymentIntentConflictAsTerminalUnavailable(t *testing.T) {
|
|
||||||
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
||||||
if r.URL.Path != "/payment-intents" {
|
|
||||||
t.Errorf("unexpected request %s %s", r.Method, r.URL.Path)
|
|
||||||
}
|
|
||||||
w.WriteHeader(http.StatusConflict)
|
|
||||||
_, _ = fmt.Fprintln(w, terminalUnavailableBody)
|
|
||||||
}))
|
|
||||||
defer server.Close()
|
|
||||||
|
|
||||||
client := newDojoTestClient(t, server)
|
|
||||||
var statuses []string
|
|
||||||
result, err := client.Sale(context.Background(), paymentsvc.SaleRequest{
|
|
||||||
RequestID: "REQ-123",
|
|
||||||
Amount: 10852,
|
|
||||||
Currency: "GBP",
|
|
||||||
}, func(update paymentsvc.StatusUpdate) {
|
|
||||||
statuses = append(statuses, update.Code)
|
|
||||||
})
|
|
||||||
|
|
||||||
if result != nil || err == nil {
|
|
||||||
t.Fatalf("Sale result/error = %+v/%v, want nil generic error", result, err)
|
|
||||||
}
|
|
||||||
var responseErr *httpResponseError
|
|
||||||
if !errors.As(err, &responseErr) || responseErr.StatusCode != http.StatusConflict {
|
|
||||||
t.Fatalf("error = %T %v, want wrapped HTTP 409", err, err)
|
|
||||||
}
|
|
||||||
if !reflect.DeepEqual(statuses, []string{paymentstatus.Starting}) {
|
|
||||||
t.Fatalf("statuses = %#v, want only PAYMENT_STARTING", statuses)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
func TestSaleRetainsGenericCreateTerminalSessionErrors(t *testing.T) {
|
|
||||||
for _, statusCode := range []int{http.StatusBadRequest, http.StatusBadGateway} {
|
|
||||||
t.Run(http.StatusText(statusCode), func(t *testing.T) {
|
|
||||||
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
||||||
switch r.URL.Path {
|
|
||||||
case "/payment-intents":
|
|
||||||
_, _ = fmt.Fprintln(w, `{"id":"intent-123"}`)
|
|
||||||
case "/terminal-sessions":
|
|
||||||
w.WriteHeader(statusCode)
|
|
||||||
_, _ = fmt.Fprintln(w, `{"detail":"provider failure"}`)
|
|
||||||
default:
|
|
||||||
t.Errorf("unexpected request %s %s", r.Method, r.URL.Path)
|
|
||||||
}
|
|
||||||
}))
|
|
||||||
defer server.Close()
|
|
||||||
|
|
||||||
client := newDojoTestClient(t, server)
|
|
||||||
result, err := client.Sale(context.Background(), paymentsvc.SaleRequest{
|
|
||||||
RequestID: "REQ-123",
|
|
||||||
Amount: 10852,
|
|
||||||
Currency: "GBP",
|
|
||||||
}, nil)
|
|
||||||
|
|
||||||
if result != nil || err == nil {
|
|
||||||
t.Fatalf("Sale result/error = %+v/%v, want nil generic error", result, err)
|
|
||||||
}
|
|
||||||
var responseErr *httpResponseError
|
|
||||||
if !errors.As(err, &responseErr) || responseErr.StatusCode != statusCode {
|
|
||||||
t.Fatalf("error = %T %v, want wrapped HTTP %d", err, err, statusCode)
|
|
||||||
}
|
|
||||||
})
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
func newDojoTestClient(t *testing.T, server *httptest.Server) *Client {
|
|
||||||
t.Helper()
|
|
||||||
client, err := NewClient(Config{
|
|
||||||
BaseURL: server.URL,
|
|
||||||
APIKey: "test-api-key",
|
|
||||||
SoftwareHouseID: "software-house-1",
|
|
||||||
TerminalID: "terminal-1",
|
|
||||||
})
|
|
||||||
if err != nil {
|
|
||||||
t.Fatal(err)
|
|
||||||
}
|
|
||||||
client.httpClient = server.Client()
|
|
||||||
return client
|
|
||||||
}
|
|
||||||
@@ -9,7 +9,6 @@ import (
|
|||||||
"net/http"
|
"net/http"
|
||||||
"net/url"
|
"net/url"
|
||||||
"strings"
|
"strings"
|
||||||
"sync"
|
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
"gitea.futuresens.co.uk/futuresens/cmstypes"
|
"gitea.futuresens.co.uk/futuresens/cmstypes"
|
||||||
@@ -29,16 +28,9 @@ type SalePaymentRequest struct {
|
|||||||
Currency string `json:"currency,omitempty"`
|
Currency string `json:"currency,omitempty"`
|
||||||
}
|
}
|
||||||
|
|
||||||
type paymentStreamMessage struct {
|
|
||||||
Type string `json:"type"`
|
|
||||||
Code string `json:"code,omitempty"`
|
|
||||||
Response *cmstypes.ResponseRec `json:"response,omitempty"`
|
|
||||||
}
|
|
||||||
|
|
||||||
func (app *App) salePayment(w http.ResponseWriter, r *http.Request) {
|
func (app *App) salePayment(w http.ResponseWriter, r *http.Request) {
|
||||||
const op = logging.Op("salePayment")
|
const op = logging.Op("salePayment")
|
||||||
|
var response = cmstypes.ResponseRec{
|
||||||
response := cmstypes.ResponseRec{
|
|
||||||
Status: cmstypes.StatusRec{
|
Status: cmstypes.StatusRec{
|
||||||
Code: http.StatusInternalServerError,
|
Code: http.StatusInternalServerError,
|
||||||
Message: http.StatusText(http.StatusInternalServerError),
|
Message: http.StatusText(http.StatusInternalServerError),
|
||||||
@@ -57,40 +49,22 @@ func (app *App) salePayment(w http.ResponseWriter, r *http.Request) {
|
|||||||
writeTransactionResult(w, http.StatusMethodNotAllowed, response)
|
writeTransactionResult(w, http.StatusMethodNotAllowed, response)
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
if app.paymentService == nil {
|
if app.paymentService == nil {
|
||||||
mail.SendEmailOnError(
|
mail.SendEmailOnError(app.cfg.Hotel, app.cfg.Kiosk, "Payment Service Not Configured", "Payment service is not configured; cannot process payment requests")
|
||||||
app.cfg.Hotel,
|
|
||||||
app.cfg.Kiosk,
|
|
||||||
"Payment Service Not Configured",
|
|
||||||
"Payment service is not configured; cannot process payment requests",
|
|
||||||
)
|
|
||||||
|
|
||||||
response.Data = buildPaymentFailureURL(types.ResultError, "Payment service is not configured")
|
response.Data = buildPaymentFailureURL(types.ResultError, "Payment service is not configured")
|
||||||
writeTransactionResult(w, http.StatusInternalServerError, response)
|
writeTransactionResult(w, http.StatusInternalServerError, response)
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
if ct := r.Header.Get("Content-Type"); ct != "" && !strings.Contains(ct, "application/json") {
|
if ct := r.Header.Get("Content-Type"); ct != "" && !strings.Contains(ct, "application/json") {
|
||||||
response.Data = buildPaymentFailureURL(types.ResultError, "Content-Type must be application/json")
|
response.Data = buildPaymentFailureURL(types.ResultError, "Content-Type must be application/json")
|
||||||
writeTransactionResult(w, http.StatusUnsupportedMediaType, response)
|
writeTransactionResult(w, http.StatusUnsupportedMediaType, response)
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
defer r.Body.Close()
|
defer r.Body.Close()
|
||||||
|
|
||||||
var req SalePaymentRequest
|
var req SalePaymentRequest
|
||||||
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
|
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
|
||||||
logging.Error(
|
logging.Error(types.ServiceName, err.Error(), "ReadJSON", string(op), "", app.cfg.Hotel, app.cfg.Kiosk)
|
||||||
types.ServiceName,
|
|
||||||
err.Error(),
|
|
||||||
"ReadJSON",
|
|
||||||
string(op),
|
|
||||||
"",
|
|
||||||
app.cfg.Hotel,
|
|
||||||
app.cfg.Kiosk,
|
|
||||||
)
|
|
||||||
|
|
||||||
response.Data = buildPaymentFailureURL(types.ResultError, "invalid JSON payload: "+err.Error())
|
response.Data = buildPaymentFailureURL(types.ResultError, "invalid JSON payload: "+err.Error())
|
||||||
writeTransactionResult(w, http.StatusBadRequest, response)
|
writeTransactionResult(w, http.StatusBadRequest, response)
|
||||||
return
|
return
|
||||||
@@ -101,90 +75,31 @@ func (app *App) salePayment(w http.ResponseWriter, r *http.Request) {
|
|||||||
writeTransactionResult(w, http.StatusBadRequest, response)
|
writeTransactionResult(w, http.StatusBadRequest, response)
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
if req.Currency == "" {
|
if req.Currency == "" {
|
||||||
req.Currency = "GBP"
|
req.Currency = "GBP"
|
||||||
}
|
}
|
||||||
|
|
||||||
if req.Reference == "" {
|
if req.Reference == "" {
|
||||||
req.Reference = req.ConfirmNo
|
req.Reference = req.ConfirmNo
|
||||||
}
|
}
|
||||||
|
|
||||||
if req.Reference == "" {
|
if req.Reference == "" {
|
||||||
req.Reference = uuid.NewString()
|
req.Reference = uuid.NewString()
|
||||||
}
|
}
|
||||||
|
|
||||||
requestID := buildPaymentRequestID(req.Reference)
|
requestID := buildPaymentRequestID(req.Reference)
|
||||||
|
|
||||||
timeoutSeconds := app.cfg.TimeoutSeconds
|
timeoutSeconds := app.cfg.TimeoutSeconds
|
||||||
if timeoutSeconds <= 0 {
|
if timeoutSeconds <= 0 {
|
||||||
timeoutSeconds = 300
|
timeoutSeconds = 300
|
||||||
}
|
}
|
||||||
|
|
||||||
ctx, cancel := context.WithTimeout(
|
ctx, cancel := context.WithTimeout(r.Context(), time.Duration(timeoutSeconds)*time.Second)
|
||||||
r.Context(),
|
|
||||||
time.Duration(timeoutSeconds)*time.Second,
|
|
||||||
)
|
|
||||||
defer cancel()
|
defer cancel()
|
||||||
|
|
||||||
flusher, ok := w.(http.Flusher)
|
result, err := app.paymentService.Sale(ctx, paymentsvc.SaleRequest{
|
||||||
if !ok {
|
RequestID: requestID,
|
||||||
response.Data = buildPaymentFailureURL(
|
Reference: req.Reference,
|
||||||
types.ResultError,
|
Amount: req.Amount,
|
||||||
"Streaming payment updates are not supported",
|
Currency: req.Currency,
|
||||||
)
|
})
|
||||||
writeTransactionResult(w, http.StatusInternalServerError, response)
|
|
||||||
return
|
|
||||||
}
|
|
||||||
|
|
||||||
w.Header().Set("Content-Type", "application/x-ndjson; charset=utf-8")
|
|
||||||
w.Header().Set("Cache-Control", "no-cache")
|
|
||||||
w.Header().Set("X-Content-Type-Options", "nosniff")
|
|
||||||
|
|
||||||
encoder := json.NewEncoder(w)
|
|
||||||
|
|
||||||
var streamMu sync.Mutex
|
|
||||||
streamStarted := false
|
|
||||||
streamFailed := false
|
|
||||||
|
|
||||||
sendStreamMessage := func(message paymentStreamMessage) {
|
|
||||||
streamMu.Lock()
|
|
||||||
defer streamMu.Unlock()
|
|
||||||
|
|
||||||
if streamFailed {
|
|
||||||
return
|
|
||||||
}
|
|
||||||
|
|
||||||
if err := encoder.Encode(message); err != nil {
|
|
||||||
streamFailed = true
|
|
||||||
return
|
|
||||||
}
|
|
||||||
|
|
||||||
streamStarted = true
|
|
||||||
flusher.Flush()
|
|
||||||
}
|
|
||||||
|
|
||||||
onStatus := func(update paymentsvc.StatusUpdate) {
|
|
||||||
if update.Code == "" {
|
|
||||||
return
|
|
||||||
}
|
|
||||||
|
|
||||||
sendStreamMessage(paymentStreamMessage{
|
|
||||||
Type: "status",
|
|
||||||
Code: update.Code,
|
|
||||||
})
|
|
||||||
}
|
|
||||||
|
|
||||||
result, err := app.paymentService.Sale(
|
|
||||||
ctx,
|
|
||||||
paymentsvc.SaleRequest{
|
|
||||||
RequestID: requestID,
|
|
||||||
Reference: req.Reference,
|
|
||||||
Amount: req.Amount,
|
|
||||||
Currency: req.Currency,
|
|
||||||
},
|
|
||||||
onStatus,
|
|
||||||
)
|
|
||||||
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
status := http.StatusBadGateway
|
status := http.StatusBadGateway
|
||||||
@@ -192,51 +107,20 @@ func (app *App) salePayment(w http.ResponseWriter, r *http.Request) {
|
|||||||
status = http.StatusConflict
|
status = http.StatusConflict
|
||||||
}
|
}
|
||||||
|
|
||||||
logging.Error(
|
logging.Error(types.ServiceName, err.Error(), "Payment provider error", string(op), req.Reference, app.cfg.Hotel, app.cfg.Kiosk)
|
||||||
types.ServiceName,
|
|
||||||
err.Error(),
|
|
||||||
"Payment provider error",
|
|
||||||
string(op),
|
|
||||||
req.Reference,
|
|
||||||
app.cfg.Hotel,
|
|
||||||
app.cfg.Kiosk,
|
|
||||||
)
|
|
||||||
|
|
||||||
response.Status.Code = status
|
response.Status.Code = status
|
||||||
response.Status.Message = http.StatusText(status)
|
response.Status.Message = http.StatusText(status)
|
||||||
response.Data = buildPaymentFailureURL(types.ResultError, err.Error())
|
response.Data = buildPaymentFailureURL(types.ResultError, err.Error())
|
||||||
|
writeTransactionResult(w, status, response)
|
||||||
if !streamStarted {
|
|
||||||
w.Header().Set("Content-Type", "application/json; charset=utf-8")
|
|
||||||
writeTransactionResult(w, status, response)
|
|
||||||
return
|
|
||||||
}
|
|
||||||
|
|
||||||
sendStreamMessage(paymentStreamMessage{
|
|
||||||
Type: "result",
|
|
||||||
Response: &response,
|
|
||||||
})
|
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
if result == nil {
|
if result == nil {
|
||||||
response.Status.Code = http.StatusBadGateway
|
response.Status.Code = http.StatusBadGateway
|
||||||
response.Status.Message = "Empty payment result"
|
response.Status.Message = "Empty payment result"
|
||||||
response.Data = buildPaymentFailureURL(
|
response.Data = buildPaymentFailureURL(types.ResultError, "Payment provider returned an empty result")
|
||||||
types.ResultError,
|
writeTransactionResult(w, http.StatusBadGateway, response)
|
||||||
"Payment provider returned an empty result",
|
|
||||||
)
|
|
||||||
|
|
||||||
if !streamStarted {
|
|
||||||
w.Header().Set("Content-Type", "application/json; charset=utf-8")
|
|
||||||
writeTransactionResult(w, http.StatusBadGateway, response)
|
|
||||||
return
|
|
||||||
}
|
|
||||||
|
|
||||||
sendStreamMessage(paymentStreamMessage{
|
|
||||||
Type: "result",
|
|
||||||
Response: &response,
|
|
||||||
})
|
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -244,14 +128,10 @@ func (app *App) salePayment(w http.ResponseWriter, r *http.Request) {
|
|||||||
|
|
||||||
if result.Success && strings.EqualFold(result.Status, "APPROVED") {
|
if result.Success && strings.EqualFold(result.Status, "APPROVED") {
|
||||||
printer.PrintSaleReceipt(result.CustomerReceipt)
|
printer.PrintSaleReceipt(result.CustomerReceipt)
|
||||||
|
response.Status.Code = http.StatusOK
|
||||||
response.Status.Message = result.Message
|
response.Status.Message = result.Message
|
||||||
response.Data = buildPaymentSuccessURL(result)
|
response.Data = buildPaymentSuccessURL(result)
|
||||||
|
writeTransactionResult(w, http.StatusOK, response)
|
||||||
sendStreamMessage(paymentStreamMessage{
|
|
||||||
Type: "result",
|
|
||||||
Response: &response,
|
|
||||||
})
|
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -265,14 +145,9 @@ func (app *App) salePayment(w http.ResponseWriter, r *http.Request) {
|
|||||||
|
|
||||||
log.Printf("Transaction failed: %s", description)
|
log.Printf("Transaction failed: %s", description)
|
||||||
printer.PrintSaleReceipt(result.CustomerReceipt)
|
printer.PrintSaleReceipt(result.CustomerReceipt)
|
||||||
|
|
||||||
response.Status.Message = "Payment unsuccessful"
|
response.Status.Message = "Payment unsuccessful"
|
||||||
response.Data = buildPaymentFailureURL(types.ResultError, description)
|
response.Data = buildPaymentFailureURL(types.ResultError, description)
|
||||||
|
writeTransactionResult(w, http.StatusOK, response)
|
||||||
sendStreamMessage(paymentStreamMessage{
|
|
||||||
Type: "result",
|
|
||||||
Response: &response,
|
|
||||||
})
|
|
||||||
}
|
}
|
||||||
|
|
||||||
func buildPaymentRequestID(reference string) string {
|
func buildPaymentRequestID(reference string) string {
|
||||||
@@ -298,16 +173,16 @@ func setPaymentCORS(w http.ResponseWriter) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func buildPaymentSuccessURL(result *paymentsvc.Result) string {
|
func buildPaymentSuccessURL(result *paymentsvc.Result) string {
|
||||||
// txnReference := result.ReferenceNumber
|
txnReference := result.ReferenceNumber
|
||||||
// if txnReference == "" {
|
if txnReference == "" {
|
||||||
// txnReference = result.TransactionID
|
txnReference = result.TransactionID
|
||||||
// }
|
}
|
||||||
|
|
||||||
q := url.Values{}
|
q := url.Values{}
|
||||||
q.Set("CardNumber", hex.EncodeToString([]byte(result.CardNumber)))
|
q.Set("CardNumber", hex.EncodeToString([]byte(result.CardNumber)))
|
||||||
q.Set("CardType", hex.EncodeToString([]byte(result.CardType)))
|
q.Set("CardType", hex.EncodeToString([]byte(result.CardType)))
|
||||||
q.Set("ExpiryDate", hex.EncodeToString([]byte(result.ExpiryDate)))
|
q.Set("ExpiryDate", hex.EncodeToString([]byte(result.ExpiryDate)))
|
||||||
q.Set("TxnReference", result.RequestID)
|
q.Set("TxnReference", txnReference)
|
||||||
q.Set("CardHash", hex.EncodeToString([]byte(result.CardHash)))
|
q.Set("CardHash", hex.EncodeToString([]byte(result.CardHash)))
|
||||||
q.Set("CardReference", hex.EncodeToString([]byte(result.CardReference)))
|
q.Set("CardReference", hex.EncodeToString([]byte(result.CardReference)))
|
||||||
|
|
||||||
|
|||||||
@@ -1,162 +0,0 @@
|
|||||||
package handlers
|
|
||||||
|
|
||||||
import (
|
|
||||||
"context"
|
|
||||||
"encoding/json"
|
|
||||||
"errors"
|
|
||||||
"io"
|
|
||||||
"net/http"
|
|
||||||
"net/http/httptest"
|
|
||||||
"net/url"
|
|
||||||
"strings"
|
|
||||||
"testing"
|
|
||||||
|
|
||||||
"gitea.futuresens.co.uk/futuresens/hardlink/config"
|
|
||||||
"gitea.futuresens.co.uk/futuresens/hardlink/internal/paymentsvc"
|
|
||||||
"gitea.futuresens.co.uk/futuresens/hardlink/internal/types"
|
|
||||||
"gitea.futuresens.co.uk/futuresens/hardlink/paymentstatus"
|
|
||||||
)
|
|
||||||
|
|
||||||
type paymentProviderFunc func(
|
|
||||||
context.Context,
|
|
||||||
paymentsvc.SaleRequest,
|
|
||||||
paymentsvc.StatusHandler,
|
|
||||||
) (*paymentsvc.Result, error)
|
|
||||||
|
|
||||||
func (f paymentProviderFunc) Sale(
|
|
||||||
ctx context.Context,
|
|
||||||
request paymentsvc.SaleRequest,
|
|
||||||
onStatus paymentsvc.StatusHandler,
|
|
||||||
) (*paymentsvc.Result, error) {
|
|
||||||
return f(ctx, request, onStatus)
|
|
||||||
}
|
|
||||||
|
|
||||||
func TestSalePaymentStreamsTerminalUnavailableAsAuthoritativeUnsuccessfulResult(t *testing.T) {
|
|
||||||
provider := paymentProviderFunc(func(
|
|
||||||
_ context.Context,
|
|
||||||
request paymentsvc.SaleRequest,
|
|
||||||
onStatus paymentsvc.StatusHandler,
|
|
||||||
) (*paymentsvc.Result, error) {
|
|
||||||
onStatus(paymentsvc.StatusUpdate{Code: paymentstatus.Starting})
|
|
||||||
onStatus(paymentsvc.StatusUpdate{Code: paymentstatus.TerminalUnavailable})
|
|
||||||
return &paymentsvc.Result{
|
|
||||||
RequestID: request.RequestID,
|
|
||||||
Operation: "SALE",
|
|
||||||
Status: "TERMINAL_UNAVAILABLE",
|
|
||||||
ErrorMessage: "Payment terminal is unavailable",
|
|
||||||
Amount: request.Amount,
|
|
||||||
Currency: request.Currency,
|
|
||||||
DeviceUsed: "terminal-1",
|
|
||||||
DeviceType: "Dojo Terminal",
|
|
||||||
}, nil
|
|
||||||
})
|
|
||||||
|
|
||||||
recorder := performSalePaymentRequest(t, provider)
|
|
||||||
if recorder.Code != http.StatusOK {
|
|
||||||
t.Fatalf("outer status = %d, want %d", recorder.Code, http.StatusOK)
|
|
||||||
}
|
|
||||||
messages := decodePaymentStream(t, recorder.Body)
|
|
||||||
if len(messages) != 3 {
|
|
||||||
t.Fatalf("stream messages = %#v, want two statuses and one result", messages)
|
|
||||||
}
|
|
||||||
if messages[0].Type != "status" || messages[0].Code != paymentstatus.Starting ||
|
|
||||||
messages[1].Type != "status" || messages[1].Code != paymentstatus.TerminalUnavailable {
|
|
||||||
t.Fatalf("status frames = %#v", messages[:2])
|
|
||||||
}
|
|
||||||
final := messages[2]
|
|
||||||
if final.Type != "result" || final.Response == nil {
|
|
||||||
t.Fatalf("final frame = %#v", final)
|
|
||||||
}
|
|
||||||
if final.Response.Status.Code != http.StatusOK {
|
|
||||||
t.Fatalf("nested status = %d, want %d", final.Response.Status.Code, http.StatusOK)
|
|
||||||
}
|
|
||||||
resultURL, err := url.Parse(final.Response.Data)
|
|
||||||
if err != nil {
|
|
||||||
t.Fatal(err)
|
|
||||||
}
|
|
||||||
if resultURL.Path != types.CheckinUnsuccessfulEndpoint {
|
|
||||||
t.Fatalf("result path = %q, want %q", resultURL.Path, types.CheckinUnsuccessfulEndpoint)
|
|
||||||
}
|
|
||||||
if got := resultURL.Query().Get("Description"); got != "Payment terminal is unavailable" {
|
|
||||||
t.Fatalf("Description = %q", got)
|
|
||||||
}
|
|
||||||
|
|
||||||
body := recorder.Body.String()
|
|
||||||
for _, forbidden := range []string{
|
|
||||||
"Dojo returned HTTP 409",
|
|
||||||
"offline or currently in use",
|
|
||||||
"traceId",
|
|
||||||
"docs.dojo.tech",
|
|
||||||
} {
|
|
||||||
if strings.Contains(body, forbidden) {
|
|
||||||
t.Fatalf("stream exposed %q: %s", forbidden, body)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
func TestSalePaymentRetainsNestedBadGatewayForProviderErrorsAfterStreamingStarts(t *testing.T) {
|
|
||||||
provider := paymentProviderFunc(func(
|
|
||||||
_ context.Context,
|
|
||||||
_ paymentsvc.SaleRequest,
|
|
||||||
onStatus paymentsvc.StatusHandler,
|
|
||||||
) (*paymentsvc.Result, error) {
|
|
||||||
onStatus(paymentsvc.StatusUpdate{Code: paymentstatus.Starting})
|
|
||||||
return nil, errors.New("provider failed")
|
|
||||||
})
|
|
||||||
|
|
||||||
recorder := performSalePaymentRequest(t, provider)
|
|
||||||
if recorder.Code != http.StatusOK {
|
|
||||||
t.Fatalf("outer status = %d, want streaming status %d", recorder.Code, http.StatusOK)
|
|
||||||
}
|
|
||||||
messages := decodePaymentStream(t, recorder.Body)
|
|
||||||
if len(messages) != 2 || messages[1].Type != "result" || messages[1].Response == nil {
|
|
||||||
t.Fatalf("stream messages = %#v", messages)
|
|
||||||
}
|
|
||||||
if messages[1].Response.Status.Code != http.StatusBadGateway {
|
|
||||||
t.Fatalf("nested status = %d, want %d", messages[1].Response.Status.Code, http.StatusBadGateway)
|
|
||||||
}
|
|
||||||
resultURL, err := url.Parse(messages[1].Response.Data)
|
|
||||||
if err != nil {
|
|
||||||
t.Fatal(err)
|
|
||||||
}
|
|
||||||
if resultURL.Path != types.CheckinUnsuccessfulEndpoint {
|
|
||||||
t.Fatalf("result path = %q, want %q", resultURL.Path, types.CheckinUnsuccessfulEndpoint)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
func performSalePaymentRequest(t *testing.T, provider paymentsvc.Provider) *httptest.ResponseRecorder {
|
|
||||||
t.Helper()
|
|
||||||
app := &App{
|
|
||||||
paymentService: paymentsvc.NewService(provider),
|
|
||||||
cfg: &config.ConfigRec{
|
|
||||||
Hotel: "HOTEL",
|
|
||||||
Kiosk: 7,
|
|
||||||
TimeoutSeconds: 5,
|
|
||||||
},
|
|
||||||
}
|
|
||||||
request := httptest.NewRequest(
|
|
||||||
http.MethodPost,
|
|
||||||
"/api/payment/sale",
|
|
||||||
strings.NewReader(`{"reference":"BOOKING-123","amount":10852,"currency":"GBP"}`),
|
|
||||||
)
|
|
||||||
request.Header.Set("Content-Type", "application/json")
|
|
||||||
recorder := httptest.NewRecorder()
|
|
||||||
app.salePayment(recorder, request)
|
|
||||||
return recorder
|
|
||||||
}
|
|
||||||
|
|
||||||
func decodePaymentStream(t *testing.T, body io.Reader) []paymentStreamMessage {
|
|
||||||
t.Helper()
|
|
||||||
decoder := json.NewDecoder(body)
|
|
||||||
var messages []paymentStreamMessage
|
|
||||||
for {
|
|
||||||
var message paymentStreamMessage
|
|
||||||
if err := decoder.Decode(&message); err != nil {
|
|
||||||
if errors.Is(err, io.EOF) {
|
|
||||||
return messages
|
|
||||||
}
|
|
||||||
t.Fatal(err)
|
|
||||||
}
|
|
||||||
messages = append(messages, message)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
+21
-288
@@ -10,9 +10,7 @@ import (
|
|||||||
|
|
||||||
"gitea.futuresens.co.uk/futuresens/hardlink/internal/paymentsvc"
|
"gitea.futuresens.co.uk/futuresens/hardlink/internal/paymentsvc"
|
||||||
"gitea.futuresens.co.uk/futuresens/hardlink/internal/types"
|
"gitea.futuresens.co.uk/futuresens/hardlink/internal/types"
|
||||||
"gitea.futuresens.co.uk/futuresens/hardlink/paymentstatus"
|
|
||||||
"github.com/gorilla/websocket"
|
"github.com/gorilla/websocket"
|
||||||
log "github.com/sirupsen/logrus"
|
|
||||||
)
|
)
|
||||||
|
|
||||||
type Client struct {
|
type Client struct {
|
||||||
@@ -33,7 +31,7 @@ func NewClient(url, apiKey string, timeoutSeconds int) *Client {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func (c *Client) Sale(ctx context.Context, req paymentsvc.SaleRequest, onStatus paymentsvc.StatusHandler) (*paymentsvc.Result, error) {
|
func (c *Client) Sale(ctx context.Context, req paymentsvc.SaleRequest) (*paymentsvc.Result, error) {
|
||||||
if req.Currency == "" {
|
if req.Currency == "" {
|
||||||
req.Currency = "GBP"
|
req.Currency = "GBP"
|
||||||
}
|
}
|
||||||
@@ -46,12 +44,10 @@ func (c *Client) Sale(ctx context.Context, req paymentsvc.SaleRequest, onStatus
|
|||||||
TimeoutSeconds: c.TimeoutSeconds,
|
TimeoutSeconds: c.TimeoutSeconds,
|
||||||
}
|
}
|
||||||
|
|
||||||
return c.doPayment(ctx, payBridgeReq, onStatus)
|
return c.doPayment(ctx, payBridgeReq)
|
||||||
}
|
}
|
||||||
|
|
||||||
func (c *Client) doPayment(ctx context.Context, req PaymentRequest, onStatus paymentsvc.StatusHandler) (*paymentsvc.Result, error) {
|
func (c *Client) doPayment(ctx context.Context, req PaymentRequest) (*paymentsvc.Result, error) {
|
||||||
emitStatus(onStatus, paymentstatus.Starting)
|
|
||||||
|
|
||||||
connectURL, err := c.connectURL()
|
connectURL, err := c.connectURL()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
@@ -79,9 +75,6 @@ func (c *Client) doPayment(ctx context.Context, req PaymentRequest, onStatus pay
|
|||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
|
|
||||||
log.Info("PayBridge authentication successful")
|
|
||||||
emitStatus(onStatus, paymentstatus.Started)
|
|
||||||
|
|
||||||
if err := ws.WriteJSON(Envelope{
|
if err := ws.WriteJSON(Envelope{
|
||||||
Type: types.MesTypePaymentRequest,
|
Type: types.MesTypePaymentRequest,
|
||||||
JWT: jwt,
|
JWT: jwt,
|
||||||
@@ -91,109 +84,36 @@ func (c *Client) doPayment(ctx context.Context, req PaymentRequest, onStatus pay
|
|||||||
return nil, fmt.Errorf("send PayBridge payment_request: %w", err)
|
return nil, fmt.Errorf("send PayBridge payment_request: %w", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
log.WithFields(log.Fields{
|
|
||||||
"requestId": req.RequestID,
|
|
||||||
"operation": req.Operation,
|
|
||||||
"amount": req.Amount,
|
|
||||||
"currency": req.Currency,
|
|
||||||
}).Info("PayBridge payment request sent")
|
|
||||||
|
|
||||||
emitStatus(onStatus, paymentstatus.RequestSent)
|
|
||||||
|
|
||||||
for {
|
for {
|
||||||
_, raw, err := ws.ReadMessage()
|
_, raw, err := ws.ReadMessage()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
if ctx.Err() != nil {
|
if ctx.Err() != nil {
|
||||||
return nil, ctx.Err()
|
return nil, ctx.Err()
|
||||||
}
|
}
|
||||||
|
|
||||||
return nil, fmt.Errorf("read PayBridge message: %w", err)
|
return nil, fmt.Errorf("read PayBridge message: %w", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
var head struct {
|
var head struct {
|
||||||
Type string `json:"type"`
|
Type string `json:"type"`
|
||||||
}
|
}
|
||||||
|
|
||||||
if err := json.Unmarshal(raw, &head); err != nil {
|
if err := json.Unmarshal(raw, &head); err != nil {
|
||||||
return nil, fmt.Errorf("decode PayBridge message header: %w", err)
|
return nil, fmt.Errorf("decode PayBridge message header: %w", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
messageType := strings.ToLower(head.Type)
|
switch strings.ToLower(head.Type) {
|
||||||
|
|
||||||
switch messageType {
|
|
||||||
case types.MesTypePaymentStatusUpdate:
|
|
||||||
var update StatusUpdateEnvelope
|
|
||||||
if err := json.Unmarshal(raw, &update); err != nil {
|
|
||||||
return nil, fmt.Errorf("decode payment_status_update: %w", err)
|
|
||||||
}
|
|
||||||
|
|
||||||
log.WithFields(log.Fields{
|
|
||||||
"status": update.Data.Status,
|
|
||||||
"code": update.Data.Code,
|
|
||||||
}).Info("PayBridge status update")
|
|
||||||
|
|
||||||
statusCode, known := mapPayBridgeStatus(
|
|
||||||
update.Data.Status,
|
|
||||||
update.Data.Code,
|
|
||||||
)
|
|
||||||
|
|
||||||
if !known {
|
|
||||||
log.WithFields(log.Fields{
|
|
||||||
"status": update.Data.Status,
|
|
||||||
"code": update.Data.Code,
|
|
||||||
}).Warn("Unknown PayBridge status update")
|
|
||||||
}
|
|
||||||
|
|
||||||
emitStatus(onStatus, statusCode)
|
|
||||||
|
|
||||||
case types.MesTypePaymentAccepted:
|
|
||||||
log.Info("PayBridge payment request accepted")
|
|
||||||
emitStatus(onStatus, paymentstatus.Accepted)
|
|
||||||
|
|
||||||
case types.MesTypePaymentResult:
|
case types.MesTypePaymentResult:
|
||||||
var result PaymentResultEnvelope
|
var result PaymentResultEnvelope
|
||||||
// log.Println("PayBridge payment result raw:", string(raw))
|
|
||||||
if err := json.Unmarshal(raw, &result); err != nil {
|
if err := json.Unmarshal(raw, &result); err != nil {
|
||||||
return nil, fmt.Errorf("decode payment_result: %w", err)
|
return nil, fmt.Errorf("decode payment_result: %w", err)
|
||||||
}
|
}
|
||||||
|
return mapPaymentResult(result), nil
|
||||||
mapped := mapPaymentResult(result)
|
|
||||||
|
|
||||||
log.WithFields(log.Fields{
|
|
||||||
"requestId": mapped.RequestID,
|
|
||||||
"transactionId": mapped.TransactionID,
|
|
||||||
"status": mapped.Status,
|
|
||||||
"success": mapped.Success,
|
|
||||||
}).Info("PayBridge payment result received")
|
|
||||||
|
|
||||||
emitStatus(
|
|
||||||
onStatus,
|
|
||||||
mapPayBridgeFinalStatus(mapped.Status, mapped.Success),
|
|
||||||
)
|
|
||||||
|
|
||||||
return mapped, nil
|
|
||||||
|
|
||||||
case types.MesTypePaymentError:
|
case types.MesTypePaymentError:
|
||||||
var paymentErr PaymentErrorEnvelope
|
var paymentErr PaymentErrorEnvelope
|
||||||
if err := json.Unmarshal(raw, &paymentErr); err != nil {
|
if err := json.Unmarshal(raw, &paymentErr); err != nil {
|
||||||
return nil, fmt.Errorf("decode payment_error: %w", err)
|
return nil, fmt.Errorf("decode payment_error: %w", err)
|
||||||
}
|
}
|
||||||
|
return mapPaymentError(req, paymentErr), nil
|
||||||
mapped := mapPaymentError(req, paymentErr)
|
|
||||||
|
|
||||||
log.WithFields(log.Fields{
|
|
||||||
"requestId": mapped.RequestID,
|
|
||||||
"transactionId": mapped.TransactionID,
|
|
||||||
"status": mapped.Status,
|
|
||||||
"error": mapped.ErrorMessage,
|
|
||||||
}).Warn("PayBridge payment error received")
|
|
||||||
|
|
||||||
emitStatus(
|
|
||||||
onStatus,
|
|
||||||
mapPayBridgeFinalStatus(mapped.Status, false),
|
|
||||||
)
|
|
||||||
|
|
||||||
return mapped, nil
|
|
||||||
|
|
||||||
case types.ResultError:
|
case types.ResultError:
|
||||||
var genericErr struct {
|
var genericErr struct {
|
||||||
@@ -202,47 +122,20 @@ func (c *Client) doPayment(ctx context.Context, req PaymentRequest, onStatus pay
|
|||||||
Message string `json:"message"`
|
Message string `json:"message"`
|
||||||
} `json:"error"`
|
} `json:"error"`
|
||||||
}
|
}
|
||||||
|
|
||||||
if err := json.Unmarshal(raw, &genericErr); err != nil {
|
if err := json.Unmarshal(raw, &genericErr); err != nil {
|
||||||
return nil, fmt.Errorf(
|
return nil, fmt.Errorf("%w: %s", ErrUnexpectedMessage, string(raw))
|
||||||
"%w: %s",
|
|
||||||
ErrUnexpectedMessage,
|
|
||||||
string(raw),
|
|
||||||
)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
log.WithFields(log.Fields{
|
|
||||||
"code": genericErr.Error.Code,
|
|
||||||
"message": genericErr.Error.Message,
|
|
||||||
}).Error("PayBridge error message received")
|
|
||||||
|
|
||||||
emitStatus(onStatus, paymentstatus.Error)
|
|
||||||
|
|
||||||
if genericErr.Error.Message != "" {
|
if genericErr.Error.Message != "" {
|
||||||
return nil, fmt.Errorf(
|
return nil, fmt.Errorf("%w: %s: %s", ErrUnexpectedMessage, genericErr.Error.Code, genericErr.Error.Message)
|
||||||
"%w: %s: %s",
|
|
||||||
ErrUnexpectedMessage,
|
|
||||||
genericErr.Error.Code,
|
|
||||||
genericErr.Error.Message,
|
|
||||||
)
|
|
||||||
}
|
}
|
||||||
|
return nil, fmt.Errorf("%w: %s", ErrUnexpectedMessage, string(raw))
|
||||||
|
|
||||||
return nil, fmt.Errorf(
|
case types.MesTypePaymentStatusUpdate, types.MesTypePaymentAccepted, types.MesTypeAuthSuccess:
|
||||||
"%w: %s",
|
// Intermediate message. Keep waiting for payment_result or payment_error.
|
||||||
ErrUnexpectedMessage,
|
|
||||||
string(raw),
|
|
||||||
)
|
|
||||||
|
|
||||||
case types.MesTypeAuthSuccess:
|
|
||||||
log.Info("Additional PayBridge auth_success message received")
|
|
||||||
|
|
||||||
default:
|
default:
|
||||||
log.WithField(
|
// PayBridge may introduce additional intermediate message types.
|
||||||
"messageType",
|
// Ignore them and continue waiting for the final result.
|
||||||
head.Type,
|
|
||||||
).Warn("Unknown PayBridge intermediate message type")
|
|
||||||
|
|
||||||
emitStatus(onStatus, paymentstatus.Processing)
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -250,10 +143,7 @@ func (c *Client) doPayment(ctx context.Context, req PaymentRequest, onStatus pay
|
|||||||
func (c *Client) connectURL() (string, error) {
|
func (c *Client) connectURL() (string, error) {
|
||||||
u, err := url.Parse(c.URL)
|
u, err := url.Parse(c.URL)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return "", fmt.Errorf(
|
return "", fmt.Errorf("parse PayBridge WebSocket URL: %w", err)
|
||||||
"parse PayBridge WebSocket URL: %w",
|
|
||||||
err,
|
|
||||||
)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
q := u.Query()
|
q := u.Query()
|
||||||
@@ -264,186 +154,29 @@ func (c *Client) connectURL() (string, error) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func (c *Client) readAuthSuccess(ws *websocket.Conn) (string, error) {
|
func (c *Client) readAuthSuccess(ws *websocket.Conn) (string, error) {
|
||||||
if err := ws.SetReadDeadline(
|
if err := ws.SetReadDeadline(time.Now().Add(10 * time.Second)); err != nil {
|
||||||
time.Now().Add(10 * time.Second),
|
return "", fmt.Errorf("%w: set auth read deadline: %v", ErrAuthFailed, err)
|
||||||
); err != nil {
|
|
||||||
return "", fmt.Errorf(
|
|
||||||
"%w: set auth read deadline: %v",
|
|
||||||
ErrAuthFailed,
|
|
||||||
err,
|
|
||||||
)
|
|
||||||
}
|
}
|
||||||
defer ws.SetReadDeadline(time.Time{})
|
defer ws.SetReadDeadline(time.Time{})
|
||||||
|
|
||||||
_, raw, err := ws.ReadMessage()
|
_, raw, err := ws.ReadMessage()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return "", fmt.Errorf(
|
return "", fmt.Errorf("%w: read auth_success: %v", ErrAuthFailed, err)
|
||||||
"%w: read auth_success: %v",
|
|
||||||
ErrAuthFailed,
|
|
||||||
err,
|
|
||||||
)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
var auth struct {
|
var auth struct {
|
||||||
Type string `json:"type"`
|
Type string `json:"type"`
|
||||||
JWT string `json:"jwt"`
|
JWT string `json:"jwt"`
|
||||||
}
|
}
|
||||||
|
|
||||||
if err := json.Unmarshal(raw, &auth); err != nil {
|
if err := json.Unmarshal(raw, &auth); err != nil {
|
||||||
return "", fmt.Errorf(
|
return "", fmt.Errorf("%w: decode auth_success: %v", ErrAuthFailed, err)
|
||||||
"%w: decode auth_success: %v",
|
|
||||||
ErrAuthFailed,
|
|
||||||
err,
|
|
||||||
)
|
|
||||||
}
|
}
|
||||||
|
if !strings.EqualFold(auth.Type, types.MesTypeAuthSuccess) {
|
||||||
if !strings.EqualFold(
|
return "", fmt.Errorf("%w: expected auth_success, got %s: %s", ErrAuthFailed, auth.Type, string(raw))
|
||||||
auth.Type,
|
|
||||||
types.MesTypeAuthSuccess,
|
|
||||||
) {
|
|
||||||
return "", fmt.Errorf(
|
|
||||||
"%w: expected auth_success, got %s: %s",
|
|
||||||
ErrAuthFailed,
|
|
||||||
auth.Type,
|
|
||||||
string(raw),
|
|
||||||
)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
if auth.JWT == "" {
|
if auth.JWT == "" {
|
||||||
return "", fmt.Errorf(
|
return "", fmt.Errorf("%w: auth_success did not contain jwt", ErrAuthFailed)
|
||||||
"%w: auth_success did not contain jwt",
|
|
||||||
ErrAuthFailed,
|
|
||||||
)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
return auth.JWT, nil
|
return auth.JWT, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
func emitStatus(
|
|
||||||
onStatus paymentsvc.StatusHandler,
|
|
||||||
code string,
|
|
||||||
) {
|
|
||||||
if onStatus == nil || code == "" {
|
|
||||||
return
|
|
||||||
}
|
|
||||||
|
|
||||||
onStatus(paymentsvc.StatusUpdate{
|
|
||||||
Code: code,
|
|
||||||
})
|
|
||||||
}
|
|
||||||
|
|
||||||
func mapPayBridgeStatus(
|
|
||||||
status string,
|
|
||||||
code string,
|
|
||||||
) (string, bool) {
|
|
||||||
normalizedStatus := strings.ToLower(
|
|
||||||
strings.TrimSpace(status),
|
|
||||||
)
|
|
||||||
|
|
||||||
switch normalizedStatus {
|
|
||||||
case payBridgeMessageInsertOrSwipeCard,
|
|
||||||
payBridgeMessageInsertSwipeOrPresentCard:
|
|
||||||
return paymentstatus.PresentCard, true
|
|
||||||
|
|
||||||
case payBridgeMessageInsertCard:
|
|
||||||
return paymentstatus.InsertCard, true
|
|
||||||
|
|
||||||
case payBridgeMessagePleaseWait:
|
|
||||||
return paymentstatus.PleaseWait, true
|
|
||||||
|
|
||||||
case payBridgeMessageDoNotRemoveCard:
|
|
||||||
return paymentstatus.DoNotRemoveCard, true
|
|
||||||
|
|
||||||
case payBridgeMessageTryAnotherInterface:
|
|
||||||
return paymentstatus.TryAnotherInterface, true
|
|
||||||
|
|
||||||
case payBridgeMessagePIN:
|
|
||||||
return paymentstatus.EnterPIN, true
|
|
||||||
|
|
||||||
case payBridgeMessagePINAgain:
|
|
||||||
return paymentstatus.EnterPINAgain, true
|
|
||||||
|
|
||||||
case payBridgeMessageTransactionCancelled:
|
|
||||||
return paymentstatus.Cancelled, true
|
|
||||||
|
|
||||||
case payBridgeMessageProcessing:
|
|
||||||
return paymentstatus.Processing, true
|
|
||||||
|
|
||||||
case payBridgeMessageApproved:
|
|
||||||
// Это ещё промежуточный статус.
|
|
||||||
// Финальный успех определяется только по payment_result.
|
|
||||||
return paymentstatus.Authorized, true
|
|
||||||
|
|
||||||
case payBridgeMessageDeclined:
|
|
||||||
return paymentstatus.Declined, true
|
|
||||||
}
|
|
||||||
|
|
||||||
// Fallback по фактически обнаруженным кодам терминала.
|
|
||||||
switch strings.TrimSpace(code) {
|
|
||||||
case payBridgeCodeInsertCard:
|
|
||||||
return paymentstatus.InsertCard, true
|
|
||||||
|
|
||||||
case payBridgeCodeEnterPIN:
|
|
||||||
return paymentstatus.EnterPIN, true
|
|
||||||
|
|
||||||
case payBridgeCodeCancelled:
|
|
||||||
return paymentstatus.Cancelled, true
|
|
||||||
|
|
||||||
case payBridgeCodePleaseWait:
|
|
||||||
return paymentstatus.PleaseWait, true
|
|
||||||
|
|
||||||
case payBridgeCodePresentCard, payBridgeCodePresentCardAlternate:
|
|
||||||
return paymentstatus.PresentCard, true
|
|
||||||
|
|
||||||
case payBridgeCodeEnterPINAgain:
|
|
||||||
return paymentstatus.EnterPINAgain, true
|
|
||||||
|
|
||||||
case payBridgeCodeTryAnotherInterface:
|
|
||||||
return paymentstatus.TryAnotherInterface, true
|
|
||||||
|
|
||||||
case payBridgeCodeDoNotRemoveCard:
|
|
||||||
return paymentstatus.DoNotRemoveCard, true
|
|
||||||
}
|
|
||||||
|
|
||||||
// Пока назначение кодов 200, 201, 205 и 210 неизвестно.
|
|
||||||
// Они останутся в логах, но на экране будет общий статус.
|
|
||||||
return paymentstatus.Processing, false
|
|
||||||
}
|
|
||||||
|
|
||||||
func mapPayBridgeFinalStatus(
|
|
||||||
status string,
|
|
||||||
success bool,
|
|
||||||
) string {
|
|
||||||
if success && strings.EqualFold(status, payBridgeFinalStatusApproved) {
|
|
||||||
return paymentstatus.Approved
|
|
||||||
}
|
|
||||||
|
|
||||||
switch strings.ToUpper(status) {
|
|
||||||
case payBridgeFinalStatusDeclined:
|
|
||||||
return paymentstatus.Declined
|
|
||||||
|
|
||||||
case payBridgeFinalStatusCancelled:
|
|
||||||
return paymentstatus.Cancelled
|
|
||||||
|
|
||||||
case payBridgeFinalStatusTimeout:
|
|
||||||
return paymentstatus.Timeout
|
|
||||||
|
|
||||||
case payBridgeFinalStatusVoided:
|
|
||||||
return paymentstatus.Voided
|
|
||||||
|
|
||||||
case payBridgeFinalStatusVoidedDailyLimitExceeded:
|
|
||||||
return paymentstatus.DailyLimitExceeded
|
|
||||||
|
|
||||||
case payBridgeFinalStatusDailyLimitVoidFailed:
|
|
||||||
return paymentstatus.VoidFailed
|
|
||||||
|
|
||||||
case payBridgeFinalStatusDailyLimitValidationError:
|
|
||||||
return paymentstatus.LimitValidationError
|
|
||||||
|
|
||||||
case payBridgeFinalStatusError, payBridgeFinalStatusFailed:
|
|
||||||
return paymentstatus.Error
|
|
||||||
|
|
||||||
default:
|
|
||||||
return paymentstatus.Error
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|||||||
@@ -1,41 +0,0 @@
|
|||||||
package paybridge
|
|
||||||
|
|
||||||
const (
|
|
||||||
payBridgeFinalStatusApproved = "APPROVED"
|
|
||||||
payBridgeFinalStatusDeclined = "DECLINED"
|
|
||||||
payBridgeFinalStatusCancelled = "CANCELLED"
|
|
||||||
payBridgeFinalStatusTimeout = "TIMEOUT"
|
|
||||||
payBridgeFinalStatusVoided = "VOIDED"
|
|
||||||
payBridgeFinalStatusVoidedDailyLimitExceeded = "VOIDED_DAILY_LIMIT_EXCEEDED"
|
|
||||||
payBridgeFinalStatusDailyLimitVoidFailed = "DAILY_LIMIT_EXCEEDED_VOID_FAILED"
|
|
||||||
payBridgeFinalStatusDailyLimitValidationError = "DAILY_LIMIT_VALIDATION_ERROR"
|
|
||||||
payBridgeFinalStatusError = "ERROR"
|
|
||||||
payBridgeFinalStatusFailed = "FAILED"
|
|
||||||
)
|
|
||||||
|
|
||||||
const (
|
|
||||||
payBridgeMessageInsertOrSwipeCard = "insert or swipe card"
|
|
||||||
payBridgeMessageInsertSwipeOrPresentCard = "insert, swipe or present card"
|
|
||||||
payBridgeMessageInsertCard = "insert card"
|
|
||||||
payBridgeMessagePleaseWait = "please wait"
|
|
||||||
payBridgeMessageDoNotRemoveCard = "please wait. do not remove card"
|
|
||||||
payBridgeMessageTryAnotherInterface = "please try another interface"
|
|
||||||
payBridgeMessagePIN = "pin"
|
|
||||||
payBridgeMessagePINAgain = "pin again"
|
|
||||||
payBridgeMessageTransactionCancelled = "transaction cancelled"
|
|
||||||
payBridgeMessageProcessing = "processing"
|
|
||||||
payBridgeMessageApproved = "approved"
|
|
||||||
payBridgeMessageDeclined = "declined"
|
|
||||||
)
|
|
||||||
|
|
||||||
const (
|
|
||||||
payBridgeCodeInsertCard = "101"
|
|
||||||
payBridgeCodeEnterPIN = "106"
|
|
||||||
payBridgeCodeCancelled = "124"
|
|
||||||
payBridgeCodePleaseWait = "1017"
|
|
||||||
payBridgeCodePresentCard = "1109"
|
|
||||||
payBridgeCodePresentCardAlternate = "1113"
|
|
||||||
payBridgeCodeEnterPINAgain = "1129"
|
|
||||||
payBridgeCodeTryAnotherInterface = "1274"
|
|
||||||
payBridgeCodeDoNotRemoveCard = "1312"
|
|
||||||
)
|
|
||||||
@@ -1,125 +0,0 @@
|
|||||||
package paybridge
|
|
||||||
|
|
||||||
import (
|
|
||||||
"testing"
|
|
||||||
|
|
||||||
"gitea.futuresens.co.uk/futuresens/hardlink/paymentstatus"
|
|
||||||
)
|
|
||||||
|
|
||||||
func TestMapPayBridgeFinalStatus(t *testing.T) {
|
|
||||||
tests := []struct {
|
|
||||||
name string
|
|
||||||
status string
|
|
||||||
success bool
|
|
||||||
want string
|
|
||||||
}{
|
|
||||||
{"approved success", "APPROVED", true, paymentstatus.Approved},
|
|
||||||
{"approved without success", "APPROVED", false, paymentstatus.Error},
|
|
||||||
{"declined", "DECLINED", false, paymentstatus.Declined},
|
|
||||||
{"cancelled", "CANCELLED", false, paymentstatus.Cancelled},
|
|
||||||
{"timeout", "TIMEOUT", false, paymentstatus.Timeout},
|
|
||||||
{"voided", "VOIDED", false, paymentstatus.Voided},
|
|
||||||
{"voided daily limit exceeded", "VOIDED_DAILY_LIMIT_EXCEEDED", false, paymentstatus.DailyLimitExceeded},
|
|
||||||
{"daily limit void failed", "DAILY_LIMIT_EXCEEDED_VOID_FAILED", false, paymentstatus.VoidFailed},
|
|
||||||
{"daily limit validation error", "DAILY_LIMIT_VALIDATION_ERROR", false, paymentstatus.LimitValidationError},
|
|
||||||
{"error", "ERROR", false, paymentstatus.Error},
|
|
||||||
{"failed", "FAILED", false, paymentstatus.Error},
|
|
||||||
{"unknown", "UNKNOWN", false, paymentstatus.Error},
|
|
||||||
{"approved case insensitive", "approved", true, paymentstatus.Approved},
|
|
||||||
{"declined case insensitive", "declined", false, paymentstatus.Declined},
|
|
||||||
}
|
|
||||||
|
|
||||||
for _, test := range tests {
|
|
||||||
t.Run(test.name, func(t *testing.T) {
|
|
||||||
got := mapPayBridgeFinalStatus(test.status, test.success)
|
|
||||||
if got != test.want {
|
|
||||||
t.Fatalf("got %q, want %q", got, test.want)
|
|
||||||
}
|
|
||||||
})
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
func TestMapPayBridgeStatusMessages(t *testing.T) {
|
|
||||||
tests := []struct {
|
|
||||||
name string
|
|
||||||
status string
|
|
||||||
want string
|
|
||||||
}{
|
|
||||||
{"insert or swipe card", "insert or swipe card", paymentstatus.PresentCard},
|
|
||||||
{"insert swipe or present card", "insert, swipe or present card", paymentstatus.PresentCard},
|
|
||||||
{"insert card", "insert card", paymentstatus.InsertCard},
|
|
||||||
{"please wait", "please wait", paymentstatus.PleaseWait},
|
|
||||||
{"do not remove card", "please wait. do not remove card", paymentstatus.DoNotRemoveCard},
|
|
||||||
{"try another interface", "please try another interface", paymentstatus.TryAnotherInterface},
|
|
||||||
{"pin", "pin", paymentstatus.EnterPIN},
|
|
||||||
{"pin again", "pin again", paymentstatus.EnterPINAgain},
|
|
||||||
{"transaction cancelled", "transaction cancelled", paymentstatus.Cancelled},
|
|
||||||
{"processing", "processing", paymentstatus.Processing},
|
|
||||||
{"approved", "approved", paymentstatus.Authorized},
|
|
||||||
{"declined", "declined", paymentstatus.Declined},
|
|
||||||
}
|
|
||||||
|
|
||||||
for _, test := range tests {
|
|
||||||
t.Run(test.name, func(t *testing.T) {
|
|
||||||
got, matched := mapPayBridgeStatus(test.status, "")
|
|
||||||
if !matched {
|
|
||||||
t.Fatal("expected status to match")
|
|
||||||
}
|
|
||||||
if got != test.want {
|
|
||||||
t.Fatalf("got %q, want %q", got, test.want)
|
|
||||||
}
|
|
||||||
})
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
func TestMapPayBridgeStatusCodes(t *testing.T) {
|
|
||||||
tests := []struct {
|
|
||||||
name string
|
|
||||||
code string
|
|
||||||
want string
|
|
||||||
}{
|
|
||||||
{"insert card", "101", paymentstatus.InsertCard},
|
|
||||||
{"enter pin", "106", paymentstatus.EnterPIN},
|
|
||||||
{"cancelled", "124", paymentstatus.Cancelled},
|
|
||||||
{"please wait", "1017", paymentstatus.PleaseWait},
|
|
||||||
{"present card", "1109", paymentstatus.PresentCard},
|
|
||||||
{"present card alternate", "1113", paymentstatus.PresentCard},
|
|
||||||
{"enter pin again", "1129", paymentstatus.EnterPINAgain},
|
|
||||||
{"try another interface", "1274", paymentstatus.TryAnotherInterface},
|
|
||||||
{"do not remove card", "1312", paymentstatus.DoNotRemoveCard},
|
|
||||||
}
|
|
||||||
|
|
||||||
for _, test := range tests {
|
|
||||||
t.Run(test.name, func(t *testing.T) {
|
|
||||||
got, matched := mapPayBridgeStatus("", test.code)
|
|
||||||
if !matched {
|
|
||||||
t.Fatal("expected code to match")
|
|
||||||
}
|
|
||||||
if got != test.want {
|
|
||||||
t.Fatalf("got %q, want %q", got, test.want)
|
|
||||||
}
|
|
||||||
})
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
func TestMapPayBridgeStatusNormalization(t *testing.T) {
|
|
||||||
got, matched := mapPayBridgeStatus(" PiN AgAiN ", "")
|
|
||||||
if !matched || got != paymentstatus.EnterPINAgain {
|
|
||||||
t.Fatalf("normalized message got (%q, %t), want (%q, true)", got, matched, paymentstatus.EnterPINAgain)
|
|
||||||
}
|
|
||||||
|
|
||||||
got, matched = mapPayBridgeStatus("", " 101 ")
|
|
||||||
if !matched || got != paymentstatus.InsertCard {
|
|
||||||
t.Fatalf("trimmed code got (%q, %t), want (%q, true)", got, matched, paymentstatus.InsertCard)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
func TestMapPayBridgeStatusUnknown(t *testing.T) {
|
|
||||||
got, matched := mapPayBridgeStatus("unknown message", "999")
|
|
||||||
if matched {
|
|
||||||
t.Fatal("unknown status and code must not match")
|
|
||||||
}
|
|
||||||
if got != paymentstatus.Processing {
|
|
||||||
t.Fatalf("got %q, want %q", got, paymentstatus.Processing)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
@@ -53,13 +53,3 @@ type PaymentErrorEnvelope struct {
|
|||||||
Status string `json:"status"`
|
Status string `json:"status"`
|
||||||
} `json:"data"`
|
} `json:"data"`
|
||||||
}
|
}
|
||||||
|
|
||||||
type StatusUpdateEnvelope struct {
|
|
||||||
Type string `json:"type"`
|
|
||||||
|
|
||||||
Data struct {
|
|
||||||
Status string `json:"status"`
|
|
||||||
Code string `json:"code"`
|
|
||||||
Timestamp int64 `json:"timestamp"`
|
|
||||||
} `json:"data"`
|
|
||||||
}
|
|
||||||
@@ -6,23 +6,10 @@ import (
|
|||||||
"sync"
|
"sync"
|
||||||
)
|
)
|
||||||
|
|
||||||
var (
|
var ErrPaymentInProgress = errors.New("payment is already in progress")
|
||||||
ErrPaymentInProgress = errors.New("payment is already in progress")
|
|
||||||
ErrProviderNotConfigured = errors.New("payment provider is not configured")
|
|
||||||
)
|
|
||||||
|
|
||||||
type StatusUpdate struct {
|
|
||||||
Code string `json:"code"`
|
|
||||||
}
|
|
||||||
|
|
||||||
type StatusHandler func(StatusUpdate)
|
|
||||||
|
|
||||||
type Provider interface {
|
type Provider interface {
|
||||||
Sale(
|
Sale(ctx context.Context, req SaleRequest) (*Result, error)
|
||||||
ctx context.Context,
|
|
||||||
req SaleRequest,
|
|
||||||
onStatus StatusHandler,
|
|
||||||
) (*Result, error)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
type Service struct {
|
type Service struct {
|
||||||
@@ -33,20 +20,10 @@ type Service struct {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func NewService(provider Provider) *Service {
|
func NewService(provider Provider) *Service {
|
||||||
return &Service{
|
return &Service{provider: provider}
|
||||||
provider: provider,
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
func (s *Service) Sale(
|
func (s *Service) Sale(ctx context.Context, req SaleRequest) (*Result, error) {
|
||||||
ctx context.Context,
|
|
||||||
req SaleRequest,
|
|
||||||
onStatus StatusHandler,
|
|
||||||
) (*Result, error) {
|
|
||||||
if s == nil || s.provider == nil {
|
|
||||||
return nil, ErrProviderNotConfigured
|
|
||||||
}
|
|
||||||
|
|
||||||
s.mu.Lock()
|
s.mu.Lock()
|
||||||
if s.busy {
|
if s.busy {
|
||||||
s.mu.Unlock()
|
s.mu.Unlock()
|
||||||
@@ -61,5 +38,5 @@ func (s *Service) Sale(
|
|||||||
s.mu.Unlock()
|
s.mu.Unlock()
|
||||||
}()
|
}()
|
||||||
|
|
||||||
return s.provider.Sale(ctx, req, onStatus)
|
return s.provider.Sale(ctx, req)
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,41 +0,0 @@
|
|||||||
// Package paymentstatus defines progress codes emitted by Hardlink's
|
|
||||||
// POST /api/payment/sale stream. These codes are not authoritative final
|
|
||||||
// transaction decisions: clients may continue check-in only after receiving a
|
|
||||||
// final result frame whose response.data begins with /successful.
|
|
||||||
package paymentstatus
|
|
||||||
|
|
||||||
const (
|
|
||||||
Starting = "PAYMENT_STARTING"
|
|
||||||
Started = "PAYMENT_STARTED"
|
|
||||||
RequestSent = "PAYMENT_REQUEST_SENT"
|
|
||||||
Accepted = "PAYMENT_ACCEPTED"
|
|
||||||
PresentCard = "PAYMENT_PRESENT_CARD"
|
|
||||||
InsertCard = "PAYMENT_INSERT_CARD"
|
|
||||||
SwipeCard = "PAYMENT_SWIPE_CARD"
|
|
||||||
EnterPIN = "PAYMENT_ENTER_PIN"
|
|
||||||
EnterPINAgain = "PAYMENT_ENTER_PIN_AGAIN"
|
|
||||||
PleaseWait = "PAYMENT_PLEASE_WAIT"
|
|
||||||
DoNotRemoveCard = "PAYMENT_DO_NOT_REMOVE_CARD"
|
|
||||||
RemoveCard = "PAYMENT_REMOVE_CARD"
|
|
||||||
TryAnotherInterface = "PAYMENT_TRY_ANOTHER_INTERFACE"
|
|
||||||
Processing = "PAYMENT_PROCESSING"
|
|
||||||
Authorized = "PAYMENT_AUTHORIZED"
|
|
||||||
Approved = "PAYMENT_APPROVED"
|
|
||||||
Cancelling = "PAYMENT_CANCELLING"
|
|
||||||
Cancelled = "PAYMENT_CANCELLED"
|
|
||||||
Declined = "PAYMENT_DECLINED"
|
|
||||||
Expired = "PAYMENT_EXPIRED"
|
|
||||||
Timeout = "PAYMENT_TIMEOUT"
|
|
||||||
SignatureRequired = "PAYMENT_SIGNATURE_REQUIRED"
|
|
||||||
SignatureRejecting = "PAYMENT_SIGNATURE_REJECTING"
|
|
||||||
SignatureRejected = "PAYMENT_SIGNATURE_REJECTED"
|
|
||||||
Voided = "PAYMENT_VOIDED"
|
|
||||||
DailyLimitExceeded = "PAYMENT_DAILY_LIMIT_EXCEEDED"
|
|
||||||
VoidFailed = "PAYMENT_VOID_FAILED"
|
|
||||||
LimitValidationError = "PAYMENT_LIMIT_VALIDATION_ERROR"
|
|
||||||
Error = "PAYMENT_ERROR"
|
|
||||||
TerminalUnavailable = "PAYMENT_TERMINAL_UNAVAILABLE"
|
|
||||||
|
|
||||||
DojoNotificationPrefix = "PAYMENT_DOJO_NOTIFICATION_"
|
|
||||||
DojoStatusPrefix = "PAYMENT_DOJO_STATUS_"
|
|
||||||
)
|
|
||||||
@@ -1,84 +0,0 @@
|
|||||||
package paymentstatus_test
|
|
||||||
|
|
||||||
import (
|
|
||||||
"strings"
|
|
||||||
"testing"
|
|
||||||
|
|
||||||
"gitea.futuresens.co.uk/futuresens/hardlink/paymentstatus"
|
|
||||||
)
|
|
||||||
|
|
||||||
func TestFixedStatusValues(t *testing.T) {
|
|
||||||
statuses := []struct {
|
|
||||||
name string
|
|
||||||
value string
|
|
||||||
want string
|
|
||||||
}{
|
|
||||||
{"Starting", paymentstatus.Starting, "PAYMENT_STARTING"},
|
|
||||||
{"Started", paymentstatus.Started, "PAYMENT_STARTED"},
|
|
||||||
{"RequestSent", paymentstatus.RequestSent, "PAYMENT_REQUEST_SENT"},
|
|
||||||
{"Accepted", paymentstatus.Accepted, "PAYMENT_ACCEPTED"},
|
|
||||||
{"PresentCard", paymentstatus.PresentCard, "PAYMENT_PRESENT_CARD"},
|
|
||||||
{"InsertCard", paymentstatus.InsertCard, "PAYMENT_INSERT_CARD"},
|
|
||||||
{"SwipeCard", paymentstatus.SwipeCard, "PAYMENT_SWIPE_CARD"},
|
|
||||||
{"EnterPIN", paymentstatus.EnterPIN, "PAYMENT_ENTER_PIN"},
|
|
||||||
{"EnterPINAgain", paymentstatus.EnterPINAgain, "PAYMENT_ENTER_PIN_AGAIN"},
|
|
||||||
{"PleaseWait", paymentstatus.PleaseWait, "PAYMENT_PLEASE_WAIT"},
|
|
||||||
{"DoNotRemoveCard", paymentstatus.DoNotRemoveCard, "PAYMENT_DO_NOT_REMOVE_CARD"},
|
|
||||||
{"RemoveCard", paymentstatus.RemoveCard, "PAYMENT_REMOVE_CARD"},
|
|
||||||
{"TryAnotherInterface", paymentstatus.TryAnotherInterface, "PAYMENT_TRY_ANOTHER_INTERFACE"},
|
|
||||||
{"Processing", paymentstatus.Processing, "PAYMENT_PROCESSING"},
|
|
||||||
{"Authorized", paymentstatus.Authorized, "PAYMENT_AUTHORIZED"},
|
|
||||||
{"Approved", paymentstatus.Approved, "PAYMENT_APPROVED"},
|
|
||||||
{"Cancelling", paymentstatus.Cancelling, "PAYMENT_CANCELLING"},
|
|
||||||
{"Cancelled", paymentstatus.Cancelled, "PAYMENT_CANCELLED"},
|
|
||||||
{"Declined", paymentstatus.Declined, "PAYMENT_DECLINED"},
|
|
||||||
{"Expired", paymentstatus.Expired, "PAYMENT_EXPIRED"},
|
|
||||||
{"Timeout", paymentstatus.Timeout, "PAYMENT_TIMEOUT"},
|
|
||||||
{"SignatureRequired", paymentstatus.SignatureRequired, "PAYMENT_SIGNATURE_REQUIRED"},
|
|
||||||
{"SignatureRejecting", paymentstatus.SignatureRejecting, "PAYMENT_SIGNATURE_REJECTING"},
|
|
||||||
{"SignatureRejected", paymentstatus.SignatureRejected, "PAYMENT_SIGNATURE_REJECTED"},
|
|
||||||
{"Voided", paymentstatus.Voided, "PAYMENT_VOIDED"},
|
|
||||||
{"DailyLimitExceeded", paymentstatus.DailyLimitExceeded, "PAYMENT_DAILY_LIMIT_EXCEEDED"},
|
|
||||||
{"VoidFailed", paymentstatus.VoidFailed, "PAYMENT_VOID_FAILED"},
|
|
||||||
{"LimitValidationError", paymentstatus.LimitValidationError, "PAYMENT_LIMIT_VALIDATION_ERROR"},
|
|
||||||
{"Error", paymentstatus.Error, "PAYMENT_ERROR"},
|
|
||||||
{"TerminalUnavailable", paymentstatus.TerminalUnavailable, "PAYMENT_TERMINAL_UNAVAILABLE"},
|
|
||||||
}
|
|
||||||
|
|
||||||
seen := make(map[string]string, len(statuses))
|
|
||||||
for _, status := range statuses {
|
|
||||||
t.Run(status.name, func(t *testing.T) {
|
|
||||||
if status.value != status.want {
|
|
||||||
t.Fatalf("got %q, want %q", status.value, status.want)
|
|
||||||
}
|
|
||||||
if !strings.HasPrefix(status.value, "PAYMENT_") {
|
|
||||||
t.Fatalf("status %q does not have PAYMENT_ prefix", status.value)
|
|
||||||
}
|
|
||||||
})
|
|
||||||
|
|
||||||
if previous, exists := seen[status.value]; exists {
|
|
||||||
t.Errorf("%s and %s have duplicate value %q", previous, status.name, status.value)
|
|
||||||
}
|
|
||||||
seen[status.value] = status.name
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
func TestDojoPrefixes(t *testing.T) {
|
|
||||||
if paymentstatus.DojoNotificationPrefix != "PAYMENT_DOJO_NOTIFICATION_" {
|
|
||||||
t.Fatalf(
|
|
||||||
"DojoNotificationPrefix = %q, want %q",
|
|
||||||
paymentstatus.DojoNotificationPrefix,
|
|
||||||
"PAYMENT_DOJO_NOTIFICATION_",
|
|
||||||
)
|
|
||||||
}
|
|
||||||
if paymentstatus.DojoStatusPrefix != "PAYMENT_DOJO_STATUS_" {
|
|
||||||
t.Fatalf(
|
|
||||||
"DojoStatusPrefix = %q, want %q",
|
|
||||||
paymentstatus.DojoStatusPrefix,
|
|
||||||
"PAYMENT_DOJO_STATUS_",
|
|
||||||
)
|
|
||||||
}
|
|
||||||
if paymentstatus.DojoNotificationPrefix == paymentstatus.DojoStatusPrefix {
|
|
||||||
t.Fatal("Dojo prefixes must differ")
|
|
||||||
}
|
|
||||||
}
|
|
||||||
+1
-7
@@ -2,14 +2,8 @@
|
|||||||
|
|
||||||
builtVersion is a const in main.go
|
builtVersion is a const in main.go
|
||||||
|
|
||||||
#### v1.3.4 - 23 July 2026
|
|
||||||
added support for Dojo terminal-unavailable responses
|
|
||||||
|
|
||||||
#### v1.3.3 - 21 July 2026
|
|
||||||
added PDQ status streaming to the payment flow to allow the front end to display the status of the PDQ terminal
|
|
||||||
|
|
||||||
#### 1.3.2 - 20 July 2026
|
#### 1.3.2 - 20 July 2026
|
||||||
make dojo decline payment in case of signature required
|
make dojo decline payment it case of signature required
|
||||||
|
|
||||||
#### 1.3.1 - 17 July 2026
|
#### 1.3.1 - 17 July 2026
|
||||||
added receipt printing functionality to the Dojo and Paybridge payment flow
|
added receipt printing functionality to the Dojo and Paybridge payment flow
|
||||||
|
|||||||
Reference in New Issue
Block a user