fix(creditcall): require fresh confirmation approval for sale
This commit is contained in:
@@ -41,6 +41,8 @@ type creditCallDiagnosticFixture struct {
|
||||
initial, confirmation map[string]string
|
||||
startFailure, confirmFailure string
|
||||
confirmationXML string
|
||||
emptyConfirmation bool
|
||||
correctedConfirmation bool
|
||||
recoverConfirmation bool
|
||||
zero bool
|
||||
reason, message string
|
||||
@@ -150,18 +152,61 @@ func creditCallDiagnosticFixtures() []creditCallDiagnosticFixture {
|
||||
fixtures = append(fixtures, creditCallDiagnosticFixture{name: "sale/confirmation_recovers/" + failure, operation: "sale",
|
||||
initial: creditCallDiagnosticFields("APPROVED", ""), confirmFailure: failure, recoverConfirmation: true, message: "Payment approved"})
|
||||
}
|
||||
for _, response := range []struct{ name, xml, reason, cause string }{
|
||||
{"omitted", "<TransactionResult/>", "", ""},
|
||||
{"malformed_retains_approval", "<TransactionResult><Entry>", "", ""},
|
||||
const approvedEntry = "<Entry><Key>TRANSACTION_RESULT</Key><Value>APPROVED</Value></Entry>"
|
||||
const declinedEntry = "<Entry><Key>TRANSACTION_RESULT</Key><Value>DECLINED</Value></Entry>"
|
||||
const errorEntry = "<Entry><Key>TRANSACTION_RESULT</Key><Value>ERROR</Value></Entry>"
|
||||
const emptyEntry = "<Entry><Key>TRANSACTION_RESULT</Key><Value></Value></Entry>"
|
||||
for _, response := range []struct {
|
||||
name, xml, reason, cause string
|
||||
corrected bool
|
||||
}{
|
||||
{"mixed_case", "<TransactionResult><Entry><Key>TRANSACTION_RESULT</Key><Value>aPpRoVeD</Value></Entry></TransactionResult>", "", "", false},
|
||||
{"omitted", "<TransactionResult/>", "confirmation_result_unknown", "ConfirmTransaction result unknown", true},
|
||||
{"empty_body", "", "confirmation_invalid_response", "ConfirmTransaction response is invalid", true},
|
||||
{"whitespace_body", " \r\n\t", "confirmation_invalid_response", "ConfirmTransaction response is invalid", true},
|
||||
{"malformed_retains_approval", "<TransactionResult><Entry>", "confirmation_invalid_response", "ConfirmTransaction response is invalid", true},
|
||||
{"malformed_after_approved", "<TransactionResult>" + approvedEntry + "<Entry>", "confirmation_invalid_response", "ConfirmTransaction response is invalid", true},
|
||||
{"malformed_after_error", "<TransactionResult><Entry><Key>TRANSACTION_RESULT</Key><Value>ERROR</Value></Entry><Entry>",
|
||||
"confirmation_invalid_response", "ConfirmTransaction response is invalid"},
|
||||
"confirmation_invalid_response", "ConfirmTransaction response is invalid", false},
|
||||
{"malformed_after_declined", "<TransactionResult>" + declinedEntry + "<Entry>", "confirmation_invalid_response", "ConfirmTransaction response is invalid", false},
|
||||
{"wrong_root", "<Unexpected/>", "confirmation_invalid_response", "ConfirmTransaction response is invalid", true},
|
||||
{"sdk_only_disconnected", "<TransactionResult><Entry><Key>ERRORS</Key><Value>ClientNotConnectedToServer</Value></Entry></TransactionResult>",
|
||||
"confirmation_sdk_ClientNotConnectedToServer", "ConfirmTransaction: ClientNotConnectedToServer", true},
|
||||
{"sdk_only_not_found", "<TransactionResult><Entry><Key>ERRORS</Key><Value>TransactionNotFound</Value></Entry></TransactionResult>",
|
||||
"confirmation_sdk_TransactionNotFound", "ConfirmTransaction: TransactionNotFound", true},
|
||||
{"duplicate_approved_declined", "<TransactionResult>" + approvedEntry + declinedEntry + "</TransactionResult>",
|
||||
"confirmation_result_declined", "ConfirmTransaction result declined", false},
|
||||
{"duplicate_declined_approved", "<TransactionResult>" + declinedEntry + approvedEntry + "</TransactionResult>", "", "", false},
|
||||
{"duplicate_error_approved", "<TransactionResult>" + errorEntry + approvedEntry + "</TransactionResult>", "", "", false},
|
||||
{"duplicate_approved_empty", "<TransactionResult>" + approvedEntry + emptyEntry + "</TransactionResult>",
|
||||
"confirmation_result_unknown", "ConfirmTransaction result unknown", false},
|
||||
{"duplicate_empty_approved", "<TransactionResult>" + emptyEntry + approvedEntry + "</TransactionResult>", "", "", false},
|
||||
{"duplicate_approved_error", "<TransactionResult>" + approvedEntry + errorEntry + "</TransactionResult>",
|
||||
"confirmation_result_error", "ConfirmTransaction result error", false},
|
||||
} {
|
||||
message := "Payment approved"
|
||||
if response.reason != "" {
|
||||
message = "Payment outcome uncertain: " + response.cause + "; contact reception"
|
||||
}
|
||||
fixtures = append(fixtures, creditCallDiagnosticFixture{name: "sale/confirmation_xml/" + response.name, operation: "sale",
|
||||
initial: creditCallDiagnosticFields("APPROVED", "ChipCardRemoved"), confirmationXML: response.xml, reason: response.reason, message: message})
|
||||
initial: creditCallDiagnosticFields("APPROVED", "ChipCardRemoved"), confirmationXML: response.xml,
|
||||
emptyConfirmation: response.xml == "", correctedConfirmation: response.corrected, reason: response.reason, message: message})
|
||||
}
|
||||
for _, metadata := range []string{"returned_amount", "overrides", "empty_overrides"} {
|
||||
fields := creditCallDiagnosticFields("APPROVED", "")
|
||||
fields[types.TotalAmount] = "3100"
|
||||
confirmation := map[string]string{types.TransactionResult: "APPROVED"}
|
||||
if metadata == "overrides" {
|
||||
confirmation[types.Reference], confirmation[types.TotalAmount] = "SYNTH-CONFIRMATION", "2500"
|
||||
confirmation[types.CardType], confirmation[types.PanMasked] = "Mastercard", "************7788"
|
||||
confirmation[types.ExpiryDate], confirmation[types.CardReference] = "1231", "synthetic-confirmation-card"
|
||||
confirmation[types.ReceiptDataCardholder] = "synthetic confirmation receipt"
|
||||
}
|
||||
if metadata == "empty_overrides" {
|
||||
confirmation[types.ExpiryDate], confirmation[types.CardHash], confirmation[types.ReceiptDataCardholder] = "", "", ""
|
||||
}
|
||||
fixtures = append(fixtures, creditCallDiagnosticFixture{name: "sale/confirmation_metadata/" + metadata, operation: "sale",
|
||||
initial: fields, confirmation: confirmation, message: "Payment approved"})
|
||||
}
|
||||
for _, code := range []string{"ConfirmTransaction failed: SYNTHETIC-SECRET PAN=4111111111111111", "ChipCardRemoved,SYNTHETIC-SECRET", "500005", "chipcardremoved"} {
|
||||
reason, cause := "confirmation_result_error", "ConfirmTransaction result error"
|
||||
@@ -274,7 +319,7 @@ func captureCreditCallDiagnostic(t *testing.T, fixture creditCallDiagnosticFixtu
|
||||
fields = map[string]string{types.TransactionResult: "APPROVED", types.ReceiptDataCardholder: "synthetic confirmation receipt"}
|
||||
}
|
||||
xmlBody := fixture.confirmationXML
|
||||
if xmlBody == "" {
|
||||
if xmlBody == "" && !fixture.emptyConfirmation {
|
||||
xmlBody = chipDNAFixture(t, fields)
|
||||
}
|
||||
body.Reader = strings.NewReader(xmlBody)
|
||||
@@ -380,12 +425,17 @@ func captureCreditCallDiagnostic(t *testing.T, fixture creditCallDiagnosticFixtu
|
||||
// the captured unmodified production source and the diagnostic implementation.
|
||||
func TestCreditCallDiagnosticParityCapture(t *testing.T) {
|
||||
observations := map[string]creditCallDiagnosticObservation{}
|
||||
corrections := map[string]creditCallDiagnosticFixture{}
|
||||
for _, fixture := range creditCallDiagnosticFixtures() {
|
||||
if fixture.correctedConfirmation {
|
||||
corrections[fixture.name] = fixture
|
||||
corrections["legacy/"+fixture.name] = fixture
|
||||
}
|
||||
t.Run(fixture.name, func(t *testing.T) {
|
||||
observations[fixture.name] = captureCreditCallDiagnostic(t, fixture, false)
|
||||
})
|
||||
}
|
||||
// Legacy responses and side effects must remain exactly unchanged too.
|
||||
// Legacy observations use the same explicitly allowed correction cases.
|
||||
for _, fixture := range creditCallDiagnosticFixtures() {
|
||||
if fixture.startFailure != "" || fixture.zero || fixture.confirmFailure != "" {
|
||||
continue
|
||||
@@ -421,9 +471,20 @@ func TestCreditCallDiagnosticParityCapture(t *testing.T) {
|
||||
t.Errorf("missing baseline fixture %q", name)
|
||||
continue
|
||||
}
|
||||
if want.Final != nil && got.Final != nil {
|
||||
want.Final.Reason, want.Final.Message = "", ""
|
||||
got.Final.Reason, got.Final.Message = "", ""
|
||||
if fixture, corrected := corrections[name]; corrected {
|
||||
if want.Final != nil {
|
||||
if want.Final.Outcome != "approved" || want.Final.Retryable {
|
||||
t.Fatalf("%s baseline=%+v, want the specifically identified false approval", name, want.Final)
|
||||
}
|
||||
want.Final = &paymentapi.Result{Outcome: "unknown", HTTPStatus: http.StatusOK, Provider: "creditcall",
|
||||
AmountMinor: 1234, CurrencyCode: "GBP", Reason: fixture.reason, Message: fixture.message}
|
||||
} else {
|
||||
if !strings.HasPrefix(want.Legacy.Data, "/successful?") {
|
||||
t.Fatalf("%s baseline=%+v, want the specifically identified false success redirect", name, want.Legacy)
|
||||
}
|
||||
want.Legacy = &cmstypes.ResponseRec{Status: cmstypes.StatusRec{Code: http.StatusOK, Message: "unknown"},
|
||||
Data: "/unsuccessful?Description=Transaction+unknown&MsgType=error"}
|
||||
}
|
||||
}
|
||||
// SQL generates the transaction timestamp during each run. Its type,
|
||||
// UTC location and range are asserted above; retain raw values in captures.
|
||||
@@ -431,7 +492,7 @@ func TestCreditCallDiagnosticParityCapture(t *testing.T) {
|
||||
want.Persistence["TxnDateTime"], got.Persistence["TxnDateTime"] = "validated current UTC time", "validated current UTC time"
|
||||
}
|
||||
if !reflect.DeepEqual(got, want) {
|
||||
t.Errorf("%s changed beyond diagnostic fields: got %+v, want %+v", name, got, want)
|
||||
t.Errorf("%s changed beyond the exact approved correction: got %+v, want %+v", name, got, want)
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -489,12 +550,12 @@ func TestCreditCallDiagnosticEntryOrderAndOwnership(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func TestCreditCallConfirmationSDKErrorWithoutResultKeepsLegacyApproval(t *testing.T) {
|
||||
func TestCreditCallConfirmationSDKErrorWithoutResultRemainsUncertain(t *testing.T) {
|
||||
fixture := creditCallDiagnosticFixture{name: "sale/confirmation_sdk_without_result", operation: "sale",
|
||||
initial: creditCallDiagnosticFields("APPROVED", ""), confirmation: map[string]string{types.Errors: "TransactionNotFound"}}
|
||||
initial: creditCallDiagnosticFields("APPROVED", ""), confirmation: map[string]string{types.Errors: "ClientNotConnectedToServer"}}
|
||||
got := captureCreditCallDiagnostic(t, fixture, false)
|
||||
if got.Final.Outcome != "approved" || got.Final.Reason != "" || got.Final.TransactionReference != "SYNTH-STAGE2" || got.Final.AmountMinor != 1234 {
|
||||
t.Errorf("confirmation SDK error without TRANSACTION_RESULT final=%+v, want unchanged inherited approval and metadata", got.Final)
|
||||
if got.Final.Outcome != "unknown" || got.Final.Retryable || got.Final.Reason != "confirmation_sdk_ClientNotConnectedToServer" || got.Final.TransactionReference != "" || got.Final.AmountMinor != 1234 {
|
||||
t.Errorf("confirmation SDK error without TRANSACTION_RESULT final=%+v, want nonretryable uncertainty without approved-only metadata", got.Final)
|
||||
}
|
||||
if len(got.Requests) != 2 || !reflect.DeepEqual(got.Receipts, []string{"synthetic initial receipt"}) {
|
||||
t.Errorf("confirmation SDK error without TRANSACTION_RESULT requests/receipts=%v/%v, want one start, one confirmation and inherited receipt", got.Requests, got.Receipts)
|
||||
|
||||
Reference in New Issue
Block a user