fix(creditcall): preserve detailed SDK failure diagnostics
This commit is contained in:
@@ -0,0 +1,118 @@
|
||||
package handlers
|
||||
|
||||
import (
|
||||
"context"
|
||||
"errors"
|
||||
"net"
|
||||
"net/url"
|
||||
"strings"
|
||||
|
||||
"gitea.futuresens.co.uk/futuresens/hardlink/v2/internal/creditcall"
|
||||
"gitea.futuresens.co.uk/futuresens/hardlink/v2/internal/types"
|
||||
"gitea.futuresens.co.uk/futuresens/hardlink/v2/paymentapi"
|
||||
)
|
||||
|
||||
// creditCallDiagnostic carries allowlisted observations, never financial evidence.
|
||||
type creditCallDiagnostic struct {
|
||||
reason string
|
||||
cause string
|
||||
}
|
||||
|
||||
func (diagnostic creditCallDiagnostic) apply(final *paymentapi.Result) {
|
||||
if diagnostic.reason == "" || final.Reason != "" {
|
||||
return
|
||||
}
|
||||
switch final.Outcome {
|
||||
case "unknown":
|
||||
final.Message = "Payment outcome uncertain: " + diagnostic.cause + "; contact reception"
|
||||
case "declined":
|
||||
final.Message = "Transaction declined: " + diagnostic.cause
|
||||
case "cancelled":
|
||||
final.Message = "Transaction cancelled: " + diagnostic.cause
|
||||
default:
|
||||
return
|
||||
}
|
||||
final.Reason = diagnostic.reason
|
||||
}
|
||||
|
||||
func creditCallInitialDiagnostic(result creditcall.TransactionResultXML) creditCallDiagnostic {
|
||||
transactionResult, sdkError := creditCallDiagnosticFieldsFromEntries(result.Entries)
|
||||
switch strings.ToLower(transactionResult) {
|
||||
case types.ResultApproved:
|
||||
return creditCallDiagnostic{}
|
||||
case "timeout":
|
||||
return creditCallDiagnostic{reason: "cli_timeout", cause: "CLI wait expired"}
|
||||
}
|
||||
if recognizedCreditCallSDKError(sdkError) {
|
||||
return creditCallDiagnostic{reason: "sdk_" + sdkError, cause: sdkError}
|
||||
}
|
||||
return creditCallDiagnostic{}
|
||||
}
|
||||
|
||||
func creditCallConfirmationErrorDiagnostic(err error) creditCallDiagnostic {
|
||||
var networkError net.Error
|
||||
if errors.Is(err, context.DeadlineExceeded) || (errors.As(err, &networkError) && networkError.Timeout()) {
|
||||
return creditCallDiagnostic{reason: "confirmation_timeout", cause: "ConfirmTransaction timed out"}
|
||||
}
|
||||
var requestError *url.Error
|
||||
if errors.As(err, &requestError) {
|
||||
return creditCallDiagnostic{reason: "confirmation_request_error", cause: "ConfirmTransaction request failed"}
|
||||
}
|
||||
return creditCallDiagnostic{reason: "confirmation_response_read_error", cause: "ConfirmTransaction response could not be read"}
|
||||
}
|
||||
|
||||
func creditCallConfirmationResultDiagnostic(entries []creditcall.EntryXML, invalidXML bool) creditCallDiagnostic {
|
||||
if invalidXML {
|
||||
return creditCallDiagnostic{reason: "confirmation_invalid_response", cause: "ConfirmTransaction response is invalid"}
|
||||
}
|
||||
transactionResult, sdkError := creditCallDiagnosticFieldsFromEntries(entries)
|
||||
if recognizedCreditCallSDKError(sdkError) {
|
||||
return creditCallDiagnostic{reason: "confirmation_sdk_" + sdkError, cause: "ConfirmTransaction: " + sdkError}
|
||||
}
|
||||
result := strings.ToLower(transactionResult)
|
||||
if result == types.ResultError && strings.HasPrefix(sdkError, "ConfirmTransaction failed:") {
|
||||
return creditCallDiagnostic{reason: "confirmation_cli_error", cause: "ConfirmTransaction CLI failed"}
|
||||
}
|
||||
switch result {
|
||||
case "canceled", "cancelled":
|
||||
result = "cancelled"
|
||||
case types.ResultDeclined, types.ResultError, "timeout":
|
||||
default:
|
||||
result = "unknown"
|
||||
}
|
||||
return creditCallDiagnostic{reason: "confirmation_result_" + result, cause: "ConfirmTransaction result " + result}
|
||||
}
|
||||
|
||||
func creditCallDiagnosticFieldsFromEntries(entries []creditcall.EntryXML) (transactionResult, sdkError string) {
|
||||
for _, entry := range entries {
|
||||
switch entry.Key {
|
||||
case types.TransactionResult:
|
||||
transactionResult = entry.Value
|
||||
case types.Errors:
|
||||
sdkError = entry.Value
|
||||
}
|
||||
}
|
||||
return transactionResult, sdkError
|
||||
}
|
||||
|
||||
// recognizedCreditCallSDKError matches exact symbolic names from the bundled
|
||||
// ChipDNA SDK 3.17 transaction error types. Descriptions and numeric/compound
|
||||
// errors are deliberately excluded; numeric values overlap between SDK types.
|
||||
func recognizedCreditCallSDKError(code string) bool {
|
||||
switch code {
|
||||
case "ChipCardRemoved", "ClientNotConnectedToServer", "NoPinPadsAvailable", "AmountTooLarge", "AmountTooSmall",
|
||||
"NoPinPadsConfigured", "PaymentDeviceUnavailable", "PaymentDeviceNotInitialized", "PinpadConnectionClosed",
|
||||
"PinPadTransactionTerminated", "EposTransactionTerminated", "TransactionProcessingError", "TransactionInProgress",
|
||||
"TransactionAlreadyInProgressError", "TransactionNotStarted", "MissingParameter", "InvalidParameter", "InvalidValue",
|
||||
"UnexpectedParameters", "AmountZeroNotAllowed", "AmountInvalid", "AmountMissing",
|
||||
"ReferenceAlreadyExistsForApprovedTransaction", "PinPadAmountInvalid", "PinpadAmountTooLarge",
|
||||
"TransactionReferenceMissing", "TransactionReferenceEmpty", "TransactionForConfirmVoidNotFound", "TransactionNotFound",
|
||||
"TransactionAlreadyConfirmed", "TransactionOriginallyDeclined", "TransactionNotCommitted", "ConfirmRequestFailed",
|
||||
"ConfirmAccountVerificationNotAllowed", "ConfirmLinkedRefundNotAllowed", "RemoteServerAccessFailed",
|
||||
"ServerCommunicationError", "ServerRequestError", "ServerResponseError", "NoResponseFromServer", "TemporarilyUnavailable",
|
||||
"ChipCardBlocked", "ChipReadFailure", "SwipeReadFailure", "ExpiredCard", "BadCard", "CardSchemeNotSupported", "CardUsageExceeded",
|
||||
"PinPadUserCancelled", "CardHolderActionTimedOut":
|
||||
return true
|
||||
}
|
||||
return false
|
||||
}
|
||||
Reference in New Issue
Block a user