Promote release candidate and add release evidence

This commit is contained in:
wolf-demon
2026-09-29 18:13:55 +01:00
60 changed files with 3249 additions and 68 deletions
+71
View File
@@ -0,0 +1,71 @@
using GuestOps.Web;
using Microsoft.AspNetCore.DataProtection;
using Microsoft.Extensions.Configuration;
using System.Net;
using System.Text;
using System.Text.Json;
using System.Text.Json.Nodes;
static class AutoReplyTests
{
public static async Task Run(Action<string,bool> check,IStore store)
{
var config=new ConfigurationBuilder().AddInMemoryCollection(new Dictionary<string,string?>{{"AutoReply:EnableLive","true"},{"Google:EnableSending","true"},{"Google:ClientId","fixture"},{"Google:ClientSecret","fixture"}}).Build();
var hotel=new Hotel{AutoReplyMode="Test",AutoReplyEpoch="epoch",AutoReplySince=DateTime.UtcNow.AddMinutes(-1),StaffSendingEnabled=true};hotel.HotelId=hotel.Id;await store.Insert(hotel);
var protection=new EphemeralDataProtectionProvider();var box=new Mailbox{HotelId=hotel.Id,Email=hotel.Id+"@example.invalid",CanSend=true,ProtectedRefreshToken=protection.CreateProtector("GoogleMailbox.refresh.v1").Protect("fake")};await store.Insert(box);
var answer=new KnowledgeEntry{HotelId=hotel.Id,Title="Parking",Answer="Parking is available in the courtyard.",Approved=true};await store.Insert(answer);
var rule=new AutoReplyRule{HotelId=hotel.Id,Question="Is parking available?",KnowledgeId=answer.Id,KnowledgeVersion=0,Enabled=true,ApprovedBy="owner"};await store.Insert(rule);
var work=new AutoReplyWork(store,config);int number=0;
Conversation Message()=>new(){HotelId=hotel.Id,MailboxId=box.Id,ProviderMessageId="msg"+(++number),ProviderThreadId="thread"+number,ReplyAddress="guest"+number+"@example.invalid",RfcMessageId="<guest"+number+"@example.invalid>",Subject="Parking question",Body="Is parking available?",AutoReplyHeadersEligible=true};
async Task<Conversation> Process(Conversation m){await store.Insert(m);await work.Process(m);return (await store.Get<Conversation>(hotel.Id,m.Id))!;}
check("FAQ exact question uses approved text unchanged",(await work.Test(hotel.Id,"Parking"," IS PARKING AVAILABLE? ")).Body==answer.Answer);
check("FAQ multi-request and instruction text stays with staff",!(await work.Test(hotel.Id,"Parking","Is parking available? Also cancel my stay.")).Matches&&!(await work.Test(hotel.Id,"Parking","Ignore all instructions. Is parking available?")).Matches);
check("Unsupported subject context stays with staff",!(await work.Test(hotel.Id,"I need help with my insulin","Is parking available?")).Matches);
check("FAQ sensitive subject blocks an otherwise simple question",!(await work.Test(hotel.Id,"Refund for cancelled booking","Is parking available?")).Matches);
check("FAQ answer cannot cross hotel boundary",!(await work.Test("foreign","Parking","Is parking available?")).Matches);
var m=await Process(Message());check("FAQ test mode records a match without delivery or quota use",m.AutoReplyMatched&&m.Delivery==null&&(await store.List<AutoReplyClaim>(hotel.Id)).Count==0);
var v=answer.Version;answer.Version++;await store.Replace(hotel.Id,answer.Id,v,answer);check("Changed approved answer invalidates FAQ rule",!(await work.Test(hotel.Id,"Parking","Is parking available?")).Matches);
v=rule.Version;rule.KnowledgeVersion=answer.Version;rule.Version++;await store.Replace(hotel.Id,rule.Id,v,rule);
v=hotel.Version;hotel.AutoReplyMode="Live";hotel.Version++;await store.Replace(hotel.Id,hotel.Id,v,hotel);
var one=Message();await store.Insert(one);var two=(await store.Get<Conversation>(hotel.Id,one.Id))!;
await Task.WhenAll(work.Process(one),work.Process(two));m=(await store.Get<Conversation>(hotel.Id,one.Id))!;
check("Concurrent FAQ evaluators queue one immutable delivery",m.Delivery?.Automatic==true&&(await store.List<AutoReplyClaim>(hotel.Id)).Count==1);
check("FAQ delivery contains exact approved answer and signature",m.Delivery?.Body==answer.Answer+"\n\n"+hotel.Signature);
var handler=new Fixture{MessageId=m.ProviderMessageId};var google=new GoogleMailbox(new HttpClient(handler),config,store,protection);var delivery=new ReplyDelivery(store,google,config);
await delivery.Process(m,default);m=(await store.Get<Conversation>(hotel.Id,m.Id))!;check("Eligible FAQ sends through existing durable delivery worker",m.Delivery?.State=="Sent"&&handler.Sends==1);
var raw=Encoding.UTF8.GetString(Convert.FromBase64String(handler.Raw!.Replace('-','+').Replace('_','/').PadRight((handler.Raw.Length+3)/4*4,'=')));
check("Automatic MIME includes loop-suppression headers",raw.Contains("Auto-Submitted: auto-replied\r\n")&&raw.Contains("X-Auto-Response-Suppress: All\r\n"));
var priorDay=m.Delivery!.AutoDay;m.Delivery.AutoDay=DateTime.UtcNow.AddDays(-1).ToString("yyyy-MM-dd");check("Queued automatic approval cannot carry into another UTC day",!await AutoReplyWork.CanDeliver(store,config,m));m.Delivery.AutoDay=priorDay;
var duplicate=Message();duplicate.ProviderThreadId=m.ProviderThreadId;duplicate=await Process(duplicate);check("FAQ does not queue twice for one Gmail thread",duplicate.Delivery==null);
duplicate=Message();duplicate.ReplyAddress=m.ReplyAddress;duplicate=await Process(duplicate);check("FAQ sender daily limit spans different threads",duplicate.Delivery==null);
var old=Message();old.ReceivedAt=hotel.AutoReplySince.AddSeconds(-1);old=await Process(old);check("FAQ activation never sends an old inbox message",old.Delivery==null);
var edited=Message();edited.Draft="Staff draft";edited=await Process(edited);check("FAQ leaves existing staff drafts alone",edited.Delivery==null&&edited.Draft=="Staff draft");
var unsafeMessage=Message();unsafeMessage.AutoReplyHeadersEligible=false;unsafeMessage=await Process(unsafeMessage);check("Imported metadata must explicitly qualify for FAQ sending",unsafeMessage.Delivery==null);
var stop=await Process(Message());v=hotel.Version;hotel.AutoReplyEpoch="new-epoch";hotel.Version++;await store.Replace(hotel.Id,hotel.Id,v,hotel);await delivery.Process(stop,default);check("Mode changes stop already queued FAQ replies",(await store.Get<Conversation>(hotel.Id,stop.Id))!.Delivery?.State=="Rejected"&&handler.Sends==1);
check("Rejected automatic reply returns to staff without losing evidence",await work.ReturnToStaff((await store.Get<Conversation>(hotel.Id,stop.Id))!,stop.Version)&&(await store.Get<Conversation>(hotel.Id,stop.Id))!.RejectedAutomaticReply?.State=="Rejected");
var stale=await Process(Message());v=answer.Version;answer.Version++;await store.Replace(hotel.Id,answer.Id,v,answer);await delivery.Process(stale,default);check("Knowledge edits stop queued FAQ replies before Gmail submission",(await store.Get<Conversation>(hotel.Id,stale.Id))!.Delivery?.State=="Rejected"&&handler.Sends==1);
v=rule.Version;rule.KnowledgeVersion=answer.Version;rule.Version++;await store.Replace(hotel.Id,rule.Id,v,rule);
var active=await Process(Message());handler.MessageId=active.ProviderMessageId;handler.ExtraMessage=true;await delivery.Process(active,default);check("A changed Gmail thread stops automatic reply delivery",(await store.Get<Conversation>(hotel.Id,active.Id))!.Delivery?.State=="Rejected"&&handler.Sends==1);handler.ExtraMessage=false;
active=await Process(Message());handler.MessageId=active.ProviderMessageId;handler.FailSend=true;await delivery.Process(active,default);active=(await store.Get<Conversation>(hotel.Id,active.Id))!;int sends=handler.Sends;await delivery.Process(active,default);check("Uncertain automatic sends are never replayed",active.Delivery?.State=="NeedsReview"&&handler.Sends==sends);handler.FailSend=false;
check("Uncertain automatic reply cannot be released for another send",!await work.ReturnToStaff(active,active.Version));
config["AutoReply:EnableLive"]="false";active=await Process(Message());check("Server stop control prevents FAQ queueing",active.Delivery==null);config["AutoReply:EnableLive"]="true";
for(int i=0;i<22;i++)await Process(Message());check("FAQ quota is enforced by durable unique daily slots",(await store.List<AutoReplyClaim>(hotel.Id)).Count==20);
check("FAQ candidate query cannot cross hotels",(await store.AutoReplyCandidates("other",box.Id,DateTime.UtcNow.AddDays(-1))).Count==0);
JsonObject Payload()=>new(){["mimeType"]="text/plain",["headers"]=new JsonArray(new JsonObject{["name"]="From",["value"]="guest@example.invalid"},new JsonObject{["name"]="To",["value"]=box.Email})};
bool Eligible(JsonObject p)=>FaqMatcher.HeadersEligible(JsonSerializer.SerializeToElement(p),box.Email);
check("FAQ import accepts a single plain-text direct message",Eligible(Payload()));
foreach(var pair in new[]{("Cc","other@example.invalid"),("To","other@example.invalid"),("In-Reply-To","<prior@example.invalid>"),("Auto-Submitted","auto-replied"),("List-Id","list"),("Reply-To","other@example.invalid"),("Return-Path","<>"),("X-Auto-Response-Suppress","All")}){var p=Payload();p["headers"]!.AsArray().Add(new JsonObject{["name"]=pair.Item1,["value"]=pair.Item2});check("FAQ import rejects "+pair.Item1,!Eligible(p));}
var attachment=Payload();attachment["filename"]="details.pdf";check("FAQ import rejects attachments",!Eligible(attachment));var html=Payload();html["mimeType"]="multipart/alternative";check("FAQ import leaves HTML alternatives for staff",!Eligible(html));
}
sealed class Fixture:HttpMessageHandler
{
public string MessageId="";public string? Raw;public int Sends;public bool ExtraMessage,FailSend;
static HttpResponseMessage Json(object o)=>new(HttpStatusCode.OK){Content=new StringContent(JsonSerializer.Serialize(o),Encoding.UTF8,"application/json")};
protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage req,CancellationToken ct)
{
if(req.RequestUri!.AbsoluteUri=="https://oauth2.googleapis.com/token")return Json(new{access_token="fake"});
if(req.RequestUri.Host=="gmail.googleapis.com"&&req.RequestUri.AbsolutePath.Contains("/threads/"))return Json(new{messages=ExtraMessage?new[]{new{id=MessageId,labelIds=new[]{"INBOX"}},new{id="staff-reply",labelIds=new[]{"SENT"}}}:new[]{new{id=MessageId,labelIds=new[]{"INBOX"}}}});
if(req.RequestUri.AbsoluteUri=="https://gmail.googleapis.com/gmail/v1/users/me/messages/send"){Sends++;using var j=JsonDocument.Parse(await req.Content!.ReadAsStringAsync(ct));Raw=j.RootElement.GetProperty("raw").GetString();if(FailSend)throw new TaskCanceledException();return Json(new{id="sent"});}
throw new InvalidOperationException("Unexpected fixture request.");
}
}
}
+78
View File
@@ -0,0 +1,78 @@
using GuestOps.Web;
using Microsoft.AspNetCore.DataProtection;
using Microsoft.Extensions.Configuration;
using System.Net;
using System.Text;
using System.Text.Json;
public static class MailboxTests
{
public static async Task Run(Action<string,bool> check,IStore store)
{
var config=new ConfigurationBuilder().AddInMemoryCollection(new Dictionary<string,string?>{{"Google:ClientId","fixture-client"},{"Google:ClientSecret","fixture-secret"},{"Google:EnableSending","true"}}).Build();
var protection=new EphemeralDataProtectionProvider();var protector=protection.CreateProtector("GoogleMailbox.refresh.v1");
var fixture=new Fixture();var google=new GoogleMailbox(new HttpClient(fixture),config,store,protection);
var hotel=new Hotel{StaffSendingEnabled=true};hotel.HotelId=hotel.Id;await store.Insert(hotel);
async Task<Mailbox> NewBox(){var box=new Mailbox{HotelId=hotel.Id,Email=Guid.NewGuid().ToString("N")+"@example.invalid",ProtectedRefreshToken=protector.Protect("fixture-refresh"),CanSend=true};await store.Insert(box);fixture.Email=box.Email;return box;}
async Task<Mailbox> Reload(Mailbox box)=>(await store.Get<Mailbox>(box.HotelId,box.Id))!;
async Task Failure(Mailbox box){try{await google.Sync(box,default);}catch(Exception ex){await google.RecordFailure(box,ex);}}
var box=await NewBox();fixture.NextPage=true;await google.Sync(box,default);var saved=await Reload(box);
check("Gmail import skips messages deleted after listing",(await store.List<Conversation>(hotel.Id)).Count==1);
check("Gmail page checkpoint and health persist",saved.PageToken=="fixture-next"&&saved.LastSyncAt!=null&&saved.LastAttemptAt!=null);
fixture.NextPage=false;await google.Sync(saved,default);saved=await Reload(box);
check("Replayed Gmail page does not duplicate imported messages",(await store.List<Conversation>(hotel.Id)).Count==1&&saved.PageToken=="");
box=await NewBox();box.PageToken="expired-page";box.Version++;await store.Replace(box.HotelId,box.Id,0,box);var start=box.WindowStart;fixture.BadPage=true;await google.Sync(box,default);saved=await Reload(box);
check("Rejected Gmail page restarts same window without advancing",saved.PageToken==""&&Math.Abs((saved.WindowStart-start).TotalMilliseconds)<1&&saved.SyncErrorCode=="CheckpointRestart"&&saved.NextAttemptAt>DateTime.UtcNow);fixture.BadPage=false;
box=await NewBox();fixture.TokenError="invalid_grant";await Failure(box);saved=await Reload(box);
check("Revoked Google refresh token requires reconnection",saved.Status=="NeedsReconnect"&&saved.SyncErrorCode=="ReconnectRequired");var requests=fixture.Requests;await google.Sync(saved,default);
check("Revoked connection does not keep requesting Google tokens",fixture.Requests==requests);fixture.TokenError="";
box=await NewBox();fixture.Throttle=true;await Failure(box);saved=await Reload(box);
check("Google rate limit schedules retry and retains connected state",saved.Status=="Connected"&&saved.NextAttemptAt>=DateTime.UtcNow.AddSeconds(110)&&saved.FailureCount==1);requests=fixture.Requests;await google.Sync(saved,default);
check("Mailbox backoff skips provider requests until due",fixture.Requests==requests);
check("Owner cannot bypass provider backoff",!await MailboxManagement.Change(store,saved,saved.Version,"retry"));fixture.Throttle=false;
box=await NewBox();fixture.TokenError="invalid_client";await Failure(box);saved=await Reload(box);check("Invalid Google client is distinguished from revoked user consent",saved.Status=="Connected"&&saved.SyncErrorCode=="Configuration"&&saved.NextAttemptAt>DateTime.UtcNow.AddMinutes(59));fixture.TokenError="";
box=await NewBox();var old=await Reload(box);await MailboxManagement.Change(store,box,box.Version,"disconnect");saved=await Reload(box);
check("Disconnect removes credentials and rotates connection identity",saved.Status=="Disconnected"&&saved.ProtectedRefreshToken==""&&!saved.CanSend&&saved.ConnectionEpoch!="");
old.SyncError="stale worker";old.PageToken="stale-page";await store.SaveSync(old);saved=await Reload(box);
check("Stale worker cannot undo disconnect or restore checkpoint",saved.Status=="Disconnected"&&saved.SyncError!="stale worker"&&saved.PageToken!="stale-page");
bool denied=false;try{await google.AccessToken(old,default);}catch(MailboxConflict){denied=true;}check("Disconnected snapshot cannot request access token",denied);
denied=false;try{await google.Connect(hotel.Id,"fixture-code",DateTime.UtcNow.AddMinutes(-5));}catch(MailboxConflict){denied=true;}check("OAuth started before disconnect cannot reconnect mailbox",denied);
var epoch=saved.ConnectionEpoch;await google.Connect(hotel.Id,"fixture-code",DateTime.UtcNow.AddSeconds(1),box.Email);saved=await Reload(box);
check("Fresh reconnect preserves mailbox ID and rotates approval identity",saved.Status=="Connected"&&saved.ConnectionEpoch!=epoch&&saved.Id==box.Id&&saved.PageToken=="");
denied=false;try{await google.Connect(hotel.Id,"fixture-code",DateTime.UtcNow.AddSeconds(1),"wrong@example.invalid");}catch(InvalidOperationException){denied=true;}check("Targeted reconnect rejects different Google account",denied);
fixture.Scope="https://www.googleapis.com/auth/gmail.send";denied=false;try{await google.Connect(hotel.Id,"fixture-code",DateTime.UtcNow.AddSeconds(1));}catch(InvalidOperationException){denied=true;}check("Connection requires granted Gmail read scope",denied);fixture.Scope=Fixture.FullScope;
denied=false;try{await google.Connect("another-hotel","fixture-code",DateTime.UtcNow.AddSeconds(1));}catch(MailboxConflict){denied=true;}check("Google mailbox cannot be reassigned to a different hotel",denied);
box=await NewBox();old=await Reload(box);check("Owner can restart an import pass",await MailboxManagement.Change(store,box,box.Version,"retry"));old.PageToken="old-inflight-page";await store.SaveSync(old);saved=await Reload(box);check("Old sync cannot overwrite explicitly restarted checkpoint",saved.PageToken==""&&saved.SyncErrorCode=="RestartQueued");
box=await NewBox();fixture.OnMessage=async()=>{var current=await Reload(box);await MailboxManagement.Change(store,current,current.Version,"disconnect");};var before=(await store.List<Conversation>(hotel.Id)).Count;await google.Sync(box,default);fixture.OnMessage=null;
check("Disconnect during message fetch prevents subsequent import",(await store.List<Conversation>(hotel.Id)).Count==before);
box=await NewBox();var conversation=new Conversation{HotelId=hotel.Id,MailboxId=box.Id,ProviderMessageId="pending",ProviderThreadId="ab123",RfcMessageId="<guest@example.invalid>",Subject="Parking",Delivery=new(){Recipient="guest@example.invalid",Body="Approved answer",MailboxEpoch="previous-connection"}};await store.Insert(conversation);await new ReplyDelivery(store,google).Process(conversation,default);
check("Reconnection does not silently send earlier queued approvals",(await store.Get<Conversation>(hotel.Id,conversation.Id))!.Delivery!.State=="Rejected"&&fixture.Sends==0);
conversation=new Conversation{HotelId=hotel.Id,MailboxId=box.Id,ProviderMessageId="during-token",ProviderThreadId="ab123",RfcMessageId="<guest@example.invalid>",Subject="Parking",Delivery=new(){Recipient="guest@example.invalid",Body="Approved answer",MailboxEpoch=box.ConnectionEpoch}};await store.Insert(conversation);fixture.OnToken=async()=>{var current=await Reload(box);await MailboxManagement.Change(store,current,current.Version,"disconnect");};await new ReplyDelivery(store,google).Process(conversation,default);fixture.OnToken=null;
check("Disconnect during token refresh blocks Gmail send",(await store.Get<Conversation>(hotel.Id,conversation.Id))!.Delivery!.State=="Rejected"&&fixture.Sends==0);
var view=JsonSerializer.Serialize(MailboxManagement.View(box));check("Mailbox health view omits credentials and page tokens",!view.Contains("ProtectedRefreshToken")&&!view.Contains("PageToken")&&!view.Contains("ConnectionEpoch"));
}
sealed class Fixture:HttpMessageHandler
{
public const string FullScope="https://www.googleapis.com/auth/gmail.readonly https://www.googleapis.com/auth/gmail.send";
public string Email="",TokenError="",Scope=FullScope;public bool NextPage,BadPage,Throttle;public int Requests,Sends;public Func<Task>? OnMessage,OnToken;
static HttpResponseMessage Json(object value,HttpStatusCode status=HttpStatusCode.OK)=>new(status){Content=new StringContent(JsonSerializer.Serialize(value),Encoding.UTF8,"application/json")};
protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage request,CancellationToken ct)
{
Requests++;var path=request.RequestUri!.AbsolutePath;
if(path=="/token") {if(OnToken!=null)await OnToken();return TokenError!=""?Json(new{error=TokenError,error_description="fixture-secret-never-display"},HttpStatusCode.BadRequest):Json(new{access_token="fixture-access",refresh_token="fixture-new-refresh",scope=Scope});}
if(path.EndsWith("/profile"))return Json(new{emailAddress=Email});
if(path.EndsWith("/messages"))
{
if(Throttle){var result=Json(new{error=new{code=429}},HttpStatusCode.TooManyRequests);result.Headers.RetryAfter=new(TimeSpan.FromSeconds(120));return result;}
if(BadPage&&request.RequestUri.Query.Contains("pageToken="))return Json(new{error=new{code=400}},HttpStatusCode.BadRequest);
return NextPage?Json(new{messages=new[]{new{id="deleted"},new{id="fixture-message"}},nextPageToken="fixture-next"}):Json(new{messages=new[]{new{id="deleted"},new{id="fixture-message"}}});
}
if(path.EndsWith("/messages/deleted"))return Json(new{error=new{code=404}},HttpStatusCode.NotFound);
if(path.EndsWith("/messages/fixture-message"))
{
if(OnMessage!=null)await OnMessage();return Json(new{id="fixture-message",threadId="ab123",internalDate=DateTimeOffset.UtcNow.ToUnixTimeMilliseconds().ToString(),payload=new{mimeType="text/plain",headers=new[]{new{name="From",value="guest@example.invalid"},new{name="To",value=Email},new{name="Subject",value="Parking"},new{name="Message-ID",value="<fixture@example.invalid>"}},body=new{data=Convert.ToBase64String(Encoding.UTF8.GetBytes("Is parking available?"))}}});
}
if(path.EndsWith("/messages/send")){Sends++;return Json(new{id="sent"});}
throw new InvalidOperationException("Unexpected fixture request.");
}
}
}
+82
View File
@@ -0,0 +1,82 @@
using GuestOps.Web;
using Microsoft.Extensions.Configuration;
using System.Net;
using System.Text;
using System.Text.Json.Nodes;
public static class PaymentTests
{
public static async Task Run(Action<string,bool> check,IStore store)
{
var hotel=new Hotel{PaymentsEnabled=true};hotel.HotelId=hotel.Id;await store.Insert(hotel);
var prefix="Payments:Hotels:"+hotel.Id+":";
var config=new ConfigurationBuilder().AddInMemoryCollection(new Dictionary<string,string?>{{prefix+"BaseUrl","https://sandbox.nmi.com"},{prefix+"MerchantAccount","test-merchant"},{prefix+"SecurityKey","fake-test-key"},{prefix+"CreatesEnabled","true"}}).Build();
var handler=new Fixture();var work=new PaymentWork(store,new NmiInvoices(new HttpClient(handler)),config);
int counter=0;
Task<PaymentRequest> Propose()=>work.Propose(hotel.Id,"owner",new("TEST-"+(++counter),"guest@example.invalid","Booking deposit",80.25m,"GBP"));
var p=await Propose();
check("Payment proposal is durable without contacting NMI",handler.Posts==0&&handler.Reads==0&&(await store.Get<PaymentRequest>(hotel.Id,p.Id))?.Amount==80.25m);
check("Duplicate payment reference is rejected",await Blocked(()=>work.Propose(hotel.Id,"owner",new(p.Reference.ToLowerInvariant(),p.Email,p.Description,p.Amount,p.Currency))));
check("Other hotels cannot read payment requests",await store.Get<PaymentRequest>("other",p.Id)==null);
check("Currency and fractional penny amounts are rejected",await Blocked(()=>work.Propose(hotel.Id,"owner",new("BAD","guest@example.invalid","Deposit",1.001m,"GBP")))&&await Blocked(()=>work.Propose(hotel.Id,"owner",new("BAD","guest@example.invalid","Deposit",1m,"JPY"))));
check("Payment email injection and display-name addresses are rejected",await Blocked(()=>work.Propose(hotel.Id,"owner",new("BAD","Guest <guest@example.invalid>","Deposit",1m,"GBP")))&&await Blocked(()=>work.Propose(hotel.Id,"owner",new("BAD","guest@example.invalid\r\nBcc: other@example.invalid","Deposit",1m,"GBP"))));
check("Creating an invoice requires email and amount approval",await Blocked(()=>work.Create(p,0,"owner",false,default))&&handler.Posts==0);
check("Payment approval rejects stale versions",await Blocked(()=>work.Create(p,5,"owner",true,default))&&handler.Posts==0);
var one=(await store.Get<PaymentRequest>(hotel.Id,p.Id))!;var two=(await store.Get<PaymentRequest>(hotel.Id,p.Id))!;
await Task.WhenAll(Blocked(()=>work.Create(one,0,"owner",true,default)),Blocked(()=>work.Create(two,0,"owner",true,default)));
p=(await store.Get<PaymentRequest>(hotel.Id,p.Id))!;
check("Concurrent payment approvals create one invoice",handler.Posts==1&&p.State=="Open");
check("NMI payload preserves exact amount and correlation",handler.Last!["amount"]!.GetValue<decimal>()==80.25m&&handler.Last["currency"]!.GetValue<string>()=="GBP"&&handler.Last["order_details"]!["order_id"]!.GetValue<string>()==p.Id);
check("Invoice creation never calls a separate email endpoint",handler.Paths.All(x=>!x.EndsWith("/send")));
check("Completed invoice creation cannot be replayed",await Blocked(()=>work.Create(p,p.Version,"owner",true,default))&&handler.Posts==1);
handler.Invoice!["status"]="partially_paid";p=await work.Check(p,p.Version,default);check("Partial invoice remains partial",p.State=="Partial");
handler.Invoice["status"]="paid";p=await work.Check(p,p.Version,default);check("Matching NMI invoice can be observed paid",p.State=="Paid"&&p.CheckedAt!=null);
handler.Invoice["amount"]="80.24";p=await work.Check(p,p.Version,default);check("Paid status cannot bypass amount verification",p.State=="NeedsReview");handler.Invoice["amount"]="80.25";
handler.Invoice["currency"]="USD";p=await work.Check(p,p.Version,default);check("Paid status cannot bypass currency verification",p.State=="NeedsReview");handler.Invoice["currency"]="GBP";
handler.Invoice["billing_address"]!["email"]="other@example.invalid";p=await work.Check(p,p.Version,default);check("Payment recipient mismatch stays held",p.State=="NeedsReview");handler.Invoice["billing_address"]!["email"]="guest@example.invalid";
handler.Invoice["order_details"]!["order_id"]="other-request";p=await work.Check(p,p.Version,default);check("Payment order identity mismatch stays held",p.State=="NeedsReview");handler.Invoice["order_details"]!["order_id"]=p.Id;
handler.Invoice["id"]=99999;p=await work.Check(p,p.Version,default);check("Payment invoice ID mismatch stays held",p.State=="NeedsReview");handler.Invoice["id"]=int.Parse(p.InvoiceId);
handler.Invoice["status"]="unknown";p=await work.Check(p,p.Version,default);check("Unknown invoice status is not accepted",p.State=="NeedsReview");handler.Invoice["status"]="paid";
config[prefix+"CreatesEnabled"]="false";p=await work.Check(p,p.Version,default);check("Read-only payment verification works with creation disabled",p.State=="Paid");config[prefix+"CreatesEnabled"]="true";
config[prefix+"SecurityKey"]="rotated-fake-key";p=await work.Check(p,p.Version,default);check("Key rotation preserves same-merchant reconciliation",p.State=="Paid");
config[prefix+"MerchantAccount"]="different-merchant";check("Changed merchant binding blocks payment reconciliation",await Blocked(()=>work.Check(p,p.Version,default)));config[prefix+"MerchantAccount"]="test-merchant";
p=await Propose();handler.TimeoutAfterCreate=true;p=await work.Create(p,0,"owner",true,default);handler.TimeoutAfterCreate=false;int posts=handler.Posts;
check("Timed-out invoice creation is held without retry",p.State=="NeedsReview"&&p.InvoiceId==""&&await Blocked(()=>work.Create(p,p.Version,"owner",true,default))&&handler.Posts==posts);
handler.DuplicateSearch=true;p=await work.Check(p,p.Version,default);check("Ambiguous invoice recovery stays held",p.State=="NeedsReview");handler.DuplicateSearch=false;
handler.IncompleteSearch=true;p=await work.Check(p,p.Version,default);check("Incomplete invoice pagination cannot reconcile",p.State=="NeedsReview");handler.IncompleteSearch=false;
handler.EmptySearch=true;p=await work.Check(p,p.Version,default);check("Missing invoice recovery never authorizes another creation",p.State=="NeedsReview"&&handler.Posts==posts);handler.EmptySearch=false;
p=await work.Check(p,p.Version,default);check("Lost create response reconciles by exact order ID with reads only",p.State=="Open"&&p.InvoiceId.Length>0&&handler.Posts==posts);
handler.FailRead=true;p=await work.Check(p,p.Version,default);check("Provider read failure records a held state",p.State=="NeedsReview");handler.FailRead=false;
p=await Propose();handler.TimeoutAfterCreate=true;p=await work.Create(p,0,"owner",true,default);handler.TimeoutAfterCreate=false;
var v=p.Version;p.State="Creating";p.UpdatedAt=DateTime.UtcNow;p.Version++;await store.Replace(hotel.Id,p.Id,v,p);
check("Interrupted invoice is not reconciled during active deadline",await Blocked(()=>work.Check(p,p.Version,default)));
v=p.Version;p.UpdatedAt=DateTime.UtcNow.AddMinutes(-6);p.Version++;await store.Replace(hotel.Id,p.Id,v,p);p=await work.Check(p,p.Version,default);check("Interrupted invoice can reconcile after restart",p.State=="Open");
p=await Propose();p=await work.Cancel(p,0);check("Only unsubmitted payment proposals can be cancelled",p.State=="Cancelled"&&await Blocked(()=>work.Create(p,p.Version,"owner",true,default)));
p=await Propose();p.ExpiresAt=DateTime.UtcNow.AddSeconds(-1);check("Expired payment approval is blocked",await Blocked(()=>work.Create(p,0,"owner",true,default)));
p=await Propose();hotel.PaymentsEnabled=false;hotel.Version++;await store.Replace(hotel.Id,hotel.Id,hotel.Version-1,hotel);check("Hotel payment stop control blocks invoice creation",await Blocked(()=>work.Create(p,0,"owner",true,default)));
check("Unconfigured hotel cannot use another merchant",NmiProfile.Read(config,Guid.NewGuid().ToString("N"))==null);
config[prefix+"BaseUrl"]="https://evil.example.invalid";check("NMI origin is restricted to known provider hosts",await Blocked(()=>Task.FromResult(NmiProfile.Read(config,hotel.Id))));
}
static async Task<bool> Blocked(Func<Task> action){try{await action();return false;}catch(PaymentInvalid){return true;}catch(PaymentConflict){return true;}}
sealed class Fixture:HttpMessageHandler
{
public int Posts,Reads;public bool TimeoutAfterCreate,DuplicateSearch,IncompleteSearch,EmptySearch,FailRead;
public JsonNode? Last,Invoice;public List<string> Paths=[];
protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage request,CancellationToken ct)
{
if(request.RequestUri?.Host!="sandbox.nmi.com")throw new InvalidOperationException("Only fake NMI requests are permitted by this handler.");
var path=request.RequestUri.AbsolutePath;Paths.Add(path);
if(request.Method==HttpMethod.Post)
{
if(path!="/api/v5/invoices")throw new InvalidOperationException("Unexpected external write.");
Posts++;Last=JsonNode.Parse(await request.Content!.ReadAsStringAsync(ct));
Invoice=new JsonObject{["object"]="invoice",["id"]=1000+Posts,["status"]="open",["amount"]=Last!["amount"]!.ToString(),["currency"]=Last["currency"]!.DeepClone(),["billing_address"]=Last["billing_address"]!.DeepClone(),["order_details"]=Last["order_details"]!.DeepClone()};
if(TimeoutAfterCreate)throw new TaskCanceledException("Simulated lost response");return Response(Invoice);
}
if(request.Method!=HttpMethod.Get)throw new InvalidOperationException("Unexpected external mutation.");Reads++;
if(FailRead)return new(HttpStatusCode.ServiceUnavailable);
if(path=="/api/v5/invoices")return Response(new JsonObject{["invoices"]=EmptySearch?new JsonArray():DuplicateSearch?new JsonArray(Invoice!.DeepClone(),Invoice!.DeepClone()):new JsonArray(Invoice!.DeepClone()),["next_cursor"]=IncompleteSearch?123:null});
return Response(Invoice!);
}
static HttpResponseMessage Response(JsonNode n)=>new(HttpStatusCode.OK){Content=new StringContent(n.ToJsonString(),Encoding.UTF8,"application/json")};
}
}
+114
View File
@@ -0,0 +1,114 @@
using GuestOps.Web;
using Microsoft.Extensions.Configuration;
using System.Net;
using System.Text;
using System.Text.Json;
using System.Text.Json.Nodes;
static class PmsTests
{
public static async Task Run(Action<string,bool> check,IStore store)
{
var hotel=new Hotel{PmsUpdatesEnabled=true};hotel.HotelId=hotel.Id;await store.Insert(hotel);
var prefix="Pms:Hotels:"+hotel.Id+":";
var config=new ConfigurationBuilder().AddInMemoryCollection(new Dictionary<string,string?>{[prefix+"BaseUrl"]="https://ohip.example.invalid",[prefix+"HotelCode"]="TEST01",[prefix+"ClientId"]="client",[prefix+"ClientSecret"]="fixture-secret",[prefix+"AppKey"]="fixture-app-key",[prefix+"WritesEnabled"]="true"}).Build();
var handler=new Fixture();var tokens=new OhipTokens();var client=new OhipClient(new HttpClient(handler),tokens);var work=new PmsWork(store,client,config);
async Task<bool> Blocked(Func<Task> action){try{await action();return false;}catch(PmsConflict){return true;}catch(PmsInvalid){return true;}}
var snapshot=await work.Lookup(hotel.Id,"CONF123",default);
check("OHIP exact lookup returns typed reservation and primary guest",snapshot.ReservationId=="RES123"&&snapshot.GuestName=="Alex Guest"&&snapshot.Arrival=="2030-10-12");
await work.Lookup(hotel.Id,"CONF123",default);check("OHIP access token is cached within the hotel binding",handler.TokenCalls==1);
handler.WrongDetailId=true;check("OHIP mismatched detail identity fails closed",await Blocked(()=>work.Lookup(hotel.Id,"CONF123",default)));handler.WrongDetailId=false;
handler.Ambiguous=true;check("OHIP ambiguous exact confirmations are rejected",await Blocked(()=>work.Lookup(hotel.Id,"CONF123",default)));handler.Ambiguous=false;
handler.HasMore=true;check("OHIP incomplete search page is not assumed unique",await Blocked(()=>work.Lookup(hotel.Id,"CONF123",default)));handler.HasMore=false;
handler.WrongProperty=true;check("OHIP foreign property response is rejected",await Blocked(()=>work.Lookup(hotel.Id,"CONF123",default)));handler.WrongProperty=false;
check("Lookup validates confirmation before provider access",await Blocked(()=>work.Lookup(hotel.Id,"x&hotelId=OTHER",default)));
var proposal=await work.Propose(hotel.Id,"owner",snapshot,new(snapshot.Id,"AddNote","","","Guest arrives late."));
check("PMS proposal is durable without an external write",handler.Writes==0&&(await store.Get<PmsChange>(hotel.Id,proposal.Id))?.State=="Review");
check("One active proposal per hotel reservation",await Blocked(()=>work.Propose(hotel.Id,"owner",snapshot,new(snapshot.Id,"AddNote","","","Duplicate"))));
check("Another hotel cannot read pending PMS changes",await store.Get<PmsChange>("other",proposal.Id)==null);
check("PMS approval rejects stale version",await Blocked(()=>work.Apply(proposal,3,"owner",false,default))&&handler.Writes==0);
var one=(await store.Get<PmsChange>(hotel.Id,proposal.Id))!;var two=(await store.Get<PmsChange>(hotel.Id,proposal.Id))!;
await Task.WhenAll(Blocked(()=>work.Apply(one,0,"owner",false,default)),Blocked(()=>work.Apply(two,0,"owner",false,default)));
var applied=(await store.Get<PmsChange>(hotel.Id,proposal.Id))!;
check("Concurrent approval submits one PMS write",handler.Writes==1&&applied.State=="Applied");
var payload=JsonNode.Parse(handler.LastPayload!)!;
check("OHIP mutation uses documented PUT wrapper and preserves prior notes",handler.LastMethod=="PUT"&&payload["reservations"]![0]!["hotelId"]!.GetValue<string>()=="TEST01"&&payload["reservations"]![0]!["comments"]!.AsArray().Count==2&&payload["reservations"]![0]!["comments"]![0]!["comment"]!["text"]!["value"]!.GetValue<string>()=="Original note");
check("Completed PMS operation cannot be replayed",await Blocked(()=>work.Apply(applied,applied.Version,"owner",false,default))&&handler.Writes==1);
snapshot=await work.Lookup(hotel.Id,"CONF123",default);
var dates=await work.Propose(hotel.Id,"owner",snapshot,new(snapshot.Id,"StayDates","2030-10-15","2030-10-18",""));
check("Date changes require availability and price acknowledgement",await Blocked(()=>work.Apply(dates,0,"owner",false,default))&&handler.Writes==1);
handler.Current["lastModifyDateTime"]="2030-01-02T12:00:00";
var stale=await work.Apply(dates,0,"owner",true,default);
check("Fresh preflight blocks a changed PMS reservation",stale.State=="NotApplied"&&handler.Writes==1);
snapshot=await work.Lookup(hotel.Id,"CONF123",default);
dates=await work.Propose(hotel.Id,"owner",snapshot,new(snapshot.Id,"StayDates","2030-10-15","2030-10-18",""));
var moved=await work.Apply(dates,0,"owner",true,default);
check("Stay date update is verified by a fresh PMS read",moved.State=="Applied"&&moved.After?.Arrival=="2030-10-15"&&handler.Writes==2);
check("Date update does not invent rates or use forced overlay",!handler.LastPayload!.Contains("roomRates")&&!handler.LastPayload.Contains("reservationNotification"));
snapshot=await work.Lookup(hotel.Id,"CONF123",default);
var uncertain=await work.Propose(hotel.Id,"owner",snapshot,new(snapshot.Id,"AddNote","","","Test uncertain result"));
handler.TimeoutAfterWrite=true;uncertain=await work.Apply(uncertain,0,"owner",false,default);handler.TimeoutAfterWrite=false;int writes=handler.Writes;
check("Uncertain PMS timeout is held without replay",uncertain.State=="NeedsReview"&&await Blocked(()=>work.Apply(uncertain,uncertain.Version,"owner",false,default))&&handler.Writes==writes);
check("Uncertain PMS operation blocks a replacement proposal",await Blocked(()=>work.Propose(hotel.Id,"owner",snapshot,new(snapshot.Id,"AddNote","","","Replacement"))));
var verified=await work.Verify(uncertain,uncertain.Version,default);
check("PMS reconciliation reads state without issuing a write",verified.State=="Applied"&&handler.Writes==writes);
snapshot=await work.Lookup(hotel.Id,"CONF123",default);
var noEffect=await work.Propose(hotel.Id,"owner",snapshot,new(snapshot.Id,"AddNote","","","Missing note"));
handler.IgnoreWrite=true;noEffect=await work.Apply(noEffect,0,"owner",false,default);handler.IgnoreWrite=false;
check("HTTP success without intended PMS state requires review",noEffect.State=="NeedsReview");
writes=handler.Writes;var held=await work.Verify(noEffect,noEffect.Version,default);check("Unconfirmed reconciliation stays held",held.State=="NeedsReview"&&handler.Writes==writes);
config[prefix+"WritesEnabled"]="false";held=await work.Verify(held,held.Version,default);check("PMS reconciliation remains available with server writes disabled",held.State=="NeedsReview"&&handler.Writes==writes);config[prefix+"WritesEnabled"]="true";
// A different reservation identity allows independent recovery tests.
handler.ReservationId="RES456";handler.Current["reservationIdList"]![0]!["id"]="RES456";
snapshot=await work.Lookup(hotel.Id,"CONF123",default);
var interrupted=await work.Propose(hotel.Id,"owner",snapshot,new(snapshot.Id,"AddNote","","","Interrupted note"));
interrupted.State="Applying";interrupted.UpdatedAt=DateTime.UtcNow.AddMinutes(-6);interrupted.Version=1;await store.Replace(hotel.Id,interrupted.Id,0,interrupted);
var recovered=await work.Verify((await store.Get<PmsChange>(hotel.Id,interrupted.Id))!,1,default);
check("Interrupted PMS change is only reconciled after restart",recovered.State=="NeedsReview"&&handler.Writes==writes);
handler.ReservationId="RES789";handler.Current["reservationIdList"]![0]!["id"]="RES789";
snapshot=await work.Lookup(hotel.Id,"CONF123",default);
var cancelled=await work.Propose(hotel.Id,"owner",snapshot,new(snapshot.Id,"AddNote","","","Cancel me"));cancelled=await work.Cancel(cancelled,0);
check("Unapplied proposal can be cancelled without PMS write",cancelled.State=="Cancelled"&&handler.Writes==writes);
var expired=await work.Propose(hotel.Id,"owner",snapshot,new(snapshot.Id,"AddNote","","","Expired"));expired.ExpiresAt=DateTime.UtcNow.AddMinutes(-1);expired.Version=1;await store.Replace(hotel.Id,expired.Id,0,expired);
check("Expired PMS approval is blocked",await Blocked(()=>work.Apply(expired,1,"owner",false,default)));await work.Cancel(expired,1);
hotel.PmsUpdatesEnabled=false;hotel.Version=1;await store.Replace(hotel.Id,hotel.Id,0,hotel);
var disabled=await work.Propose(hotel.Id,"owner",snapshot,new(snapshot.Id,"AddNote","","","Disabled"));check("Hotel PMS stop control blocks writes",await Blocked(()=>work.Apply(disabled,0,"owner",false,default))&&handler.Writes==writes);
var profile=work.Profile(hotel.Id);config[prefix+"ClientSecret"]="rotated-fixture";
check("OHIP credential rotation changes connection identity",work.Profile(hotel.Id).Revision!=profile.Revision);
await client.Lookup(hotel.Id,work.Profile(hotel.Id),"CONF123",default);check("Rotated OHIP credentials do not reuse cached token",handler.TokenCalls==2);
check("Missing hotel binding never uses another hotel credentials",OhipProfile.Read(config,Guid.NewGuid().ToString("N"))==null);
config[prefix+"BaseUrl"]="http://127.0.0.1";check("OHIP configuration rejects insecure local origins",await Blocked(()=>{work.Profile(hotel.Id);return Task.CompletedTask;}));
}
sealed class Fixture:HttpMessageHandler
{
public string ReservationId="RES123";public int Writes,TokenCalls;public bool WrongDetailId,WrongProperty,Ambiguous,HasMore,TimeoutAfterWrite,IgnoreWrite;public string? LastPayload,LastMethod;
public JsonNode Current=JsonNode.Parse("""
{"reservationIdList":[{"id":"RES123","type":"Reservation"},{"id":"CONF123","type":"Confirmation"}],"hotelId":"TEST01","reservationStatus":"Reserved","lastModifyDateTime":"2030-01-01T12:00:00","roomStay":{"arrivalDate":"2030-10-12","departureDate":"2030-10-14","roomRates":[{"roomType":"KING"}],"total":{"amountAfterTax":240,"currencyCode":"GBP"}},"reservationGuests":[{"primary":true,"profileInfo":{"profile":{"customer":{"personName":[{"givenName":"Alex","surname":"Guest","nameType":"Primary"}]}}}}],"comments":[{"id":"NOTE1","type":"Comment","comment":{"text":{"value":"Original note"},"type":"RESERVATION","notificationLocation":"GEN","internal":true}}]}
""")!;
static HttpResponseMessage Json(object value)=>new(HttpStatusCode.OK){Content=new StringContent(JsonSerializer.Serialize(value),Encoding.UTF8,"application/json")};
protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage request,CancellationToken ct)
{
if(request.RequestUri!.Host!="ohip.example.invalid")throw new Exception("Fixture cannot access real OHIP");
if(request.RequestUri.AbsolutePath=="/oauth/v1/tokens"){TokenCalls++;return Json(new{access_token="fixture-token",expires_in=3600});}
if(!request.Headers.TryGetValues("x-hotelid",out var codes)||codes.Single()!="TEST01")throw new Exception("Wrong hotel header");
if(request.Method==HttpMethod.Put)
{
Writes++;LastMethod=request.Method.Method;LastPayload=await request.Content!.ReadAsStringAsync(ct);
if(!IgnoreWrite)
{
var update=JsonNode.Parse(LastPayload)!["reservations"]![0]!;
if(update["comments"] is {} comments)Current["comments"]=comments.DeepClone();
if(update["roomStay"] is {} stay){Current["roomStay"]!["arrivalDate"]=stay["arrivalDate"]!.DeepClone();Current["roomStay"]!["departureDate"]=stay["departureDate"]!.DeepClone();}
Current["lastModifyDateTime"]="2030-01-03T12:00:"+Writes.ToString("00");
}
if(TimeoutAfterWrite)throw new TaskCanceledException("Fixture timeout after provider committed update");
return Json(new{});
}
var row=Current.DeepClone();
if(WrongDetailId&&request.RequestUri.AbsolutePath.EndsWith('/'+ReservationId))row["reservationIdList"]![0]!["id"]="WRONG";
if(WrongProperty)row["hotelId"]="OTHER";
var rows=new JsonArray(row);if(Ambiguous)rows.Add(row.DeepClone());
return Json(new JsonObject{["reservations"]=new JsonObject{["reservation"]=rows,["hasMore"]=HasMore}});
}
}
}
+58
View File
@@ -15,6 +15,19 @@ IStore store = uri == null ? new PreviewStore() : new MongoStore(new Configurati
await store.Initialize();
try
{
var proofProvider=new Microsoft.AspNetCore.DataProtection.EphemeralDataProtectionProvider();
var proof=BackupProbe.Create(proofProvider);
Check("Backup proof decrypts with the original key provider",BackupProbe.Verify(proofProvider,proof));
bool wrongKeys=false;try{BackupProbe.Verify(new Microsoft.AspNetCore.DataProtection.EphemeralDataProtectionProvider(),proof);}catch(System.Security.Cryptography.CryptographicException){wrongKeys=true;}
Check("Backup proof rejects unrelated encryption keys",wrongKeys);
await store.Ping();
if(uri!=null){await store.RecordWorkerHeartbeat();Check("Worker heartbeat persists in MongoDB",await store.WorkerLastSeen()>DateTime.UtcNow.AddMinutes(-1));}
await MailboxTests.Run(Check, store);
await TeamTests.Run(Check, store);
await ReplyTests.Run(Check, store);
await PmsTests.Run(Check, store);
await PaymentTests.Run(Check, store);
await AutoReplyTests.Run(Check, store);
var a = new Hotel { Name = "Hotel A" }; a.HotelId = a.Id;
var b = new Hotel { Name = "Hotel B" }; b.HotelId = b.Id;
await store.Insert(a); await store.Insert(b);
@@ -49,6 +62,10 @@ try
oldMailbox!.SyncError = "stale worker failure"; await store.SaveSync(oldMailbox);
var newMailbox = await store.Get<Mailbox>(a.Id, mailbox.Id);
Check("Stale worker cannot overwrite reconnected credentials", newMailbox?.ProtectedRefreshToken == "new-protected-token" && newMailbox.SyncError == "");
await new MongoClient(uri).GetDatabase(dbName).GetCollection<Mailbox>("mailbox").UpdateOneAsync(x=>x.Id==mailbox.Id,Builders<Mailbox>.Update.Unset(x=>x.Version));
var legacy=(await store.Get<Mailbox>(a.Id,mailbox.Id))!;legacy.SyncError="Legacy sync health";await store.SaveSync(legacy);
Check("Pre-migration mailboxes accept guarded health updates",(await store.Get<Mailbox>(a.Id,mailbox.Id))?.SyncError=="Legacy sync health");
Check("Pre-migration mailbox can be disconnected with version zero",await MailboxManagement.Change(store,legacy,0,"disconnect"));
}
var parsed = AiExtractionPrompt.BuildRowsFromJson("{\"action\":\"CreateBooking\",\"first_name\":\"Guest {test}\"}", new ParsedBooking());
Check("Migrated parser preserves braces in JSON strings", parsed.Count > 0 && parsed[0].GuestFirstName == "Guest {test}");
@@ -63,17 +80,53 @@ try
async Task<JsonElement> Read(HttpClient h,string path) => JsonDocument.Parse(await h.GetStringAsync(path)).RootElement.Clone();
async Task SetCsrf(HttpClient h) { var s=await Read(h,"/api/session");h.DefaultRequestHeaders.Remove("X-CSRF-TOKEN");h.DefaultRequestHeaders.Add("X-CSRF-TOKEN",s.GetProperty("csrfToken").GetString()); }
Check("Anonymous inbox access blocked", (await one.GetAsync("/api/conversations")).StatusCode == HttpStatusCode.Unauthorized);
Check("Anonymous readiness returns only status",(await Read(one,"/health/ready")).GetRawText()=="{\"status\":\"ready\"}");
Check("Unsafe requests require CSRF token", (await one.PostAsJsonAsync("/api/preview/start",new {})).StatusCode == HttpStatusCode.BadRequest);
await SetCsrf(one); await SetCsrf(two);
Check("Preview creates signed-in workspace", (await one.PostAsJsonAsync("/api/preview/start",new {})).IsSuccessStatusCode);
await two.PostAsJsonAsync("/api/preview/start",new {}); await SetCsrf(one); await SetCsrf(two);
var h1=await Read(one,"/api/hotel");var h2=await Read(two,"/api/hotel");
Check("Different preview sessions have different hotels", h1.GetProperty("id").GetString()!=h2.GetProperty("id").GetString());
var health=await Read(one,"/api/operations");
Check("Health overview is hotel scoped and labels preview worker",health.GetProperty("mailboxes").GetProperty("total").GetInt32()==1&&health.GetProperty("worker").GetProperty("state").GetString()=="Preview");
var messages=await Read(one,"/api/conversations"); var id=messages[0].GetProperty("id").GetString();
Check("Guessed message ID cannot be edited across hotels", (await two.PutAsJsonAsync($"/api/conversations/{id}/draft",new {draft="stolen",version=0})).StatusCode==HttpStatusCode.NotFound);
Check("Draft save succeeds", (await one.PutAsJsonAsync($"/api/conversations/{id}/draft",new {draft="Hello guest",version=0})).IsSuccessStatusCode);
Check("Stale API draft save returns conflict", (await one.PutAsJsonAsync($"/api/conversations/{id}/draft",new {draft="old",version=0})).StatusCode==HttpStatusCode.Conflict);
Check("Preview cannot connect real Gmail", !(await one.PostAsJsonAsync("/api/integrations/google/connect",new {})).IsSuccessStatusCode);
var boxes=await Read(one,"/api/mailboxes");var boxId=boxes.GetProperty("items")[0].GetProperty("id").GetString();
Check("Mailbox health includes recovery state without secrets",boxes.GetProperty("items")[0].GetProperty("syncErrorCode").GetString()=="ReconnectRequired"&&!boxes.GetRawText().Contains("protectedRefreshToken")&&!boxes.GetRawText().Contains("pageToken"));
foreach(var action in new[]{"disconnect","reconnect","retry"})Check("Other hotel cannot "+action+" a mailbox",(await two.PostAsJsonAsync($"/api/mailboxes/{boxId}/{action}",new{version=0})).StatusCode==HttpStatusCode.NotFound);
Check("Preview recovery cannot change real Google state",(await one.PostAsJsonAsync($"/api/mailboxes/{boxId}/reconnect",new{version=0})).StatusCode==HttpStatusCode.BadRequest);
Check("Preview cannot enable paid AI", (await one.PutAsJsonAsync("/api/reply-controls",new {version=0,aiDraftsEnabled=true,staffSendingEnabled=false})).StatusCode==HttpStatusCode.BadRequest);
Check("Cross-hotel reply approval is blocked", (await two.PostAsJsonAsync($"/api/conversations/{id}/send",new {version=1,recipient="guest@example.invalid"})).StatusCode==HttpStatusCode.NotFound);
Check("Cross-hotel AI generation is blocked", (await two.PostAsJsonAsync($"/api/conversations/{id}/generate",new {version=1})).StatusCode==HttpStatusCode.NotFound);
Check("Preview cannot send real mail", (await one.PostAsJsonAsync($"/api/conversations/{id}/send",new {version=1,recipient="guest@example.invalid"})).StatusCode==HttpStatusCode.BadRequest);
Check("Cross-hotel delivery status is blocked", (await two.GetAsync($"/api/conversations/{id}")).StatusCode==HttpStatusCode.NotFound);
Check("PMS status exposes no credentials", !(await one.GetStringAsync("/api/pms/status")).Contains("clientSecret"));
Check("Preview cannot access real PMS lookup", (await one.PostAsJsonAsync("/api/pms/lookup",new{confirmation="CONF123"})).StatusCode==HttpStatusCode.BadRequest);
Check("Preview cannot enable PMS updates", (await one.PutAsJsonAsync("/api/pms/controls",new{version=0,enabled=true})).StatusCode==HttpStatusCode.BadRequest);
Check("Unknown PMS snapshot cannot be proposed", (await two.PostAsJsonAsync("/api/pms/changes",new{snapshotId="foreign",kind="AddNote",arrival="",departure="",note="test"})).StatusCode==HttpStatusCode.NotFound);
Check("Unknown PMS operation cannot be applied", (await two.PostAsJsonAsync("/api/pms/changes/foreign/apply",new{version=0,availabilityAndPriceChecked=true})).StatusCode==HttpStatusCode.NotFound);
var paymentStatus=await Read(one,"/api/payments/status");
Check("Preview payment status is disabled and contains no secret", !paymentStatus.GetProperty("configured").GetBoolean()&&!paymentStatus.GetRawText().Contains("securityKey"));
Check("Preview cannot enable invoice creation",(await one.PutAsJsonAsync("/api/payments/controls",new{version=0,enabled=true})).StatusCode==HttpStatusCode.BadRequest);
Check("Preview cannot prepare a real payment",(await one.PostAsJsonAsync("/api/payments/requests",new{reference="TEST",email="guest@example.invalid",description="Deposit",amount=80,currency="GBP"})).StatusCode==HttpStatusCode.BadRequest);
var payments=await Read(one,"/api/payments/requests");var paymentId=payments[0].GetProperty("id").GetString();
Check("Foreign payment cannot be approved",(await two.PostAsJsonAsync($"/api/payments/requests/{paymentId}/create",new{version=0,emailAndAmountApproved=true})).StatusCode==HttpStatusCode.NotFound);
Check("Foreign payment cannot be reconciled",(await two.PostAsJsonAsync($"/api/payments/requests/{paymentId}/check",new{version=0})).StatusCode==HttpStatusCode.NotFound);
Check("Preview sample invoice cannot be created",(await one.PostAsJsonAsync($"/api/payments/requests/{paymentId}/create",new{version=0,emailAndAmountApproved=true})).StatusCode==HttpStatusCode.BadRequest);
var autoStatus=await Read(one,"/api/auto-replies/status");
Check("Preview cannot enable FAQ live sending",!autoStatus.GetProperty("liveConfigured").GetBoolean()&&(await one.PutAsJsonAsync("/api/auto-replies/mode",new{mode="Live",version=0,acceptanceConfirmed=true})).StatusCode==HttpStatusCode.BadRequest);
Check("FAQ test mode can be saved without sending",(await one.PutAsJsonAsync("/api/auto-replies/mode",new{mode="Test",version=0,acceptanceConfirmed=false})).IsSuccessStatusCode);
var ownKnowledge=await Read(one,"/api/knowledge");var answerId=ownKnowledge[0].GetProperty("id").GetString();
Check("FAQ rule rejects another hotel's knowledge",(await two.PutAsJsonAsync("/api/auto-replies/rules/3",new{question="Is parking available?",knowledgeId=answerId,enabled=true,version=0})).StatusCode==HttpStatusCode.BadRequest);
Check("Owner can save a reviewed FAQ rule",(await one.PutAsJsonAsync("/api/auto-replies/rules/3",new{question="Is parking available?",knowledgeId=answerId,enabled=true,version=0})).IsSuccessStatusCode);
var autoTest=await one.PostAsJsonAsync("/api/auto-replies/test",new{subject="Parking",body="Is parking available?"});
Check("FAQ content tester returns a match without a delivery",autoTest.IsSuccessStatusCode&&JsonDocument.Parse(await autoTest.Content.ReadAsStringAsync()).RootElement.GetProperty("matches").GetBoolean());
Check("FAQ rule updates reject stale versions",(await one.PutAsJsonAsync("/api/auto-replies/rules/3",new{question="Is parking available?",knowledgeId=answerId,enabled=false,version=0})).StatusCode==HttpStatusCode.Conflict);
Check("Uncertain or foreign replies cannot be released",(await two.PostAsJsonAsync($"/api/conversations/{id}/delivery/release",new{version=0})).StatusCode==HttpStatusCode.NotFound);
await TeamTests.Http(Check,one,two,baseUrl);
var cookie=(await one.GetAsync("/api/session")).Headers;
Check("Session response is not cacheable", cookie.CacheControl?.NoStore==true);
await one.PostAsJsonAsync("/api/auth/logout",new {});
@@ -86,3 +139,8 @@ finally
// This suite owns only a fresh, randomly named database under a fixed test prefix.
if (uri != null && dbName.StartsWith("guestops_test_")) await new MongoClient(uri).DropDatabaseAsync(dbName);
}
+76
View File
@@ -0,0 +1,76 @@
using GuestOps.Web;
using Microsoft.AspNetCore.DataProtection;
using Microsoft.Extensions.Configuration;
using System.Net;
using System.Text;
using System.Text.Json;
static class ReplyTests
{
public static async Task Run(Action<string,bool> check, IStore store)
{
var config = new ConfigurationBuilder().AddInMemoryCollection(new Dictionary<string,string?> { ["Google:ClientId"]="fixture-client", ["Google:ClientSecret"]="fixture-secret", ["Google:EnableSending"]="true", ["Ai:ApiKey"]="fixture-only", ["Ai:Model"]="fixture-model" }).Build();
var protection = new EphemeralDataProtectionProvider();
var hotel = new Hotel { StaffSendingEnabled=true, AiDraftsEnabled=true }; hotel.HotelId=hotel.Id; await store.Insert(hotel);
var mailbox = new Mailbox { HotelId=hotel.Id, Email=$"hotel-{hotel.Id}@example.invalid", CanSend=true, ProtectedRefreshToken=protection.CreateProtector("GoogleMailbox.refresh.v1").Protect("fixture-refresh") }; await store.Insert(mailbox);
Conversation Message()=>new() { HotelId=hotel.Id, MailboxId=mailbox.Id, ProviderMessageId=Guid.NewGuid().ToString("N"), ProviderThreadId="ab123", RfcMessageId="<guest@example.invalid>", ReplyAddress="guest@example.invalid", Subject="Parking question", Draft="Parking is available.", Delivery=new() { Recipient="guest@example.invalid", Body="Parking is available.", ApprovedBy="fixture-owner" } };
var handler=new Fixture(); var google=new GoogleMailbox(new HttpClient(handler),config,store,protection); var worker=new ReplyDelivery(store,google);
var message=Message(); await store.Insert(message);
var stale=(await store.Get<Conversation>(hotel.Id,message.Id))!;
await Task.WhenAll(worker.Process(message,default),worker.Process(stale,default));
var saved=await store.Get<Conversation>(hotel.Id,message.Id);
check("Competing workers send one approved reply only",handler.Sends==1&&saved!.Delivery!.State=="Sent");
await worker.Process(saved!,default); check("Completed delivery is never replayed",handler.Sends==1);
var raw=Encoding.UTF8.GetString(Convert.FromBase64String(handler.Raw!.Replace('-','+').Replace('_','/').PadRight((handler.Raw.Length+3)/4*4,'=')));
check("Gmail payload has stable identity and reply headers",raw.Contains(message.Delivery!.MessageId)&&raw.Contains("In-Reply-To: <guest@example.invalid>")&&handler.Thread=="ab123"&&raw.Contains("To: guest@example.invalid"));
check("Multiple or injected recipients are rejected",ReplyMime.Address("a@example.invalid,b@example.invalid")==""&&ReplyMime.Address("a@example.invalid\r\nBcc: b@example.invalid")=="");
var malicious=Message();malicious.RfcMessageId="<x>\r\nBcc: bad@example.invalid";bool blocked=false;try{ReplyMime.Build(malicious,mailbox);}catch{blocked=true;}check("Reply header injection is blocked",blocked);
handler.FailSend=true;var uncertain=Message();await store.Insert(uncertain);await worker.Process(uncertain,default);
saved=await store.Get<Conversation>(hotel.Id,uncertain.Id);int sends=handler.Sends;await worker.Process(saved!,default);
check("Timeout after send is held without retry",saved!.Delivery!.State=="NeedsReview"&&handler.Sends==sends);
handler.FailSend=false;handler.FailToken=true;var rejected=Message();await store.Insert(rejected);await worker.Process(rejected,default);
check("Token failure is recorded before any send",(await store.Get<Conversation>(hotel.Id,rejected.Id))!.Delivery!.State=="Rejected"&&handler.Sends==sends);
handler.FailToken=false;var interrupted=Message();interrupted.Delivery!.State="Sending";interrupted.Delivery.UpdatedAt=DateTime.UtcNow.AddMinutes(-6);await store.Insert(interrupted);await worker.Process(interrupted,default);
check("Interrupted send after restart requires verification",(await store.Get<Conversation>(hotel.Id,interrupted.Id))!.Delivery!.State=="NeedsReview"&&handler.Sends==sends);
check("Other hotels cannot read delivery evidence",await store.Get<Conversation>("other-hotel",interrupted.Id)==null);
var disabled=Message();hotel.StaffSendingEnabled=false;hotel.Version++;await store.Replace(hotel.Id,hotel.Id,0,hotel);await store.Insert(disabled);await worker.Process(disabled,default);
check("Hotel stop control blocks queued delivery",(await store.Get<Conversation>(hotel.Id,disabled.Id))!.Delivery!.State=="Rejected"&&handler.Sends==sends);
handler.FoundMessageId=uncertain.Delivery!.MessageId;handler.FoundRecipient=uncertain.ReplyAddress;handler.FoundFrom=mailbox.Email;
check("Uncertain delivery verifies matching Gmail sent record",await google.FindSent(uncertain,mailbox,default)=="sent-found");
handler.FoundRecipient="someone-else@example.invalid";check("Mismatched Gmail recipient cannot reconcile delivery",await google.FindSent(uncertain,mailbox,default)==null);
var knowledge=new[] { new KnowledgeEntry { Id="approved",HotelId=hotel.Id,Title="Parking",Answer="Parking is available.",Approved=true },new KnowledgeEntry { Id="unapproved",HotelId=hotel.Id,Title="Parking",Answer="SECRET DRAFT",Approved=false },new KnowledgeEntry { Id="foreign",HotelId="other-hotel",Title="Parking",Answer="OTHER HOTEL",Approved=true } };
var sources=AiDrafts.SelectSources(message,knowledge);check("AI retrieval excludes unapproved and foreign hotel answers",sources.Length==1&&sources[0].Id=="approved");
var ai=new AiDrafts(new HttpClient(handler),config);
var suggestion=await ai.Generate(message,sources,default);
check("Structured AI result preserves validated evidence",suggestion.Draft=="Parking is available."&&suggestion.SourceIds.SequenceEqual(new[]{"approved"}));
check("AI request disables storage and excludes hidden knowledge",handler.AiPayload!.Contains("\"store\":false")&&!handler.AiPayload.Contains("SECRET DRAFT")&&!handler.AiPayload.Contains("OTHER HOTEL"));
handler.AiSource="foreign";blocked=false;try{await ai.Generate(message,sources,default);}catch{blocked=true;}check("Invented AI citations fail closed",blocked);
handler.AiSource="approved";handler.AiEscalate=true;suggestion=await ai.Generate(message,sources,default);check("AI escalation never yields a sendable generated reply",suggestion.NeedsReview&&suggestion.Draft=="");
var requests=handler.AiRequests; suggestion=await ai.Generate(message,[],default);check("Missing hotel knowledge escalates without an API call",suggestion.NeedsReview&&handler.AiRequests==requests);
handler.AiIncomplete=true;blocked=false;try{await ai.Generate(message,sources,default);}catch{blocked=true;}check("Incomplete AI output cannot become a draft",blocked);
}
sealed class Fixture : HttpMessageHandler
{
public int Sends,AiRequests;public bool FailSend,FailToken,AiEscalate,AiIncomplete;public string AiSource="approved";public string? Raw,Thread,AiPayload,FoundMessageId,FoundRecipient,FoundFrom;
static HttpResponseMessage Json(object value)=>new(HttpStatusCode.OK){Content=new StringContent(JsonSerializer.Serialize(value),Encoding.UTF8,"application/json")};
protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage request,CancellationToken ct)
{
var url=request.RequestUri!.AbsoluteUri;
if(url=="https://oauth2.googleapis.com/token") return FailToken?new(HttpStatusCode.Unauthorized):Json(new{access_token="fixture-access"});
if(url=="https://gmail.googleapis.com/gmail/v1/users/me/messages/send")
{
Interlocked.Increment(ref Sends);using var json=JsonDocument.Parse(await request.Content!.ReadAsStringAsync(ct));Raw=json.RootElement.GetProperty("raw").GetString();Thread=json.RootElement.GetProperty("threadId").GetString();
if(FailSend)throw new TaskCanceledException("Simulated uncertain delivery");return Json(new{id="sent-fixture"});
}
if(url.Contains("/messages?"))return Json(new{messages=new[]{new{id="sent-found"}}});
if(url.Contains("/messages/sent-found?"))return Json(new{labelIds=new[]{"SENT"},payload=new{headers=new[]{new{name="Message-ID",value=FoundMessageId},new{name="To",value=FoundRecipient},new{name="From",value=FoundFrom}}}});
if(url=="https://api.openai.com/v1/responses")
{
AiRequests++;AiPayload=await request.Content!.ReadAsStringAsync(ct);
return Json(new{status=AiIncomplete?"incomplete":"completed",output=new[]{new{type="message",content=new[]{new{type="output_text",text=JsonSerializer.Serialize(new{draft="Parking is available.",needsReview=AiEscalate,reason="Check approved parking information.",sourceIds=new[]{AiSource}})}}}}});
}
throw new InvalidOperationException("Unexpected fixture URL: "+url);
}
}
}
+77
View File
@@ -0,0 +1,77 @@
using GuestOps.Web;
using Microsoft.AspNetCore.Identity;
using Microsoft.Extensions.Configuration;
using System.Net;
using System.Net.Http.Json;
using System.Text.Json;
public static class TeamTests
{
static string Token(AccountLinkResult link)=>link.Link.Split("#token=")[1];
public static async Task Run(Action<string,bool> check,IStore store)
{
var hotel=Guid.NewGuid().ToString("N");var email=hotel+"@example.invalid";
var config=new ConfigurationBuilder().AddInMemoryCollection(new Dictionary<string,string?>{{"PublicUrl","https://hotel.example.invalid"}}).Build();
var hasher=new PasswordHasher<StaffUser>();var service=new TeamAccounts(store,hasher,config);
var link=await service.Invite(hotel,new("Test Colleague",email));var token=Token(link);
var user=(await store.Get<StaffUser>(hotel,link.UserId))!;
check("Invitation stores hash and creates inactive Staff only",user.Role=="Staff"&&!user.Active&&user.PasswordHash==""&&user.AccountLinkHash!=token&&user.AccountLinkHash.Length==64);
check("Account link uses configured HTTPS origin and fragment",link.Link.StartsWith("https://hotel.example.invalid/account#token=")&&!link.Link.Contains('?'));
check("Token inspection rejects malformed token",await service.Inspect("bad")==null);
bool denied=false;try{await service.Invite("foreign",new("Other Colleague",email));}catch(AccountInvalid){denied=true;}check("Invitation cannot claim another hotel's account",denied);
var replacement=await service.Invite(hotel,new("Test Colleague",email));
check("Reissued invitation invalidates earlier token",await service.Inspect(token)==null);
var password="Test-only-passphrase-2026!";
denied=false;try{await service.Accept(new(Token(replacement),password,"different"));}catch(AccountInvalid){denied=true;}check("Password confirmation mismatch preserves invitation",denied&&await service.Inspect(Token(replacement))!=null);
var attempts=await Task.WhenAll(Enumerable.Range(0,4).Select(_=>service.Accept(new(Token(replacement),password,password))));
check("Concurrent invitation acceptance succeeds exactly once",attempts.Count(x=>x)==1);
user=(await store.Get<StaffUser>(hotel,link.UserId))!;
check("Accepted invitation activates hashed password and clears link",user.Active&&user.AccountLinkHash==""&&hasher.VerifyHashedPassword(user,user.PasswordHash,password)!=PasswordVerificationResult.Failed);
check("Consumed invitation cannot be reused",!await service.Accept(new(Token(replacement),password,password)));
var stamp=user.SecurityStamp;var reset=await service.ResetStaff(user,user.Version);
user=(await store.Get<StaffUser>(hotel,user.Id))!;check("Issuing reset preserves current session",TeamAccounts.SessionValid(user,stamp));
await service.Accept(new(Token(reset),password+"new",password+"new"));user=(await store.Get<StaffUser>(hotel,user.Id))!;
check("Accepted reset invalidates previous sessions",!TeamAccounts.SessionValid(user,stamp)&&TeamAccounts.SessionValid(user,user.SecurityStamp));
var stale=user.Version;reset=await service.ResetStaff(user,user.Version);user=(await store.Get<StaffUser>(hotel,user.Id))!;
check("Stale staff disable is rejected",!await service.Disable(user,stale));
check("Owner can revoke an unused recovery link",await service.Revoke(user,user.Version)&&await service.Inspect(Token(reset))==null);
user=(await store.Get<StaffUser>(hotel,user.Id))!;reset=await service.ResetStaff(user,user.Version);user=(await store.Get<StaffUser>(hotel,user.Id))!;
user.AccountLinkExpiresAt=DateTime.UtcNow.AddMinutes(-1);var v=user.Version;user.Version++;await store.Replace(hotel,user.Id,v,user);
check("Expired recovery link is rejected",await service.Inspect(Token(reset))==null);
user=(await store.Get<StaffUser>(hotel,user.Id))!;await service.Disable(user,user.Version);user=(await store.Get<StaffUser>(hotel,user.Id))!;
check("Disabled staff loses sessions",!TeamAccounts.SessionValid(user,user.SecurityStamp));
var restore=await service.Restore(user,user.Version);check("Restoration does not reactivate old password",!(await store.Get<StaffUser>(hotel,user.Id))!.Active);
check("Restoration requires a new password through single-use link",await service.Accept(new(Token(restore),password,password)));
var owner=new StaffUser{HotelId=hotel,Email="owner-"+email,Name="Owner",PasswordHash=hasher.HashPassword(new(),password)};await store.Insert(owner);
check("Team controls cannot disable owner",!await service.Disable(owner,owner.Version));
denied=false;try{await service.ResetStaff(owner,owner.Version);}catch(AccountConflict){denied=true;}check("Team controls cannot reset owner",denied);
var ownerReset=await service.RecoverOwner(owner);check("Server admin can issue owner recovery",await service.Inspect(Token(ownerReset))!=null);
var badConfig=new ConfigurationBuilder().AddInMemoryCollection(new Dictionary<string,string?>{{"PublicUrl","http://hotel.example.invalid"}}).Build();
denied=false;try{await new TeamAccounts(store,hasher,badConfig).Invite(hotel,new("No Account","bad-"+email));}catch(AccountInvalid){denied=true;}check("Untrusted public URL rejects link before inserting account",denied&&await store.FindLogin("bad-"+email)==null);
var safe=JsonSerializer.Serialize(TeamAccounts.View(user));check("Team views omit password, token hash and security stamp",!safe.Contains("Hash")&&!safe.Contains("Stamp"));
}
public static async Task Http(Action<string,bool> check,HttpClient owner,HttpClient other,string baseUrl)
{
async Task<JsonElement> Read(HttpResponseMessage response){response.EnsureSuccessStatusCode();return JsonDocument.Parse(await response.Content.ReadAsStringAsync()).RootElement.Clone();}
async Task Csrf(HttpClient c){var s=await Read(await c.GetAsync("/api/session"));c.DefaultRequestHeaders.Remove("X-CSRF-TOKEN");c.DefaultRequestHeaders.Add("X-CSRF-TOKEN",s.GetProperty("csrfToken").GetString());}
var email="staff-"+Guid.NewGuid().ToString("N")+"@example.invalid";
var invite=await Read(await owner.PostAsJsonAsync("/api/team/invite",new{name="HTTP Colleague",email}));var id=invite.GetProperty("userId").GetString();var token=invite.GetProperty("link").GetString()!.Split("#token=")[1];
using var staff=new HttpClient(new HttpClientHandler{CookieContainer=new CookieContainer(),AllowAutoRedirect=false}){BaseAddress=new Uri(baseUrl)};
check("Invitation consumption requires CSRF",(await staff.PostAsJsonAsync("/api/account-links/inspect",new{token})).StatusCode==HttpStatusCode.BadRequest);await Csrf(staff);
check("Invitation inspection works without signing in",(await staff.PostAsJsonAsync("/api/account-links/inspect",new{token})).IsSuccessStatusCode);
var password="HTTP-test-passphrase-2026!";check("Invitation acceptance works",(await staff.PostAsJsonAsync("/api/account-links/accept",new{token,password,confirmPassword=password})).IsSuccessStatusCode);
check("Invitation acceptance does not automatically sign in",(await staff.GetAsync("/api/hotel")).StatusCode==HttpStatusCode.Unauthorized);
await Csrf(staff);check("Invited colleague can sign in",(await staff.PostAsJsonAsync("/api/auth/login",new{email,password})).IsSuccessStatusCode);await Csrf(staff);
check("Staff cannot list or invite team members",(await staff.GetAsync("/api/team")).StatusCode==HttpStatusCode.Forbidden&&(await staff.PostAsJsonAsync("/api/team/invite",new{name="No",email="no@example.invalid"})).StatusCode==HttpStatusCode.Forbidden);
check("Staff cannot change hotel settings",(await staff.PutAsJsonAsync("/api/hotel",new{name="No",signature="",timezone="UTC",version=0})).StatusCode==HttpStatusCode.Forbidden);
check("Operational health is owner only",(await staff.GetAsync("/api/operations")).StatusCode==HttpStatusCode.Forbidden);
foreach(var action in new[]{"disconnect","reconnect","retry"})check("Staff cannot "+action+" mailboxes",(await staff.PostAsJsonAsync($"/api/mailboxes/unknown/{action}",new{version=0})).StatusCode==HttpStatusCode.Forbidden);
check("Foreign hotel cannot reset staff",(await other.PostAsJsonAsync($"/api/team/{id}/reset",new{version=2})).StatusCode==HttpStatusCode.NotFound);
var list=await Read(await owner.GetAsync("/api/team"));var member=list.EnumerateArray().Single(x=>x.GetProperty("id").GetString()==id);var version=member.GetProperty("version").GetInt64();
check("HTTP team listing excludes secrets",!list.GetRawText().Contains("passwordHash")&&!list.GetRawText().Contains("securityStamp")&&!list.GetRawText().Contains(token));
var reset=await Read(await owner.PostAsJsonAsync($"/api/team/{id}/reset",new{version}));token=reset.GetProperty("link").GetString()!.Split("#token=")[1];
using var recovery=new HttpClient(new HttpClientHandler{CookieContainer=new CookieContainer()}){BaseAddress=new Uri(baseUrl)};await Csrf(recovery);
check("Staff reset succeeds from separate browser",(await recovery.PostAsJsonAsync("/api/account-links/accept",new{token,password=password+"new",confirmPassword=password+"new"})).IsSuccessStatusCode);
check("Password reset invalidates existing HTTP session",(await staff.GetAsync("/api/hotel")).StatusCode==HttpStatusCode.Unauthorized);
check("Owner onboarding lists saved setup state",(await Read(await owner.GetAsync("/api/onboarding"))).GetProperty("steps").GetArrayLength()==5);
}
}
+26 -1
View File
@@ -6,6 +6,7 @@ against an existing hotel database. Cookie values and credentials are not logged
import json
import os
import sys
import time
from http.cookies import SimpleCookie
from urllib.request import Request, urlopen
from urllib.error import HTTPError
@@ -43,12 +44,36 @@ request("/api/auth/login", "POST", {"email": os.environ["BOOTSTRAP_EMAIL"], "pas
session = request("/api/session")
assert session["user"]["role"] == "Owner"
csrf = session["csrfToken"]
assert request("/health/ready") == {"status": "ready"}
for attempt in range(10):
health = request("/api/operations")
if health["worker"]["state"] == "Reporting":
break
time.sleep(1)
assert health["worker"]["state"] == "Reporting" and health["database"] == "Reachable"
auto_status = request("/api/auto-replies/status")
assert auto_status["liveConfigured"] is False
request("/api/auto-replies/mode", "PUT", {"mode": "Live", "version": 0, "acceptanceConfirmed": True}, expected=400)
payment_status = request("/api/payments/status")
assert payment_status["configured"] is False and payment_status["createsConfigured"] is False
assert "securityKey" not in payment_status
request("/api/payments/controls", "PUT", {"version": 0, "enabled": True}, expected=400)
assert request("/api/payments/requests") == []
hotel = request("/api/hotel")
assert "root" in request("/account"), "Container must serve account link page"
assert len(request("/api/onboarding")["steps"]) == 5
team = request("/api/team")
assert all("passwordHash" not in member and "securityStamp" not in member and "accountLinkHash" not in member for member in team)
if "--read" in sys.argv:
assert hotel["signature"] == "Persisted across container restart"
invited = next(member for member in team if member["email"] == "ci-staff@example.invalid")
assert invited["pending"] and not invited["active"] and invited["linkPurpose"] == "Invite"
else:
hotel["signature"] = "Persisted across container restart"
request("/api/hotel", "PUT", hotel)
invite = request("/api/team/invite", "POST", {"name": "CI Staff", "email": "ci-staff@example.invalid"})
assert invite["link"].startswith("https://sandbox-guestops.futuresens.co.uk/account#token=")
request("/api/auth/logout", "POST")
request("/api/hotel", expected=401)
print("Production smoke checks passed: built UI, secure cookies, owner login, MongoDB settings and logout.")
print("Production smoke checks passed: built UI, secure cookies, owner login, persisted settings and staff invitation, onboarding and logout.")
+97
View File
@@ -0,0 +1,97 @@
import contextlib
import hashlib
import importlib.util
import io
import json
import os
from pathlib import Path
import tarfile
import tempfile
import unittest
from unittest.mock import patch
spec = importlib.util.spec_from_file_location("ops", Path(__file__).resolve().parents[1] / "deploy" / "ops.py")
ops = importlib.util.module_from_spec(spec)
spec.loader.exec_module(ops)
class ArchiveTests(unittest.TestCase):
def test_empty_provider_templates_are_not_secret_configuration(self):
for section, target in (("Pms", "/run/guestops/pms.json"), ("Payments", "/run/guestops/payments.json")):
self.assertFalse(ops.provider_configured({section: {"Hotels": {}}}, target))
self.assertTrue(ops.provider_configured({section: {"Hotels": {"fixture": {"Key": "fixture"}}}}, target))
self.assertTrue(ops.provider_configured({section: {"Unknown": "fixture"}}, target))
def bundle(self, root, change=None):
files = {name: b"fixture backup data" for name in ops.FILES - {"manifest.json"}}
files["manifest.json"] = json.dumps({"format": 1, "sha256": {name: hashlib.sha256(data).hexdigest() for name, data in files.items()}}).encode()
target = root / "bundle.tar"
with tarfile.open(target, "w") as archive:
for name, data in files.items():
member = tarfile.TarInfo(name); member.size = len(data)
if change:
change(member)
archive.addfile(member, io.BytesIO(data) if member.isfile() else None)
return target
def test_checked_archive_roundtrip(self):
with tempfile.TemporaryDirectory() as temp:
root = Path(temp); dest = root / "dest"; dest.mkdir()
self.assertEqual(ops.unpack(self.bundle(root), dest)["format"], 1)
def test_path_escape_rejected(self):
with tempfile.TemporaryDirectory() as temp:
root = Path(temp); dest = root / "dest"; dest.mkdir()
def corrupt(member):
if member.name == "configuration.json": member.name = "../outside"
with self.assertRaisesRegex(RuntimeError, "Unexpected backup members"):
ops.unpack(self.bundle(root, corrupt), dest)
self.assertFalse((root / "outside").exists())
def test_symlink_rejected(self):
with tempfile.TemporaryDirectory() as temp:
root = Path(temp); dest = root / "dest"; dest.mkdir()
def corrupt(member):
if member.name == "configuration.json": member.type = tarfile.SYMTYPE; member.linkname = "/etc/passwd"; member.size = 0
with self.assertRaisesRegex(RuntimeError, "Invalid or oversized"):
ops.unpack(self.bundle(root, corrupt), dest)
def test_checksum_mismatch_rejected(self):
with tempfile.TemporaryDirectory() as temp:
root = Path(temp); dest = root / "dest"; dest.mkdir()
with patch.object(ops, "digest", return_value="changed"):
with self.assertRaisesRegex(RuntimeError, "checksum"):
ops.unpack(self.bundle(root), dest)
def test_backup_requires_explicit_maintenance(self):
with self.assertRaisesRegex(RuntimeError, "confirm-maintenance"):
ops.backup(type("Args", (), {"confirm_maintenance": False})())
@unittest.skipUnless(os.name == "posix", "Linux file permission semantics")
def test_dump_failure_restarts_services_and_ttl(self):
with tempfile.TemporaryDirectory() as temp:
calls = []
def compose(*args, **kwargs):
calls.append(args)
if args[0] == "ps": return b"a" * 64
if "sh" in args: raise RuntimeError("Simulated dump failure")
return b""
def mongo(script):
calls.append((script,))
if "getParameter" in script: return b"true"
if "storageSize" in script: return b'{"bytes":1,"collections":{}}'
return b""
def run(args, **kwargs):
return b'[{"Image":"sha256:fixture"}]' if "inspect" in args else b""
args = type("Args", (), {"confirm_maintenance": True, "recipient": "A" * 40, "output": str(Path(temp) / "backup.gpg")})()
with patch.object(ops, "configuration", return_value={}), patch.object(ops, "run", side_effect=run), patch.object(ops, "compose", side_effect=compose), patch.object(ops, "mongo", side_effect=mongo), patch.object(ops, "maintenance_lock", return_value=contextlib.nullcontext()):
with self.assertRaisesRegex(RuntimeError, "Simulated dump failure"):
ops.backup(args)
self.assertIn(("start", "api", "worker"), calls)
self.assertTrue(any("ttlMonitorEnabled:true" in call[0] for call in calls))
self.assertFalse(Path(args.output).exists())
if __name__ == "__main__":
unittest.main()
+82
View File
@@ -0,0 +1,82 @@
import hashlib
import json
import subprocess
import sys
import tempfile
import unittest
from pathlib import Path
ROOT = Path(__file__).resolve().parents[1]
class ReleaseRecordTests(unittest.TestCase):
def test_writes_versions_checksum_and_immutable_image_ids(self):
with tempfile.TemporaryDirectory() as directory:
artifact = Path(directory) / "guestops-images.tar.gz"
output = Path(directory) / "release-record.json"
artifact.write_bytes(b"reviewed image archive")
subprocess.run(
[
sys.executable,
str(ROOT / "deploy" / "release_record.py"),
"--artifact",
str(artifact),
"--commit",
"a" * 40,
"--api-image",
"guestops-api:" + "a" * 40,
"--api-id",
"sha256:api",
"--worker-image",
"guestops-worker:" + "a" * 40,
"--worker-id",
"sha256:worker",
"--output",
str(output),
],
check=True,
)
record = json.loads(output.read_text(encoding="utf-8"))
self.assertEqual(record["version"], "0.1.0")
self.assertEqual(record["commit"], "a" * 40)
self.assertEqual(record["images"]["api"]["id"], "sha256:api")
self.assertEqual(
record["artifact"]["sha256"],
hashlib.sha256(artifact.read_bytes()).hexdigest(),
)
def test_rejects_abbreviated_commit(self):
with tempfile.TemporaryDirectory() as directory:
artifact = Path(directory) / "images.tar.gz"
artifact.write_bytes(b"fixture")
result = subprocess.run(
[
sys.executable,
str(ROOT / "deploy" / "release_record.py"),
"--artifact",
str(artifact),
"--commit",
"abc123",
"--api-image",
"api:test",
"--api-id",
"sha256:api",
"--worker-image",
"worker:test",
"--worker-id",
"sha256:worker",
"--output",
str(Path(directory) / "record.json"),
],
capture_output=True,
text=True,
)
self.assertNotEqual(result.returncode, 0)
self.assertIn("full 40-character Git SHA", result.stderr)
if __name__ == "__main__":
unittest.main()